You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Zhitao Li <zh...@gmail.com> on 2017/04/11 16:33:09 UTC

Review Request 58358: Upgrade vendored 3rdparty protobuf to 3.2.0.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58358/
-----------------------------------------------------------

Review request for mesos and Anand Mazumdar.


Bugs: MESOS-7228
    https://issues.apache.org/jira/browse/MESOS-7228


Repository: mesos


Description
-------

The content of `3rdparty/protobuf-3.2.0.tar.gz` is generated by:
- On a Mac OS, download and untar protobuf v3.2.0 source at
  https://github.com/google/protobuf/archive/v3.2.0rc2.tar.gz;
- Run `./autogen.sh`;
- Recompress and tar by `tar -czvf`.

Also regenerated stout's protobuf test files.

The old patch should already be included in protobuf 3.0.0, so I'm not re-including it anymore.


Diffs
-----

  3rdparty/CMakeLists.txt bb61ef0514fb164f35b34bb6be1bbebb4d1a1861 
  3rdparty/cmake/Versions.cmake 912726351ff744dd839b8d1c8d64dcc373d879be 
  3rdparty/protobuf-2.6.1.patch bfd3bb2c600383ef05bdb4ea9df0188b4a560315 
  3rdparty/protobuf-2.6.1.tar.gz e1c2d541c1eb806e837ff5d1e9d3fdb678b40e06 
  3rdparty/protobuf-3.2.0.tar.gz PRE-CREATION 
  3rdparty/stout/README.md f4e41aaacee4f88c708413e954553011229c75e4 
  3rdparty/stout/tests/protobuf_tests.pb.h 18870cde806c7bcb0a204de2a40555739adf777b 
  3rdparty/stout/tests/protobuf_tests.pb.cc b2458f0edcf679b2390f87ec8c4bee2b16e71d70 
  3rdparty/versions.am b8144702adca9dd41199f69cb6fb0c0c4b490dbd 


Diff: https://reviews.apache.org/r/58358/diff/1/


Testing
-------


Thanks,

Zhitao Li