[GitHub] [airflow] dhuang commented on a change in pull request #8423: Fix Snowflake hook conn id

[GitBox <gi...@apache.org>]

dhuang commented on a change in pull request #8423: Fix Snowflake hook conn id
URL: https://github.com/apache/airflow/pull/8423#discussion_r410395250
 
 

 ##########
 File path: tests/providers/snowflake/hooks/test_snowflake.py
 ##########
 @@ -102,6 +102,7 @@ def test_get_conn_params(self):
                                 'warehouse': 'af_wh',
                                 'region': 'af_region',
                                 'role': 'af_role'}
+        self.assertEqual(self.db_hook.snowflake_conn_id, 'snowflake_default')
 
 Review comment:
   Hmm yeah that could've been the intent. However, with the way it was implemented it, I believe it also would have overwrote an explicit `snowflake_conn_id` passed into the hook/operator on initialization. But good call, I think it does make sense to note this in `UPDATING.md`, added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services