You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2018/01/19 16:01:55 UTC
[isis] 04/04: ISIS-1569: undeprecates Command#getStartedAt and
Command#getCompletedAt
This is an automated email from the ASF dual-hosted git repository.
danhaywood pushed a commit to branch ISIS-1569-replay-commands
in repository https://gitbox.apache.org/repos/asf/isis.git
commit 0e87db49804a121f4353bee8337daef44ae29afa
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Fri Jan 19 14:52:02 2018 +0000
ISIS-1569: undeprecates Command#getStartedAt and Command#getCompletedAt
---
.../isis/applib/services/command/Command.java | 41 +++++++++++++++++-----
1 file changed, 33 insertions(+), 8 deletions(-)
diff --git a/core/applib/src/main/java/org/apache/isis/applib/services/command/Command.java b/core/applib/src/main/java/org/apache/isis/applib/services/command/Command.java
index a6f458f..ec91580 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/services/command/Command.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/services/command/Command.java
@@ -284,17 +284,30 @@ public interface Command extends HasTransactionId {
* For an command that has actually been executed, holds the date/time at which the {@link Interaction} that
* executed the command started.
*
- * @deprecated - see {@link Interaction#getStartedAt()}.
+ * <p>
+ * Previously this field was deprecated (on the basis that the startedAt is also held in
+ * {@link Interaction.Execution#getStartedAt()}). However, to support replay/replication feature means that
+ * we need to query for persisted {@link Command}s and use this field to ensure the correct ordering.
+ * </p>
+ *
+ * See also {@link Interaction#getCurrentExecution()} and
+ * {@link Interaction.Execution#getStartedAt()}.
*/
- @Deprecated
Timestamp getStartedAt();
/**
* <b>NOT API</b>: intended to be called only by the framework.
*
- * @deprecated - see {@link Interaction#getCurrentExecution()} and {@link org.apache.isis.applib.services.iactn.Interaction.Execution#setStartedAt(Timestamp)}.
+ *
+ * <p>
+ * Previously this field was deprecated (on the basis that the completedAt is also held in
+ * {@link Interaction.Execution#getCompletedAt()}). However, to support replay/replication feature means that
+ * we need to query for persisted {@link Command}s and use this field to ensure the correct ordering.
+ * </p>
+ *
+ * See also {@link Interaction#getCurrentExecution()} and
+ * {@link Interaction.Execution#setStartedAt(Timestamp)}.
*/
- @Deprecated
void setStartedAt(Timestamp startedAt);
//endregion
@@ -305,17 +318,29 @@ public interface Command extends HasTransactionId {
* For an command that has actually been executed, holds the date/time at which the {@link Interaction} that
* executed the command completed.
*
- * @deprecated - see {@link Interaction#getCurrentExecution()} and {@link org.apache.isis.applib.services.iactn.Interaction.Execution#getCompletedAt()}.
+ * <p>
+ * Previously this field was deprecated (on the basis that the completedAt is also held in
+ * {@link Interaction.Execution#getCompletedAt()}). However, to support replay/replication feature means that
+ * we need to query for persisted {@link Command}s and use this field to ensure the correct ordering.
+ * </p>
+ *
+ * See also {@link Interaction#getCurrentExecution()} and
+ * {@link Interaction.Execution#getCompletedAt()}.
*/
- @Deprecated
Timestamp getCompletedAt();
/**
* <b>NOT API</b>: intended to be called only by the framework.
*
- * @deprecated - see {@link org.apache.isis.applib.services.iactn.Interaction.Execution#setCompletedAt(Timestamp)}.
+ * <p>
+ * Previously this field was deprecated (on the basis that the completedAt is also held in
+ * {@link Interaction.Execution#getCompletedAt()}). However, to support replay/replication feature means that
+ * we need to query for persisted {@link Command}s and use this field to ensure the correct ordering.
+ * </p>
+ *
+ * See also {@link Interaction#getCurrentExecution()} and
+ * {@link Interaction.Execution#setCompletedAt(Timestamp)}.
*/
- @Deprecated
void setCompletedAt(Timestamp completedAt);
//endregion
--
To stop receiving notification emails like this one, please contact
"commits@isis.apache.org" <co...@isis.apache.org>.