You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by "Ralph Goers (JIRA)" <ji...@apache.org> on 2012/08/05 05:05:02 UTC
[jira] [Created] (FLUME-1429) PropertiesFileConfigurationProvider
is not extendable
Ralph Goers created FLUME-1429:
----------------------------------
Summary: PropertiesFileConfigurationProvider is not extendable
Key: FLUME-1429
URL: https://issues.apache.org/jira/browse/FLUME-1429
Project: Flume
Issue Type: Improvement
Components: Node
Affects Versions: v1.2.0
Reporter: Ralph Goers
PropertiesFileConfigurationProvider extends AbstractFileConfiguration. AbstractFileConfiguration doesn't really do much but provide getters and setters for a few things. The main logic is in PropertiesFileConfigurationProvider in the form of the loadChannels, loadSources and loadSinks methods. However, these methods are all private. PropertiesFileConfigurationProvider exposes the load method as protected, which should allow a class extending PropertiesFileConfigurationProvider to override it. However, since the previously mentioned methods in PropertiesFileConfigurationProvider are all private they can't be accessed from the extending class.
In addition, classes extending PropertiesFileConfigurationProvider should be provided a load method that accepts a Reader or an InputStream so that they can dynamically create the configuration.
I am building an "embedded Appender" for Log4j 2 and I am essentially having to write my configuration handling from scratch since there is not good way to extend these classes. Similarly, a JMX implementation would encounter the same problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (FLUME-1429) PropertiesFileConfigurationProvider
is not extendable
Posted by "Brock Noland (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FLUME-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brock Noland resolved FLUME-1429.
---------------------------------
Resolution: Duplicate
> PropertiesFileConfigurationProvider is not extendable
> -----------------------------------------------------
>
> Key: FLUME-1429
> URL: https://issues.apache.org/jira/browse/FLUME-1429
> Project: Flume
> Issue Type: Improvement
> Components: Node
> Affects Versions: v1.2.0
> Reporter: Ralph Goers
>
> PropertiesFileConfigurationProvider extends AbstractFileConfiguration. AbstractFileConfiguration doesn't really do much but provide getters and setters for a few things. The main logic is in PropertiesFileConfigurationProvider in the form of the loadChannels, loadSources and loadSinks methods. However, these methods are all private. PropertiesFileConfigurationProvider exposes the load method as protected, which should allow a class extending PropertiesFileConfigurationProvider to override it. However, since the previously mentioned methods in PropertiesFileConfigurationProvider are all private they can't be accessed from the extending class.
> In addition, classes extending PropertiesFileConfigurationProvider should be provided a load method that accepts a Reader or an InputStream so that they can dynamically create the configuration.
> I am building an "embedded Appender" for Log4j 2 and I am essentially having to write my configuration handling from scratch since there is not good way to extend these classes. Similarly, a JMX implementation would encounter the same problems.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira