You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/19 23:48:52 UTC
[GitHub] [maven-compiler-plugin] olamy opened a new pull request, #126: test build with 18 and 19-ea
olamy opened a new pull request, #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on a diff in pull request #126: test build with 18 and 19-ea
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126#discussion_r926436528
##########
.github/workflows/maven-verify.yml:
##########
@@ -24,7 +24,10 @@ on:
jobs:
build:
name: Verify
- uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
+ uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v3
with:
- jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "liberica", "adopt-openj9" ]'
- matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"}]'
+ maven-args: "-Dinvoker.parallelThreads=2"
Review Comment:
yup concurrent download of artifact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] mthmulders commented on a diff in pull request #126: test build with 18 and 19-ea
Posted by GitBox <gi...@apache.org>.
mthmulders commented on code in PR #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126#discussion_r877784583
##########
.github/workflows/maven-verify.yml:
##########
@@ -27,4 +27,5 @@ jobs:
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
with:
jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "liberica", "adopt-openj9" ]'
Review Comment:
Usually, I'd say "a Hotspot VM and an OpenJ9 VM". For OpenJ9, we don't have my choices; for Hotspot, I guess Temurin or maybe Zulu?
But if you're saying there are differences (e.g. in generated Javadoc) and they matter for the m-c-p, then we should include them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] slawekjaranowski commented on a diff in pull request #126: test build with 18 and 19-ea
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126#discussion_r926401148
##########
.github/workflows/maven-verify.yml:
##########
@@ -24,7 +24,10 @@ on:
jobs:
build:
name: Verify
- uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
+ uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v3
with:
- jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "liberica", "adopt-openj9" ]'
- matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"}]'
+ maven-args: "-Dinvoker.parallelThreads=2"
Review Comment:
looks like problem in Maven itself
```
Caused by: java.io.FileNotFoundException: .../local-repo/org/sonatype/plexus/plexus-build-api/0.0.4/plexus-build-api-0.0.4.pom.part (No such file or directory)
``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on a diff in pull request #126: test build with 18 and 19-ea
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126#discussion_r877766284
##########
.github/workflows/maven-verify.yml:
##########
@@ -27,4 +27,5 @@ jobs:
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
with:
jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "liberica", "adopt-openj9" ]'
Review Comment:
probably not :) but as I already got differences (for javadoc) between distributions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy merged pull request #126: test build with 18
Posted by GitBox <gi...@apache.org>.
olamy merged PR #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] mthmulders commented on a diff in pull request #126: test build with 18 and 19-ea
Posted by GitBox <gi...@apache.org>.
mthmulders commented on code in PR #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126#discussion_r877764148
##########
.github/workflows/maven-verify.yml:
##########
@@ -27,4 +27,5 @@ jobs:
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
with:
jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "liberica", "adopt-openj9" ]'
Review Comment:
I know it's not part of this change, but do we really expect big differences between let's say Liberia, Zulu, Microsoft and Temurin? I do see why OpenJ9 is on the list, but all the others are regular Hotspot JVM's, aren't they?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] slawekjaranowski commented on a diff in pull request #126: test build with 18 and 19-ea
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126#discussion_r926340740
##########
.github/workflows/maven-verify.yml:
##########
@@ -24,7 +24,10 @@ on:
jobs:
build:
name: Verify
- uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
+ uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v3
with:
- jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "liberica", "adopt-openj9" ]'
- matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"}]'
+ maven-args: "-Dinvoker.parallelThreads=2"
Review Comment:
Why not in project configuration?
I like values as 1C, 2C, ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on a diff in pull request #126: test build with 18 and 19-ea
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126#discussion_r926342805
##########
.github/workflows/maven-verify.yml:
##########
@@ -24,7 +24,10 @@ on:
jobs:
build:
name: Verify
- uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
+ uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v3
with:
- jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "liberica", "adopt-openj9" ]'
- matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"}]'
+ maven-args: "-Dinvoker.parallelThreads=2"
Review Comment:
because need some good environment and might not suit everyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on a diff in pull request #126: test build with 18 and 19-ea
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126#discussion_r926360495
##########
.github/workflows/maven-verify.yml:
##########
@@ -24,7 +24,10 @@ on:
jobs:
build:
name: Verify
- uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
+ uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v3
with:
- jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "liberica", "adopt-openj9" ]'
- matrix-exclude: '[{ "jdk": "8", "distribution": "microsoft"}]'
+ maven-args: "-Dinvoker.parallelThreads=2"
Review Comment:
btw doesn't work (e.g concurrent access failure https://github.com/apache/maven-compiler-plugin/runs/7444447535?check_suite_focus=true)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-compiler-plugin] olamy commented on a diff in pull request #126: test build with 18 and 19-ea
Posted by GitBox <gi...@apache.org>.
olamy commented on code in PR #126:
URL: https://github.com/apache/maven-compiler-plugin/pull/126#discussion_r877773874
##########
.github/workflows/maven-verify.yml:
##########
@@ -27,4 +27,5 @@ jobs:
uses: apache/maven-gh-actions-shared/.github/workflows/maven-verify.yml@v2
with:
jdk-distribution-matrix: '[ "temurin", "zulu", "microsoft", "liberica", "adopt-openj9" ]'
Review Comment:
@mthmulders what would be your suggestion to limit to which?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org