[GitHub] [trafficserver] whutwhu commented on pull request #6822: change overridable var type for proxy.config.http.server_session_sharing.match from int to string

[GitBox <gi...@apache.org>]

whutwhu commented on pull request #6822:
URL: https://github.com/apache/trafficserver/pull/6822#issuecomment-638347919


   Config proxy.config.http.server_session_sharing.match string value was lost after it converted into an integer mask value for ATS internal usage, we can return back it to string from the mask value,  but too difficult to get the original one for the multiple string setting, as well as the conversion work would be not easy, eg. we can set its value like "both,sni", whose mask value is "23".  
   So we store the original setting of the config string like some other string format configs doing now, then we can get it when need it. The regression can pass now, could you check it, and we also need the fix in 9.0.x branch, since we can merge the fix from upstream into our repo. Thank you! @shinrich @sudheerv 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org