You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by "lprimak (via GitHub)" <gi...@apache.org> on 2024/05/13 16:51:55 UTC
[PR] bugfix(tests): using JUnit's Isolated annotation for tests that touch… [shiro]
lprimak opened a new pull request, #1467:
URL: https://github.com/apache/shiro/pull/1467
… global SecurityManager
<!--
For Security Vulnerabilities, please email: security@shiro.apache.org
For more details on how to report a vulnerablity see: https://www.apache.org/security/
-->
Following this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [GitHub issue](https://github.com/apache/shiro/issues) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[#XXX] - Fixes bug in SessionManager`,
where you replace `#XXX` with the appropriate GitHub issue. Best practice
is to use the GitHub issue title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] add `fixes #XXX` if merging the PR should close a related issue.
- [ ] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
- [ ] Committers: Make sure a milestone is set on the PR
Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like `[DOC] - Add javadoc in SessionManager`.
If this is your first contribution, you have to read the [Contribution Guidelines](https://github.com/apache/shiro/blob/master/CONTRIBUTING.md)
If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1603914639
##########
pom.xml:
##########
@@ -278,6 +278,12 @@
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
Review Comment:
<properties> is the test mojo element. configurationParameters Is nested inside which is valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1604167197
##########
pom.xml:
##########
@@ -278,6 +278,12 @@
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
+ junit.jupiter.execution.parallel.enabled = true
+ junit.jupiter.execution.parallel.mode.default = concurrent
Review Comment:
I have done a quick test and `junit.jupiter.execution.parallel.mode.classes.default = concurrent` has no effect if `junit.jupiter.execution.parallel.mode.default = concurrent` is already present, which it is :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1603896087
##########
pom.xml:
##########
@@ -278,6 +278,12 @@
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
Review Comment:
Tests run in parallel. Taken from here: https://rieckpil.de/parallelize-only-java-unit-tests-with-junit-5-and-maven/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1604427700
##########
pom.xml:
##########
@@ -278,6 +278,12 @@
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
Review Comment:
Found the docs:
https://maven.apache.org/surefire/maven-surefire-plugin/examples/junit-platform.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1604169427
##########
pom.xml:
##########
@@ -274,6 +274,7 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>@{jacocoAgent} @{surefire.argLine}</argLine>
+ <parallel>all</parallel>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1599355875
##########
pom.xml:
##########
@@ -274,6 +274,7 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>@{jacocoAgent} @{surefire.argLine}</argLine>
+ <parallel>all</parallel>
Review Comment:
Doesn't work with junit Jupiter. Instead, use their properties in argLine or resource property files.
The latter will be picked up by IDEs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1603914639
##########
pom.xml:
##########
@@ -278,6 +278,12 @@
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
Review Comment:
`<properties>` is the test mojo element. configurationParameters Is nested inside which is valid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1603915326
##########
pom.xml:
##########
@@ -278,6 +278,12 @@
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
+ junit.jupiter.execution.parallel.enabled = true
+ junit.jupiter.execution.parallel.mode.default = concurrent
Review Comment:
I don’t think your addition is actually necessary. That is on by default and can be overridden to be disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1604167197
##########
pom.xml:
##########
@@ -278,6 +278,12 @@
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
+ junit.jupiter.execution.parallel.enabled = true
+ junit.jupiter.execution.parallel.mode.default = concurrent
Review Comment:
I have done a quick test and `junit.jupiter.execution.parallel.mode.classes.default = concurrent` has no effect if `junit.jupiter.execution.parallel.mode.default = concurrent` is already present, which it is :)
Below, three classes have three tests, each sleep 10 seconds. Total amount to run tests is 10 seconds without `.classes.default`
```
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running TwoTest
[INFO] Running OneTest
[INFO] Running ThreeTest
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.08 s -- in OneTest
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.08 s -- in TwoTest
[INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.08 s -- in ThreeTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 9, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jar:3.4.1:jar (default-jar) @ junit-parallel-tests ---
[INFO] Building jar: /Users/lprimak/dev/experiments/junit-parallel-tests/target/junit-parallel-tests-1.x-SNAPSHOT.jar
[INFO] Copying com.flowlogix.depchain:junit-parallel-tests:pom:1.x-SNAPSHOT to project local repository
[INFO] Copying com.flowlogix.depchain:junit-parallel-tests:jar:1.x-SNAPSHOT to project local repository
[INFO] Copying com.flowlogix.depchain:junit-parallel-tests:pom:consumer:1.x-SNAPSHOT to project local repository
[INFO] --------------------------------------------------------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] --------------------------------------------------------------------------------------------------------------------------
[INFO] Total time: 11.975 s (Wall Clock)
[INFO] Finished at: 2024-05-16T18:12:22-05:00
[INFO] --------------------------------------------------------------------------------------------------------------------------
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1600602679
##########
pom.xml:
##########
@@ -274,17 +274,25 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>@{jacocoAgent} @{surefire.argLine}</argLine>
+ <parallel>all</parallel>
Review Comment:
Can be removed
##########
pom.xml:
##########
@@ -274,17 +274,25 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>@{jacocoAgent} @{surefire.argLine}</argLine>
+ <parallel>all</parallel>
<shutdown>kill</shutdown>
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
+ junit.jupiter.execution.parallel.enabled = true
+ junit.jupiter.execution.parallel.mode.default = concurrent
+ </configurationParameters>
+ </properties>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<configuration>
<argLine>@{jacocoAgent} @{failsafe.argLine}</argLine>
+ <parallel>classes</parallel>
Review Comment:
Same here... You can remove this and add properties instead (either argLine or file or other means).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1613705445
##########
config/ogdl/src/test/groovy/org/apache/shiro/config/ogdl/ReflectionBuilderTest.groovy:
##########
@@ -36,6 +37,7 @@ import static org.hamcrest.Matchers.*
/**
* Unit tests for the {@link org.apache.shiro.config.ogdl.ReflectionBuilder} implementation.
*/
+@Isolated
Review Comment:
nit: add reason for needing to be isolated (we can possibly fix it in the future)
##########
config/ogdl/src/test/groovy/org/apache/shiro/config/ogdl/CommonsInterpolatorTest.groovy:
##########
@@ -28,6 +29,7 @@ import static org.junit.jupiter.api.Assertions.assertNull
* Tests for {@link org.apache.shiro.config.ogdl.CommonsInterpolator}.
* @since 1.4
*/
+@Isolated
Review Comment:
```suggestion
@Isolated("System property usage")
```
##########
core/src/test/groovy/org/apache/shiro/authc/credential/DefaultPasswordServiceTest.groovy:
##########
@@ -38,6 +39,7 @@ import static org.junit.jupiter.api.Assertions.*
*
* @since 1.2
*/
+@Isolated
Review Comment:
nit: add reason
##########
web/src/test/groovy/org/apache/shiro/web/util/WebUtilsTest.groovy:
##########
@@ -31,7 +32,8 @@ import static org.junit.jupiter.api.Assertions.*
/**
* Tests for {@link WebUtils}.
*/
-public class WebUtilsTest {
+@Isolated
Review Comment:
```suggestion
@Isolated("Uses System Properties")
```
##########
core/src/test/java/org/apache/shiro/authc/AbstractAuthenticatorTest.java:
##########
@@ -40,6 +41,7 @@
/**
* @since 0.1
*/
+@Isolated
Review Comment:
nit: add reason
##########
web/src/test/java/org/apache/shiro/web/mgt/DefaultWebSecurityManagerTest.java:
##########
@@ -56,6 +57,7 @@
/**
* @since 0.9
*/
+@Isolated
Review Comment:
nit: add reason
##########
support/ehcache/src/test/java/org/apache/shiro/cache/ehcache/EhCacheManagerTest.java:
##########
@@ -37,6 +38,7 @@
*
* @since May 11, 2010 12:41:38 PM
*/
+@Isolated
Review Comment:
nit: add reason
##########
web/src/test/groovy/org/apache/shiro/web/filter/InvalidRequestFilterTest.groovy:
##########
@@ -29,6 +30,7 @@ import static org.easymock.EasyMock.mock
import static org.easymock.EasyMock.replay
import static org.hamcrest.MatcherAssert.assertThat
+@Isolated
Review Comment:
```suggestion
@Isolated("Uses System Properties")
```
##########
web/src/test/groovy/org/apache/shiro/web/config/IniFilterChainResolverFactoryTest.groovy:
##########
@@ -41,6 +42,7 @@ import static org.hamcrest.MatcherAssert.assertThat
*
* @since 1.2
*/
+@Isolated
Review Comment:
nit: add reason
My guess is that the INI / reflection builder _might_ be sys prop related?
##########
web/src/test/groovy/org/apache/shiro/web/servlet/AbstractShiroFilterTest.groovy:
##########
@@ -31,6 +33,7 @@ import static org.junit.jupiter.api.Assertions.*
/**
* Unit tests for the {@link AbstractShiroFilter} implementation.
*/
+@Isolated
Review Comment:
```suggestion
@Isolated("Uses System Properties and Static Security Manager")
```
##########
tools/hasher/src/test/java/org/apache/shiro/tools/hasher/HasherTest.java:
##########
@@ -42,6 +43,7 @@
/**
* @since 2.0
*/
+@Isolated
Review Comment:
```suggestion
@Isolated("Uses System Input")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1604169566
##########
pom.xml:
##########
@@ -274,17 +274,25 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>@{jacocoAgent} @{surefire.argLine}</argLine>
+ <parallel>all</parallel>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1614276836
##########
config/ogdl/src/test/groovy/org/apache/shiro/config/ogdl/ReflectionBuilderTest.groovy:
##########
@@ -36,6 +37,7 @@ import static org.hamcrest.Matchers.*
/**
* Unit tests for the {@link org.apache.shiro.config.ogdl.ReflectionBuilder} implementation.
*/
+@Isolated
Review Comment:
haha Dunno.. cause it failed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak merged PR #1467:
URL: https://github.com/apache/shiro/pull/1467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1600914492
##########
pom.xml:
##########
@@ -274,17 +274,25 @@
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<argLine>@{jacocoAgent} @{surefire.argLine}</argLine>
+ <parallel>all</parallel>
<shutdown>kill</shutdown>
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
+ junit.jupiter.execution.parallel.enabled = true
+ junit.jupiter.execution.parallel.mode.default = concurrent
+ </configurationParameters>
+ </properties>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-failsafe-plugin</artifactId>
<configuration>
<argLine>@{jacocoAgent} @{failsafe.argLine}</argLine>
+ <parallel>classes</parallel>
Review Comment:
Probably not gonna happen for failsafe... getting integration tests to run in parallel is a *lot* more difficult
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bugfix(tests): using JUnit's ResourceLock annotation for tests that touch… [shiro]
Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on code in PR #1467:
URL: https://github.com/apache/shiro/pull/1467#discussion_r1603874424
##########
pom.xml:
##########
@@ -278,6 +278,12 @@
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
+ junit.jupiter.execution.parallel.enabled = true
+ junit.jupiter.execution.parallel.mode.default = concurrent
Review Comment:
Have you tried concurrent methods as well?
##########
pom.xml:
##########
@@ -278,6 +278,12 @@
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
+ junit.jupiter.execution.parallel.enabled = true
+ junit.jupiter.execution.parallel.mode.default = concurrent
Review Comment:
```suggestion
junit.jupiter.execution.parallel.mode.default = concurrent
junit.jupiter.execution.parallel.mode.classes.default = concurrent
```
##########
pom.xml:
##########
@@ -278,6 +278,12 @@
<enableProcessChecker>native</enableProcessChecker>
<trimStackTrace>false</trimStackTrace>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
+ <properties>
+ <configurationParameters>
Review Comment:
`configurationParameters` does not exist: https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html
Either create a junit-platform.properties in every `src/test/resources` folder, OR use surefire's argLine.
The first approach will have the advantage that IntelliJ and others will pick it up. The second is DRY-compatible (but that may actually be a disadvantage)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org