[jira] [Commented] (GEODE-2730) Refactor ServerStarterRule and LocatorStarterRule

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15950026#comment-15950026 ] 

ASF subversion and git services commented on GEODE-2730:
--------------------------------------------------------

Commit 50f6d1e39213ed64f5cc38b0438c63bd21482e60 in geode's branch refs/heads/develop from [~jstewart]
[ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=50f6d1e ]

GEODE-2730: Refactor ServerStarterRule and LocatorStarterRule

- Introduced LocalServerStarterRule and LocalLocatorStarterRule to eventually replace LocatorStarterRule and ServerStarterRule.
- The new rules will *only* start a member through the rule's before() method.  Members will *never* be started on Rule instantiation.
- The new rules are backed by Builders that use AvailablePort.Keeper to reserve the ports that a member will use when it eventually starts.  The Keepers are released just before starting the member, with the goal of minimizing test flakiness caused by BindExceptions when a port is already in use.


> Refactor ServerStarterRule and LocatorStarterRule
> -------------------------------------------------
>
>                 Key: GEODE-2730
>                 URL: https://issues.apache.org/jira/browse/GEODE-2730
>             Project: Geode
>          Issue Type: Improvement
>          Components: management
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>
> Right now many tests that use ServerStarterRule and LocatorStarterRule are flaky due to relying on default ports that intermittently cause BindExceptions when those ports are in use. They also do not consistently use the @Rule lifecycle to manage starting the member, but can optionally start members when the rule is instantiated.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)