[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6426: Fix gcs listFiles

[GitBox <gi...@apache.org>]

fx19880617 commented on a change in pull request #6426:
URL: https://github.com/apache/incubator-pinot/pull/6426#discussion_r556107495



##########
File path: pinot-plugins/pinot-file-system/pinot-gcs/src/main/java/org/apache/pinot/plugin/filesystem/GcsPinotFS.java
##########
@@ -313,8 +314,12 @@ public long length(URI fileUri) throws IOException {
       }
       page.iterateAll()
           .forEach(blob -> {
-            if (!blob.getName().equals(fileUri.getPath())) {
-              builder.add(blob.getName());
+            if (!blob.getName().equals(prefix)) {
+              try {
+                builder.add(new URI(SCHEME, fileUri.getHost(), DELIMITER + blob.getName(), null).toString());

Review comment:
       I think the blob is not guaranteed to has the gs URI .




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org