You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "johbossle (via GitHub)" <gi...@apache.org> on 2023/06/27 08:45:41 UTC
[GitHub] [camel] johbossle opened a new pull request, #10505: Add possibility to override LRAClient
johbossle opened a new pull request, #10505:
URL: https://github.com/apache/camel/pull/10505
# Description
As a follow up on #10498
The Saga EIP pattern is using rest based communication for interaction with the lra-coordinator (e.g. narayana). Although there are ways to secure the communication with the coordinator, this is not supported by the underlying code. Also, it is not possible to easily override some implementations, since they are created by internal constructors.
This change is targeting, that one can override (influence) the creation of the LRAClient in the LRASagaService. With this "extension", it is then possible to override some default behavior and for example you can set the HttpClient and use your own adjusted instance with an Authenticator or ssl-settings.
# Target
- [x] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
# Apache Camel coding standards and style
- [x] I checked that each commit in the pull request has a meaningful subject line and body.
- [x] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10505: Add possibility to override LRAClient
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10505:
URL: https://github.com/apache/camel/pull/10505#issuecomment-1609682437
Yes @oscerd is correct we need also to remember to cherry pick this to main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10505: Add possibility to override LRAClient
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10505:
URL: https://github.com/apache/camel/pull/10505#issuecomment-1609684175
If this is a good idea to backport to 3.20.x/3.21.x etc then we need a JIRA to track each non-trivial change in LTS branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10505: Add possibility to override LRAClient
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10505:
URL: https://github.com/apache/camel/pull/10505#issuecomment-1609162816
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 1 | 1 | 0 | 1 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10505: Add possibility to override LRAClient
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10505:
URL: https://github.com/apache/camel/pull/10505#issuecomment-1609061731
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #10505: Add possibility to override LRAClient
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #10505:
URL: https://github.com/apache/camel/pull/10505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] johbossle commented on pull request #10505: Add possibility to override LRAClient
Posted by "johbossle (via GitHub)" <gi...@apache.org>.
johbossle commented on PR #10505:
URL: https://github.com/apache/camel/pull/10505#issuecomment-1610864712
Just want to end up here with an example usage pattern to supply custom authentication header:
```java
public class AuthenticatingLRASagaService extends LRASagaService {
@Override
protected LRAClient createLRAClient() {
return new LRAClient(this, HttpClient.newBuilder().build()){
@Override
protected HttpRequest.Builder prepareRequest(URI uri) {
HttpRequest.Builder builder = super.prepareRequest(uri);
builder.header("Authentication", "MY_TOKEN");
return builder;
}
};
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10505: Add possibility to override LRAClient
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10505:
URL: https://github.com/apache/camel/pull/10505#issuecomment-1609427033
### Components test results:
| Total | Tested | Failed :x: | Passed :white_check_mark: |
| --- | --- | --- | --- |
| 2 | 2 | 0 | 2 |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10505: Add possibility to override LRAClient
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10505:
URL: https://github.com/apache/camel/pull/10505#issuecomment-1609427058
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] johbossle commented on pull request #10505: Add possibility to override LRAClient
Posted by "johbossle (via GitHub)" <gi...@apache.org>.
johbossle commented on PR #10505:
URL: https://github.com/apache/camel/pull/10505#issuecomment-1609754534
> Yes @oscerd is correct we need also to remember to cherry pick this to main branch
@davsclaus Is there something where I can help to cherry-pick and port to main-branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10505: Add possibility to override LRAClient
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10505:
URL: https://github.com/apache/camel/pull/10505#issuecomment-1609162844
:no_entry_sign: There are (likely) no changes in core core to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10505: Add possibility to override LRAClient
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10505:
URL: https://github.com/apache/camel/pull/10505#issuecomment-1610001153
No its fine we could cherry pick this cleanly to main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org