Re: Review Request 20024: ACCUMULO-2627 use try-with-resources

[Christopher Tubbs <ct...@apache.org>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20024/#review80063
-----------------------------------------------------------



core/src/main/java/org/apache/accumulo/core/client/ScannerBase.java
<https://reviews.apache.org/r/20024/#comment129828>

    Closeable is for streams. Any interfaces/classes extended to include a close method should be extending AutoCloseable, unless there's a good reason for it to be treated like a stream (with IOException), and especially if we want to throw another exception type.


- Christopher Tubbs


On April 4, 2014, 8:41 p.m., Mike Drob wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20024/
> -----------------------------------------------------------
> 
> (Updated April 4, 2014, 8:41 p.m.)
> 
> 
> Review request for accumulo.
> 
> 
> Bugs: ACCUMULO-2627
>     https://issues.apache.org/jira/browse/ACCUMULO-2627
> 
> 
> Repository: accumulo
> 
> 
> Description
> -------
> 
> Take advantage of JAVASEVEN feature for AutoCloseable and try-with-resoures syntactic sugar.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/accumulo/core/bloomfilter/BloomFilter.java 65ed3006ab53c5f7faf37f47eb864abbccef4461 
>   core/src/main/java/org/apache/accumulo/core/client/ScannerBase.java 26056b89d7842dcf89f8a40868ba09ed73e90b4a 
>   core/src/main/java/org/apache/accumulo/core/client/admin/TableOperationsImpl.java 61811ccb708097a11ebabb4c63ba384d1c78b51a 
>   core/src/main/java/org/apache/accumulo/core/client/lexicoder/BigIntegerLexicoder.java 12bcdd2db3d2ac95e91e3ed9189615529cc19ae8 
>   core/src/main/java/org/apache/accumulo/core/client/lexicoder/UUIDLexicoder.java 4611b257c775108228be898dacf0127ca5cb62a3 
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/InputConfigurator.java c7b35209703b94b4888150c3d4cd350d2dc76137 
>   core/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/util/OutputConfigurator.java 81f81a712ada4864e277057e283ce4fb0c04e817 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockShell.java a8061f77328f9f09d30bc68c7d90bed23c0d3e77 
>   core/src/main/java/org/apache/accumulo/core/client/mock/MockTableOperations.java d3b1571d0de9562a12180b83a9bbec33474e42f1 
>   core/src/main/java/org/apache/accumulo/core/client/security/tokens/AuthenticationToken.java 99cc7212a373cc8c1399c531afb2b15252bb6894 
>   core/src/main/java/org/apache/accumulo/core/conf/ConfigurationDocGen.java 8ed55061c86177ea1cdf3a8505da0b403ae49080 
>   core/src/main/java/org/apache/accumulo/core/data/KeyExtent.java 4c9978fc47fdf1f16b9f983bcc27866c9cae95d3 
>   core/src/main/java/org/apache/accumulo/core/file/BloomFilterLayer.java 7dcbab7ff1bd21bfe4c3fb3e5cf29b5944463cc3 
>   core/src/main/java/org/apache/accumulo/core/file/FileSKVIterator.java 2de5cfc8e404d7ce5920e9b806d33195813642f9 
>   core/src/main/java/org/apache/accumulo/core/file/FileSKVWriter.java 8718515038c7d45cc5ea7ae81d0f4d975beb2589 
>   core/src/main/java/org/apache/accumulo/core/file/blockfile/ABlockReader.java 592d3250f18be069d4f91e82c060a4a2efedf3ad 
>   core/src/main/java/org/apache/accumulo/core/file/blockfile/ABlockWriter.java 19b6f0cbc62580a0a444b097f73d16af1e7c7804 
>   core/src/main/java/org/apache/accumulo/core/file/blockfile/BlockFileWriter.java cf860065ff5137c2b9ac1434d6559269fa5ebbb3 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/MultiLevelIndex.java 632968e432dddc53f4c9785b40462bafc069cb86 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java dc54b49ee1d51165dbd4e1d02556b454575dde9d 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java da5a3eaaef075602a8ae7ae0f9258c117424800e 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/SplitLarge.java 53e4aaa8428b93cf4e7c228cd6aab91de7e013ab 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BCFile.java 6c3ea0d0a6a9e7b00ac48d0c5260784dabc699e3 
>   core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/PrintInfo.java f387cc2e0b1cf2c6f0494ce7831773b91386eede 
>   core/src/main/java/org/apache/accumulo/core/security/crypto/CachingHDFSSecretKeyEncryptionStrategy.java e5ad13daf73c4864cd630a0c0629f2ad6f1f092d 
>   core/src/main/java/org/apache/accumulo/core/security/crypto/NonCachingSecretKeyEncryptionStrategy.java 67278bfde1725c4d483063310392433ba1c40cca 
>   core/src/main/java/org/apache/accumulo/core/util/CreateToken.java 29206597e1ef66a55696b4ba84144a5e73848dc8 
>   core/src/main/java/org/apache/accumulo/core/util/shell/Shell.java f481395a5089476bce710ca64ceca5fb4e7a9580 
>   core/src/main/java/org/apache/accumulo/core/util/shell/ShellOptionsJC.java 38692a039deea561bb8933adc22f63051e32c93e 
>   core/src/main/java/org/apache/accumulo/core/util/shell/ShellUtil.java f0dd505fb3341c0cf405bffc0fd3629a4fc6b26c 
>   core/src/main/java/org/apache/accumulo/core/util/shell/commands/ExecfileCommand.java f4a2632874dfb783e9bd8a48b27c3c63db51a764 
>   core/src/main/java/org/apache/accumulo/core/util/shell/commands/GrepCommand.java c2ff23253b262de30e8778b4535d52902c5e2945 
>   core/src/main/java/org/apache/accumulo/core/util/shell/commands/ScriptCommand.java 5a0eee08081eb84eb3cf95b57dd5b15d238e32a6 
>   core/src/test/java/org/apache/accumulo/core/cli/TestClientOpts.java eb7f85bfcc3f1dc89af8b064408be608074fe346 
>   core/src/test/java/org/apache/accumulo/core/client/mapred/TokenFileTest.java 0e1fe3904a2f2dd094837eabc2df9852ba1714ff 
>   core/src/test/java/org/apache/accumulo/core/client/mapreduce/InputTableConfigTest.java 7f5c7d8a4c8f9bf4b301318cb6171c941b001524 
>   core/src/test/java/org/apache/accumulo/core/client/mapreduce/TokenFileTest.java fd207a19443f12acdc5544d0befdd171886b4b20 
>   core/src/test/java/org/apache/accumulo/core/client/mock/MockTableOperationsTest.java 94dbed11b33b090dbab20237165ed95a22ab82f2 
>   core/src/test/java/org/apache/accumulo/core/data/MutationTest.java 33b060e04ace6deea4b169cd02dd0bb797e81b14 
>   core/src/test/java/org/apache/accumulo/core/data/RangeTest.java 1f9a40d2d03dd31440da9d1941c3b111d59479fb 
>   core/src/test/java/org/apache/accumulo/core/data/ValueTest.java cd26743cc60fcdfed83632c57820e1f4da4f30f6 
>   core/src/test/java/org/apache/accumulo/core/file/FileOperationsTest.java 30c667ddd78fa30c58d1211ae08763c82cd5d9e9 
>   core/src/test/java/org/apache/accumulo/core/file/rfile/BlockIndexTest.java f2937188091923cf7783c0b84ed64ff419660ca8 
>   core/src/test/java/org/apache/accumulo/core/file/rfile/CreateCompatTestFile.java 46c2f0e63eda5fb706838118e0c35fb5fda946ae 
>   core/src/test/java/org/apache/accumulo/core/file/rfile/MultiLevelIndexTest.java 04874955f34d7f95a62ad55345fd615625c01265 
>   core/src/test/java/org/apache/accumulo/core/file/rfile/RFileTest.java ccbefb2e834b8f7a27ecad3d7c70d1b8088b1a46 
>   core/src/test/java/org/apache/accumulo/core/iterators/user/TransformingIteratorTest.java 4cebab7bab2255946762796ceeba5ac70f31f3fa 
>   core/src/test/java/org/apache/accumulo/core/security/crypto/BlockedIOStreamTest.java 8ea55a6b4c6079245d71a1f38d3481e15a6c1495 
>   core/src/test/java/org/apache/accumulo/core/security/crypto/CryptoTest.java 605e43ae4c08d735d51070cf8263598193f8813b 
>   core/src/test/java/org/apache/accumulo/core/util/shell/PasswordConverterTest.java d1d24a62e3471a5455fcd539e0c24cccf4109858 
>   examples/simple/src/main/java/org/apache/accumulo/examples/simple/client/RandomBatchScanner.java 29271ff55976e567ada7f4f8f54b9e19cb771068 
>   examples/simple/src/main/java/org/apache/accumulo/examples/simple/filedata/FileDataIngest.java 78fef0de56db988d39c170e5e7e64206c97c6214 
>   examples/simple/src/main/java/org/apache/accumulo/examples/simple/mapreduce/bulk/GenerateTestData.java 5cb4a0b3d8718f28eb3ceef0c54ab6457ab3b172 
>   examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/ContinuousQuery.java 5367a44583fcbe56d2ae67f3839a9be956aedcff 
>   examples/simple/src/main/java/org/apache/accumulo/examples/simple/shard/Index.java 47310612c4ff05c5ad15eeb270881d0a8c1e77da 
>   examples/simple/src/test/java/org/apache/accumulo/examples/simple/filedata/ChunkInputStreamTest.java 54279e465f6c84bf4a673e64f0920d7c575e0ad2 
>   fate/src/main/java/org/apache/accumulo/fate/ZooStore.java 5fc1858ac79d85805d68347002bb20a1ae745fb3 
>   fate/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java e793a696b66f1cf6fa160bd2829f6ab5b3ae0b67 
>   minicluster/src/main/java/org/apache/accumulo/minicluster/MiniAccumuloRunner.java f7070dc32e8f300f626bbcb3cbaf85dcc2755d12 
>   minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java d05471873edfb7a105abc74de637d54df8bb6783 
>   proxy/src/main/java/org/apache/accumulo/proxy/Proxy.java 3e404b1bdfae50a5e4b0fe9e571c384405d4f7bb 
>   proxy/src/test/java/org/apache/accumulo/proxy/SimpleProxyIT.java 62e5b644ba5100dc7714de397ab7892f3b245feb 
>   server/base/src/main/java/org/apache/accumulo/server/Accumulo.java 29ed2b7f092db1e9e8531c4680dce08f70135dba 
>   server/base/src/main/java/org/apache/accumulo/server/client/BulkImporter.java 27ab0789e5348a7b3e35636a40b3c956cb55ca7d 
>   server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java 2ef438ffdce65fe5504f40578a85a935564cfe3f 
>   server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java 10cdce6cd04a1b1f5230e768eec8c14643a206ff 
>   server/base/src/main/java/org/apache/accumulo/server/master/state/MetaDataTableScanner.java 155a5d2597d6c0b6a1e79969868e16d783c399ae 
>   server/base/src/main/java/org/apache/accumulo/server/problems/ProblemReport.java 99349b19c78f2b9139cc022ba1eeeadbfdb0e8cb 
>   server/base/src/main/java/org/apache/accumulo/server/util/Admin.java 224f786bd646005b6ad9d43013ddc380919f8685 
>   server/base/src/main/java/org/apache/accumulo/server/util/FileSystemMonitor.java 665bf2529595004dec3c775396ba8df446139b10 
>   server/base/src/main/java/org/apache/accumulo/server/util/RestoreZookeeper.java e2faf3cf0e7360549be64707b95c4dfb0abad82a 
>   server/base/src/main/java/org/apache/accumulo/server/util/SendLogToChainsaw.java ee01bb2ee22bb1c96ed2f0056031cfd8b0ff6a70 
>   server/base/src/main/java/org/apache/accumulo/server/util/TBufferedServerSocket.java 2962a5226b41348bd945e3a94ca8489d6c216707 
>   server/base/src/test/java/org/apache/accumulo/server/client/BulkImporterTest.java 36803411940da01f22c5ba4696c4955329a6dc6b 
>   server/base/src/test/java/org/apache/accumulo/server/fs/VolumeUtilTest.java 0013d046d6f25a27b64946ea2bbf935b83eea767 
>   server/base/src/test/java/org/apache/accumulo/server/problems/ProblemReportTest.java dbad3260ecab5a54e9f50a07f3b76c0c14c6c86b 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/BulkImport.java 06ae7aab685dcf819a7bc2a7dda00ce6ef4c0cc1 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/DeleteTable.java d264f14bc7f3efcb5bc3b2c2c78adfe1fce43cac 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ExportTable.java 1818fa5ad82855c987c2c8e53d791a4f703766b0 
>   server/master/src/main/java/org/apache/accumulo/master/tableOps/ImportTable.java f3d28048fcaf07312ecb2c3bf46e9fa1031037b1 
>   server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/DefaultServlet.java 5f81a7493ea1fda7eb09dcada02fddf4ad57a18f 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/InMemoryMap.java dc367187e23014eb34a9c8fb26050694ebeccfdb 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/Tablet.java fadf4ede7ee21f779cf11ee1b5dcd33b528951ba 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/LogSorter.java 4badefa9d3b1c714fa74799551befebfb202b76f 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/log/MultiReader.java 541f075f0a77e0a8a1232a2bde3ff2eac1a1bba7 
>   server/tserver/src/main/java/org/apache/accumulo/tserver/logger/LogReader.java 575e49e9a1e32a8e19d429691f2c2080f0214d2e 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/log/MultiReaderTest.java a79e77e76602811ca7c59514ce044d8bca3610e7 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/log/SortedLogRecoveryTest.java fffa15e6945c79a217768cb8bfc38d78780881e8 
>   server/tserver/src/test/java/org/apache/accumulo/tserver/log/TestUpgradePathForWALogs.java d6c23e381b4876142fc7931c990294a55c5c4373 
>   start/src/main/java/org/apache/accumulo/start/classloader/vfs/MiniDFSUtil.java c822f64a3ddbc7047c1bf23377d2b8dfbb68c14e 
>   start/src/test/java/org/apache/accumulo/start/classloader/vfs/AccumuloVFSClassLoaderTest.java e7c369e6d6afcd73532d92215326bac1539a00fa 
>   test/src/main/java/org/apache/accumulo/test/CreateRandomRFile.java 5ef168106aae9ea13567144c47a7550db48eb61c 
>   test/src/main/java/org/apache/accumulo/test/continuous/ContinuousIngest.java 2aca57950dbb56350e02a910b5d0eb28063daec1 
>   test/src/main/java/org/apache/accumulo/test/continuous/Histogram.java bb9183433fd288822ac22ef75ee0466be95194a8 
>   test/src/main/java/org/apache/accumulo/test/continuous/PrintScanTimeHistogram.java eebc4259560cd163073c5767afc7352ee11b1471 
>   test/src/main/java/org/apache/accumulo/test/continuous/UndefinedAnalyzer.java efcdcf1d48a701d6049519b8322da9c52713b6c4 
>   test/src/main/java/org/apache/accumulo/test/functional/CacheTestReader.java 8d5cc1694c59fb4f1f659867b9378e3c87be8f3a 
>   test/src/main/java/org/apache/accumulo/test/functional/CacheTestWriter.java 59541717e235363deb3df9753daeb879fc14932a 
>   test/src/main/java/org/apache/accumulo/test/performance/scan/CollectTabletStats.java d2c8d0fab774be791cb3f1cb7e50ef1ad0225f5f 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/Framework.java 56fb36678d911a6aacf4c1bfb2abceb91a9cab8f 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/bulk/BulkPlusOne.java d605e8e5ce127829be10be0405698e000d92152a 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/concurrent/BatchScan.java 6afc7c84f561c5e3cbe304e6a5b3e8358c34a221 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/Transfer.java 4d0e7517a67a6363328cfa167e22b6e6baa39a67 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/conditional/Verify.java 8acc3ed9a6276384cbafd0b1597b79225506695d 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/security/TableOp.java ef4593c5dc64ada95dd319e48368b1ae3bddf3ad 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/sequential/BatchVerify.java 6a725c7deb6a370d11b1f9971174182cbb30a51f 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/BulkInsert.java 3b9a92aad39e8470f9e38d2cc14da116f0cfcade 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/DeleteSomeDocs.java ed0a4582723a2fdb4b8b61936b69fc7a8c53091d 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/DeleteWord.java 10bbff3ea861d0c76f2d99498b79e57cbcd00c71 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/ExportIndex.java f625870e1397242447aaf9911402939dd5386af1 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Grep.java 66d53d852d528b0881118e30fc9d023172486a2e 
>   test/src/main/java/org/apache/accumulo/test/randomwalk/shard/Search.java c8888a12b09579afe65255027caab49e97e2fc08 
>   test/src/test/java/org/apache/accumulo/test/AuditMessageIT.java a4f05754369bab08e018d385ba0f3e97c589ea37 
>   test/src/test/java/org/apache/accumulo/test/ConditionalWriterIT.java 15c1fd3fa39d07e6b1c873b04a84fc327a5fe989 
>   test/src/test/java/org/apache/accumulo/test/ShellServerIT.java b3d44e34860e732918c8a440d908036d4fd68469 
>   test/src/test/java/org/apache/accumulo/test/VolumeIT.java b80c3def5203aef5f0438077a6a6c919421b3032 
>   test/src/test/java/org/apache/accumulo/test/functional/BatchScanSplitIT.java 567a3860068ecca15a8ba65ca0c90d23a9df9e0e 
>   test/src/test/java/org/apache/accumulo/test/functional/BloomFilterIT.java 9ba713dfc216cf0922148fb0b12034795847cef1 
>   test/src/test/java/org/apache/accumulo/test/functional/BulkFileIT.java e8e0793a8b5396791b77a5b8712049bf74c4f699 
>   test/src/test/java/org/apache/accumulo/test/functional/ConfigurableMacIT.java d9bed7ff13ab1883c5c4017137d8f5bbcbc6124e 
>   test/src/test/java/org/apache/accumulo/test/functional/ExamplesIT.java 856f6638c8045971dbebbf0c33e242d57bd5a9c4 
>   test/src/test/java/org/apache/accumulo/test/functional/MaxOpenIT.java 72ad0f75c7b2d9d41f574f2ff43050f306141b49 
>   test/src/test/java/org/apache/accumulo/test/functional/MetadataIT.java 00fbf7ecdcbe8858eb9e948b606a73397c055702 
>   test/src/test/java/org/apache/accumulo/test/functional/ReadWriteIT.java e845d9975c91aefbcbe40af49376d0e7b98f8d0b 
>   test/src/test/java/org/apache/accumulo/test/functional/ServerSideErrorIT.java e68514dac5493a94cf46d77e8050e03033d7a91f 
>   test/src/test/java/org/apache/accumulo/test/functional/TimeoutIT.java d949a5da004058975ad7c3fbd7578182ec251e1f 
>   test/src/test/java/org/apache/accumulo/test/functional/VisibilityIT.java 55fd7674b2007cb1ec896c9882eb29ed7d9d0ccd 
>   test/src/test/java/org/apache/accumulo/test/iterator/RegExTest.java 3583894b37d6a66f5e3dcf8250da2aa22d6ccff1 
> 
> Diff: https://reviews.apache.org/r/20024/diff/
> 
> 
> Testing
> -------
> 
> Unit tests ran.
> 
> 
> Thanks,
> 
> Mike Drob
> 
>