You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Swapnil Ghike (JIRA)" <ji...@apache.org> on 2012/08/18 02:45:38 UTC
[jira] [Created] (KAFKA-469) Message size is not checked at the
server
Swapnil Ghike created KAFKA-469:
-----------------------------------
Summary: Message size is not checked at the server
Key: KAFKA-469
URL: https://issues.apache.org/jira/browse/KAFKA-469
Project: Kafka
Issue Type: Bug
Affects Versions: 0.7.1
Reporter: Swapnil Ghike
Assignee: Swapnil Ghike
Fix For: 0.7.1
Message size is checked currently only in SyncProducer and not at the server. Therefore, non-java clients can push bigger messages to the server. Need a message size check at the server as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-469) Message size is not checked at the
server
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444114#comment-13444114 ]
Jun Rao commented on KAFKA-469:
-------------------------------
Thanks for patch v3. We need to log the topic/partition in handleProducerRequest() when we hit a MessageSizeTooLargeException. Committed to trunk with the fix.
> Message size is not checked at the server
> -----------------------------------------
>
> Key: KAFKA-469
> URL: https://issues.apache.org/jira/browse/KAFKA-469
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: bug
> Fix For: 0.7.2
>
> Attachments: kafka-469-v1.patch, kafka-469-v2.patch, kafka-469-v3.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Message size is checked currently only in SyncProducer and not at the server. Therefore, non-java clients can push bigger messages to the server. Need a message size check at the server as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-469) Message size is not checked at the
server
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-469:
--------------------------------
Attachment: kafka-469-v3.patch
Reopening this issue to remove the stack trace logged in case of receiving a message larger than the permissible limit set by the server config.
> Message size is not checked at the server
> -----------------------------------------
>
> Key: KAFKA-469
> URL: https://issues.apache.org/jira/browse/KAFKA-469
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: bug
> Fix For: 0.7.2
>
> Attachments: kafka-469-v1.patch, kafka-469-v2.patch, kafka-469-v3.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Message size is checked currently only in SyncProducer and not at the server. Therefore, non-java clients can push bigger messages to the server. Need a message size check at the server as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-469) Message size is not checked at the
server
Posted by "Neha Narkhede (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440856#comment-13440856 ]
Neha Narkhede commented on KAFKA-469:
-------------------------------------
+1 on v2. Thanks for the patch !
> Message size is not checked at the server
> -----------------------------------------
>
> Key: KAFKA-469
> URL: https://issues.apache.org/jira/browse/KAFKA-469
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: bug
> Fix For: 0.7.2
>
> Attachments: kafka-469-v1.patch, kafka-469-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Message size is checked currently only in SyncProducer and not at the server. Therefore, non-java clients can push bigger messages to the server. Need a message size check at the server as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-469) Message size is not checked at the
server
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440358#comment-13440358 ]
Jun Rao commented on KAFKA-469:
-------------------------------
Thanks for the patch. Looks good overall. One minor comment:
Instead of passing in maxMessageSize in each log.append, is it better to pass it in the constructor of Log?
> Message size is not checked at the server
> -----------------------------------------
>
> Key: KAFKA-469
> URL: https://issues.apache.org/jira/browse/KAFKA-469
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: bug
> Fix For: 0.7.2
>
> Attachments: kafka-469-v1.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Message size is checked currently only in SyncProducer and not at the server. Therefore, non-java clients can push bigger messages to the server. Need a message size check at the server as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-469) Message size is not checked at the
server
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-469:
--------------------------------
Attachment: kafka-469-v1.patch
Implemented message size check in Log.append(). The default maxMessageSize in server config is set to the same value as maxMessageSize in producer config.
Will need to rebase after kafka-475 patch is checked in.
> Message size is not checked at the server
> -----------------------------------------
>
> Key: KAFKA-469
> URL: https://issues.apache.org/jira/browse/KAFKA-469
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: bug
> Fix For: 0.7.2
>
> Attachments: kafka-469-v1.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Message size is checked currently only in SyncProducer and not at the server. Therefore, non-java clients can push bigger messages to the server. Need a message size check at the server as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KAFKA-469) Message size is not checked at
the server
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KAFKA-469 started by Swapnil Ghike.
> Message size is not checked at the server
> -----------------------------------------
>
> Key: KAFKA-469
> URL: https://issues.apache.org/jira/browse/KAFKA-469
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: bug
> Fix For: 0.7.1
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Message size is checked currently only in SyncProducer and not at the server. Therefore, non-java clients can push bigger messages to the server. Need a message size check at the server as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-469) Message size is not checked at the
server
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-469:
--------------------------------
Attachment: kafka-469-v2.patch
Yes. Attached the change.
> Message size is not checked at the server
> -----------------------------------------
>
> Key: KAFKA-469
> URL: https://issues.apache.org/jira/browse/KAFKA-469
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: bug
> Fix For: 0.7.2
>
> Attachments: kafka-469-v1.patch, kafka-469-v2.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Message size is checked currently only in SyncProducer and not at the server. Therefore, non-java clients can push bigger messages to the server. Need a message size check at the server as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-469) Message size is not checked at the
server
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao updated KAFKA-469:
--------------------------
Fix Version/s: (was: 0.7.1)
0.7.2
> Message size is not checked at the server
> -----------------------------------------
>
> Key: KAFKA-469
> URL: https://issues.apache.org/jira/browse/KAFKA-469
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: bug
> Fix For: 0.7.2
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Message size is checked currently only in SyncProducer and not at the server. Therefore, non-java clients can push bigger messages to the server. Need a message size check at the server as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-469) Message size is not checked at the
server
Posted by "Swapnil Ghike (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Swapnil Ghike updated KAFKA-469:
--------------------------------
Status: Patch Available (was: In Progress)
> Message size is not checked at the server
> -----------------------------------------
>
> Key: KAFKA-469
> URL: https://issues.apache.org/jira/browse/KAFKA-469
> Project: Kafka
> Issue Type: Bug
> Affects Versions: 0.7.1
> Reporter: Swapnil Ghike
> Assignee: Swapnil Ghike
> Labels: bug
> Fix For: 0.7.2
>
> Attachments: kafka-469-v1.patch
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Message size is checked currently only in SyncProducer and not at the server. Therefore, non-java clients can push bigger messages to the server. Need a message size check at the server as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira