[GitHub] [incubator-echarts] pissang commented on a change in pull request #11617: Add new methods for List and fix #11616

[GitBox <gi...@apache.org>]

pissang commented on a change in pull request #11617: Add new methods for List and fix #11616
URL: https://github.com/apache/incubator-echarts/pull/11617#discussion_r344560765
 
 

 ##########
 File path: src/data/List.js
 ##########
 @@ -467,6 +467,21 @@ listProto.getProvider = function () {
     return this._rawData;
 };
 
+// Get store data
+listProto.getStorage = function () {
 
 Review comment:
   I don't see `getStorage` is used. And I think it's a good idea to expose `storage` to other modules. All data management should be in the `List` module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org