You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/09/08 11:08:16 UTC
[GitHub] [pulsar] zymap opened a new pull request #8006: The token endpoint should get from the well-known configuration
zymap opened a new pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006
Fixes #7952
*Motivation*
Currently, the token endpoint is created by append '/oauth/token' directly,
we should fetch the token endpoint from the well-known configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8006: The token endpoint should get from the well-known configuration
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #8006: The token endpoint should get from the well-known configuration
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006#discussion_r485540308
##########
File path: pulsar-client-cpp/lib/auth/AuthOauth2.cc
##########
@@ -300,7 +364,7 @@ AuthenticationPtr AuthOauth2::create(const std::string& authParamsString) {
AuthenticationPtr AuthOauth2::create(ParamMap& params) { return AuthenticationPtr(new AuthOauth2(params)); }
-const std::string AuthOauth2::getAuthMethodName() const { return "token"; }
+const std::string AuthOauth2::getAuthMethodName() const { return "oauth2"; }
Review comment:
@zymap Could we keep it as token? client get token finally from oauth2 server, and broker side could use token to talk with client
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8006: The token endpoint should get from the well-known configuration
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006#issuecomment-690818471
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on a change in pull request #8006: The token endpoint should get from the well-known configuration
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006#discussion_r485644537
##########
File path: pulsar-client-cpp/lib/auth/AuthOauth2.cc
##########
@@ -300,7 +364,7 @@ AuthenticationPtr AuthOauth2::create(const std::string& authParamsString) {
AuthenticationPtr AuthOauth2::create(ParamMap& params) { return AuthenticationPtr(new AuthOauth2(params)); }
-const std::string AuthOauth2::getAuthMethodName() const { return "token"; }
+const std::string AuthOauth2::getAuthMethodName() const { return "oauth2"; }
Review comment:
Sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8006: The token endpoint should get from the well-known configuration
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8006: The token endpoint should get from the well-known configuration
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006#issuecomment-690861185
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8006: The token endpoint should get from the well-known configuration
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006#issuecomment-690798334
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #8006: The token endpoint should get from the well-known configuration
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8006: The token endpoint should get from the well-known configuration
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006#issuecomment-690861185
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8006: The token endpoint should get from the well-known configuration
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8006:
URL: https://github.com/apache/pulsar/pull/8006#issuecomment-690818471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org