You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/13 22:27:42 UTC
[GitHub] [tvm] areusch opened a new pull request #8038: Always docker/build.sh with --no-cache.
areusch opened a new pull request #8038:
URL: https://github.com/apache/tvm/pull/8038
* Almost every docker container starts with apt-get install foo bar
* This is inherently not cacheable, meanwhile the lack of --no-cache
has bitten nearly everyone I've talked to who's tried to rebuild.
* Adding now to address this repeated problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on a change in pull request #8038: Always docker/build.sh with --no-cache.
Posted by GitBox <gi...@apache.org>.
areusch commented on a change in pull request #8038:
URL: https://github.com/apache/tvm/pull/8038#discussion_r633826371
##########
File path: docker/install/ubuntu_install_zephyr.sh
##########
@@ -41,26 +41,19 @@ sudo apt-get update
sudo apt-get install -y cmake
-#mkdir /opt/west
-#python3.6 -mvenv /opt/west # NOTE: include .6 to make a python3.6 link for west/cmake.
-#/opt/west/bin/pip3 install west
pip3 install west
-#cat <<EOF | tee /usr/local/bin/west >/dev/null
-##!/bin/bash -e
-#
-#source /opt/west/bin/activate
-#export ZEPHYR_BASE=/opt/zephyrproject/zephyr
-#west "\$@"
-#EOF
-#chmod a+x /usr/local/bin/west
-
# Init ZephyrProject
ZEPHYR_PROJECT_PATH=/opt/zephyrproject
ZEPHYR_INIT_SCRIPT=$(find -name "ubuntu_init_zephyr_project.sh")
bash ${ZEPHYR_INIT_SCRIPT} ${ZEPHYR_PROJECT_PATH} v2.5-branch
cd ${ZEPHYR_PROJECT_PATH}
+# As part of the build process, Zephyr needs to touch some symlinks in zephyr/misc/generated/syscalls_links (this path is relative to the
+# build directory for a project). Mark the zephyr installation world-writable since this is a docker
+# container
+chmod -R o+w ${ZEPHYR_PROJECT_PATH}
Review comment:
ooops, looks like i forgot to checkout. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on a change in pull request #8038: Always docker/build.sh with --no-cache.
Posted by GitBox <gi...@apache.org>.
leandron commented on a change in pull request #8038:
URL: https://github.com/apache/tvm/pull/8038#discussion_r632927565
##########
File path: docker/install/ubuntu_install_zephyr.sh
##########
@@ -41,26 +41,19 @@ sudo apt-get update
sudo apt-get install -y cmake
-#mkdir /opt/west
-#python3.6 -mvenv /opt/west # NOTE: include .6 to make a python3.6 link for west/cmake.
-#/opt/west/bin/pip3 install west
pip3 install west
-#cat <<EOF | tee /usr/local/bin/west >/dev/null
-##!/bin/bash -e
-#
-#source /opt/west/bin/activate
-#export ZEPHYR_BASE=/opt/zephyrproject/zephyr
-#west "\$@"
-#EOF
-#chmod a+x /usr/local/bin/west
-
# Init ZephyrProject
ZEPHYR_PROJECT_PATH=/opt/zephyrproject
ZEPHYR_INIT_SCRIPT=$(find -name "ubuntu_init_zephyr_project.sh")
bash ${ZEPHYR_INIT_SCRIPT} ${ZEPHYR_PROJECT_PATH} v2.5-branch
cd ${ZEPHYR_PROJECT_PATH}
+# As part of the build process, Zephyr needs to touch some symlinks in zephyr/misc/generated/syscalls_links (this path is relative to the
+# build directory for a project). Mark the zephyr installation world-writable since this is a docker
+# container
+chmod -R o+w ${ZEPHYR_PROJECT_PATH}
Review comment:
Is this the same from #8037 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #8038: Always docker/build.sh with --no-cache.
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #8038:
URL: https://github.com/apache/tvm/pull/8038#issuecomment-840871288
@jroesch @tqchen @tkonolige @leandron @mehrdadh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8038: Always docker/build.sh with --no-cache.
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8038:
URL: https://github.com/apache/tvm/pull/8038#issuecomment-842625401
@areusch feel free to merge it - I just didn't merge because CI was still pending, but the contents of this specific PR are not really tested in CI here, so feel free to merge when you're happy to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron commented on pull request #8038: Always docker/build.sh with --no-cache.
Posted by GitBox <gi...@apache.org>.
leandron commented on pull request #8038:
URL: https://github.com/apache/tvm/pull/8038#issuecomment-842962526
Thanks @areusch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] leandron merged pull request #8038: Always docker/build.sh with --no-cache.
Posted by GitBox <gi...@apache.org>.
leandron merged pull request #8038:
URL: https://github.com/apache/tvm/pull/8038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org