[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2603: [build] make sure flatten-maven-plugin runs after maven-shade-plugin

[GitBox <gi...@apache.org>]

ashulin commented on code in PR #2603:
URL: https://github.com/apache/incubator-seatunnel/pull/2603#discussion_r962088913


##########
tools/dependencies/checkLicense.sh:
##########
@@ -42,4 +40,4 @@ echo '=== Third party dependencies: ' && grep -vf self-modules.txt all-dependenc
 # command in target OS is different from what we used to sort the file `known-dependencies.txt`, i.e. "sort the two file
 # using the same command (and default arguments)"
 
-diff -w -B -U0 <(sort < tools/dependencies/known-dependencies.txt) <(sort < third-party-dependencies.txt)
+echo '=== diff dependencies: ' && diff -w -B -U0 <(sort < tools/dependencies/known-dependencies.txt) <(sort < third-party-dependencies.txt)

Review Comment:
   @CalvinKirs PTAL.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org