You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by Savalek <gi...@git.apache.org> on 2018/05/31 14:02:58 UTC

[GitHub] zeppelin pull request #2995: [ZEPPELIN-3510] Angular ui-grid fix

GitHub user Savalek opened a pull request:

    https://github.com/apache/zeppelin/pull/2995

    [ZEPPELIN-3510] Angular ui-grid fix

    ### What is this PR for?
    This PR change display of spaces in ui-grid (Now the number of displayed spaces is correct).
    And now then you edit the cell its displayed corectly.
    
    ### What type of PR is it?
    Bug Fix 
    
    ### What is the Jira issue?
    [ZEPPELIN-3510](https://issues.apache.org/jira/browse/ZEPPELIN-3510)
    
    ### <p align="center">Spaces</p>
    Before :(
    ![space_before](https://user-images.githubusercontent.com/30798933/40786200-30bbd5f6-64f3-11e8-93cc-cf6eb1a46dd2.gif)
    
    After :)
    ![space_after](https://user-images.githubusercontent.com/30798933/40786217-36eead86-64f3-11e8-982b-73c0fbc93fa9.gif)
    
    ### <p align="center">Edit cell</p>
    Before :(
    ![edit_cell_before](https://user-images.githubusercontent.com/30798933/40786249-47cb0eec-64f3-11e8-9005-ccc0a6fd323d.gif)
    
    After :)
    ![edit_cell_after](https://user-images.githubusercontent.com/30798933/40786259-4e0ce032-64f3-11e8-97b9-d775b0a6f7dc.gif)
    
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no 


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3510

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2995.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2995
    
----
commit c2c1336a94bf777b96884b1b5ff5702bc25230e8
Author: Savalek <de...@...>
Date:   2018-05-31T12:13:55Z

    [ZEPPELIN-3510] ui-grid fix

----


---

[GitHub] zeppelin issue #2995: [ZEPPELIN-3510] Angular ui-grid fix

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2995
  
    Will merge it


---

[GitHub] zeppelin issue #2995: [ZEPPELIN-3510] Angular ui-grid fix

Posted by Savalek <gi...@git.apache.org>.

Github user Savalek commented on the issue:

    https://github.com/apache/zeppelin/pull/2995
  
    @felixcheung, thanks. I fixed it.


---

[GitHub] zeppelin pull request #2995: [ZEPPELIN-3510] Angular ui-grid fix

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2995


---

[GitHub] zeppelin issue #2995: [ZEPPELIN-3510] Angular ui-grid fix

Posted by jongyoul <gi...@git.apache.org>.

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2995
  
    LGTM


---