You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Andreas Kuhtz (JIRA)" <ji...@apache.org> on 2008/06/12 13:18:00 UTC

[jira] Created: (AMQ-1794) Fix activemq.xsd to allow configuration of more than one element in the broker

Fix activemq.xsd to allow configuration of more than one element in the broker
------------------------------------------------------------------------------

                 Key: AMQ-1794
                 URL: https://issues.apache.org/activemq/browse/AMQ-1794
             Project: ActiveMQ
          Issue Type: Bug
          Components: Broker
    Affects Versions: 5.1.0
         Environment: JDK6, Spring, WinXP
            Reporter: Andreas Kuhtz
             Fix For: 5.2.0
         Attachments: amq-1794.patch

The current activemq.xsd does not allow to configure more than one subelement, e.g. the transportConnnectors and the persistenceAdapter. Therefore the following correct configuration is currently not validated.


{code:xml} 
<amq:broker brokerName="myBroker" persistent="true"
   useShutdownHook="false" deleteAllMessagesOnStartup="true" useJmx="true" 
   populateJMSXUserID="true" >

   <amq:transportConnectors>
      <amq:transportConnector uri="${brokerUri}" />
   </amq:transportConnectors>

   <amq:persistenceAdapter>
      <amq:kahaPersistenceAdapter directory="activemq-data" maxDataFileLength="33554432"/>
   </amq:persistenceAdapter>

   <amq:plugins>
      <!-- lets enable detailed logging in the broker -->
      <amq:loggingBrokerPlugin/>
   </amq:plugins>

</amq:broker>
{code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-1794) Fix activemq.xsd to allow configuration of more than one element in the broker

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated AMQ-1794:
----------------------------

    Fix Version/s: 5.3.0
                       (was: 5.2.0)

> Fix activemq.xsd to allow configuration of more than one element in the broker
> ------------------------------------------------------------------------------
>
>                 Key: AMQ-1794
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1794
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.1.0
>         Environment: JDK6, Spring, WinXP
>            Reporter: Andreas Kuhtz
>             Fix For: 5.3.0
>
>         Attachments: amq-1794.patch
>
>
> The current activemq.xsd does not allow to configure more than one subelement, e.g. the transportConnnectors and the persistenceAdapter. Therefore the following correct configuration is currently not validated.
> {code:xml} 
> <amq:broker brokerName="myBroker" persistent="true"
>    useShutdownHook="false" deleteAllMessagesOnStartup="true" useJmx="true" 
>    populateJMSXUserID="true" >
>    <amq:transportConnectors>
>       <amq:transportConnector uri="${brokerUri}" />
>    </amq:transportConnectors>
>    <amq:persistenceAdapter>
>       <amq:kahaPersistenceAdapter directory="activemq-data" maxDataFileLength="33554432"/>
>    </amq:persistenceAdapter>
>    <amq:plugins>
>       <!-- lets enable detailed logging in the broker -->
>       <amq:loggingBrokerPlugin/>
>    </amq:plugins>
> </amq:broker>
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-1794) Fix activemq.xsd to allow configuration of more than one element in the broker

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully resolved AMQ-1794.
-----------------------------

      Assignee: Gary Tully
    Resolution: Working as Designed

[order is important to a sequence|http://www.w3.org/TR/2004/REC-xmlschema-1-20041028/structures.html#element-sequence], leave the transportConnectors last and it will work.

{code}
<amq:broker brokerName="myBroker" persistent="true"
   useShutdownHook="false" deleteAllMessagesOnStartup="true" useJmx="true" 
   populateJMSXUserID="true" >

   <amq:persistenceAdapter>
      <amq:kahaPersistenceAdapter directory="activemq-data" maxDataFileLength="33554432"/>
   </amq:persistenceAdapter>

   <amq:plugins>
      <!-- lets enable detailed logging in the broker -->
      <amq:loggingBrokerPlugin/>
   </amq:plugins>

   <amq:transportConnectors>
      <amq:transportConnector uri="${brokerUri}" />
   </amq:transportConnectors>
</amq:broker>
{code}

btw: I don't understand why your patch (adding unbounded to the sequence) allows the order to be insignificant and the out of order elements to be parsed. Any idea?


> Fix activemq.xsd to allow configuration of more than one element in the broker
> ------------------------------------------------------------------------------
>
>                 Key: AMQ-1794
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1794
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.1.0
>         Environment: JDK6, Spring, WinXP
>            Reporter: Andreas Kuhtz
>            Assignee: Gary Tully
>             Fix For: 5.3.0
>
>         Attachments: amq-1794.patch
>
>
> The current activemq.xsd does not allow to configure more than one subelement, e.g. the transportConnnectors and the persistenceAdapter. Therefore the following correct configuration is currently not validated.
> {code:xml} 
> <amq:broker brokerName="myBroker" persistent="true"
>    useShutdownHook="false" deleteAllMessagesOnStartup="true" useJmx="true" 
>    populateJMSXUserID="true" >
>    <amq:transportConnectors>
>       <amq:transportConnector uri="${brokerUri}" />
>    </amq:transportConnectors>
>    <amq:persistenceAdapter>
>       <amq:kahaPersistenceAdapter directory="activemq-data" maxDataFileLength="33554432"/>
>    </amq:persistenceAdapter>
>    <amq:plugins>
>       <!-- lets enable detailed logging in the broker -->
>       <amq:loggingBrokerPlugin/>
>    </amq:plugins>
> </amq:broker>
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-1794) Fix activemq.xsd to allow configuration of more than one element in the broker

Posted by "Kenny MacLeod (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43955#action_43955 ] 

Kenny MacLeod commented on AMQ-1794:
------------------------------------

For crying out loud... how does this stuff even get through testing?  This release is even more unusable than 4.1 was.

> Fix activemq.xsd to allow configuration of more than one element in the broker
> ------------------------------------------------------------------------------
>
>                 Key: AMQ-1794
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1794
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.1.0
>         Environment: JDK6, Spring, WinXP
>            Reporter: Andreas Kuhtz
>             Fix For: 5.2.0
>
>         Attachments: amq-1794.patch
>
>
> The current activemq.xsd does not allow to configure more than one subelement, e.g. the transportConnnectors and the persistenceAdapter. Therefore the following correct configuration is currently not validated.
> {code:xml} 
> <amq:broker brokerName="myBroker" persistent="true"
>    useShutdownHook="false" deleteAllMessagesOnStartup="true" useJmx="true" 
>    populateJMSXUserID="true" >
>    <amq:transportConnectors>
>       <amq:transportConnector uri="${brokerUri}" />
>    </amq:transportConnectors>
>    <amq:persistenceAdapter>
>       <amq:kahaPersistenceAdapter directory="activemq-data" maxDataFileLength="33554432"/>
>    </amq:persistenceAdapter>
>    <amq:plugins>
>       <!-- lets enable detailed logging in the broker -->
>       <amq:loggingBrokerPlugin/>
>    </amq:plugins>
> </amq:broker>
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-1794) Fix activemq.xsd to allow configuration of more than one element in the broker

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Tully updated AMQ-1794:
----------------------------

    Fix Version/s:     (was: 5.3.0)

> Fix activemq.xsd to allow configuration of more than one element in the broker
> ------------------------------------------------------------------------------
>
>                 Key: AMQ-1794
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1794
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.1.0
>         Environment: JDK6, Spring, WinXP
>            Reporter: Andreas Kuhtz
>            Assignee: Gary Tully
>         Attachments: amq-1794.patch
>
>
> The current activemq.xsd does not allow to configure more than one subelement, e.g. the transportConnnectors and the persistenceAdapter. Therefore the following correct configuration is currently not validated.
> {code:xml} 
> <amq:broker brokerName="myBroker" persistent="true"
>    useShutdownHook="false" deleteAllMessagesOnStartup="true" useJmx="true" 
>    populateJMSXUserID="true" >
>    <amq:transportConnectors>
>       <amq:transportConnector uri="${brokerUri}" />
>    </amq:transportConnectors>
>    <amq:persistenceAdapter>
>       <amq:kahaPersistenceAdapter directory="activemq-data" maxDataFileLength="33554432"/>
>    </amq:persistenceAdapter>
>    <amq:plugins>
>       <!-- lets enable detailed logging in the broker -->
>       <amq:loggingBrokerPlugin/>
>    </amq:plugins>
> </amq:broker>
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-1794) Fix activemq.xsd to allow configuration of more than one element in the broker

Posted by "Andreas Kuhtz (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45598#action_45598 ] 

Andreas Kuhtz commented on AMQ-1794:
------------------------------------

Hi Gary,

You're right. I moved transportConnectors to the end and it works as designed!

btw: I don't know, I checked with XML Spy and adding unbounded validated it .... so I thought this was the solution.

> Fix activemq.xsd to allow configuration of more than one element in the broker
> ------------------------------------------------------------------------------
>
>                 Key: AMQ-1794
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1794
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.1.0
>         Environment: JDK6, Spring, WinXP
>            Reporter: Andreas Kuhtz
>            Assignee: Gary Tully
>         Attachments: amq-1794.patch
>
>
> The current activemq.xsd does not allow to configure more than one subelement, e.g. the transportConnnectors and the persistenceAdapter. Therefore the following correct configuration is currently not validated.
> {code:xml} 
> <amq:broker brokerName="myBroker" persistent="true"
>    useShutdownHook="false" deleteAllMessagesOnStartup="true" useJmx="true" 
>    populateJMSXUserID="true" >
>    <amq:transportConnectors>
>       <amq:transportConnector uri="${brokerUri}" />
>    </amq:transportConnectors>
>    <amq:persistenceAdapter>
>       <amq:kahaPersistenceAdapter directory="activemq-data" maxDataFileLength="33554432"/>
>    </amq:persistenceAdapter>
>    <amq:plugins>
>       <!-- lets enable detailed logging in the broker -->
>       <amq:loggingBrokerPlugin/>
>    </amq:plugins>
> </amq:broker>
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-1794) Fix activemq.xsd to allow configuration of more than one element in the broker

Posted by "Andreas Kuhtz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Kuhtz updated AMQ-1794:
-------------------------------

    Attachment: amq-1794.patch

> Fix activemq.xsd to allow configuration of more than one element in the broker
> ------------------------------------------------------------------------------
>
>                 Key: AMQ-1794
>                 URL: https://issues.apache.org/activemq/browse/AMQ-1794
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 5.1.0
>         Environment: JDK6, Spring, WinXP
>            Reporter: Andreas Kuhtz
>             Fix For: 5.2.0
>
>         Attachments: amq-1794.patch
>
>
> The current activemq.xsd does not allow to configure more than one subelement, e.g. the transportConnnectors and the persistenceAdapter. Therefore the following correct configuration is currently not validated.
> {code:xml} 
> <amq:broker brokerName="myBroker" persistent="true"
>    useShutdownHook="false" deleteAllMessagesOnStartup="true" useJmx="true" 
>    populateJMSXUserID="true" >
>    <amq:transportConnectors>
>       <amq:transportConnector uri="${brokerUri}" />
>    </amq:transportConnectors>
>    <amq:persistenceAdapter>
>       <amq:kahaPersistenceAdapter directory="activemq-data" maxDataFileLength="33554432"/>
>    </amq:persistenceAdapter>
>    <amq:plugins>
>       <!-- lets enable detailed logging in the broker -->
>       <amq:loggingBrokerPlugin/>
>    </amq:plugins>
> </amq:broker>
> {code} 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.