[GitHub] [skywalking] hanahmily commented on a diff in pull request #10448: Integrate BanyanDB server-side TopN

["hanahmily (via GitHub)" <gi...@apache.org>]

hanahmily commented on code in PR #10448:
URL: https://github.com/apache/skywalking/pull/10448#discussion_r1118174845


##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/BanyanDBModelExtension.java:
##########
@@ -45,4 +46,23 @@ public class BanyanDBModelExtension {
     @Setter
     private boolean storeIDTag;
 
+    /**
+     * lru_size defines how many snapshots are allowed to be maintained in the memory.
+     * The default value is 2 in the BanyanDB if not set.
+     *
+     * @since 9.4.0
+     */
+    @Getter
+    @Setter
+    private int lruSize = 2;

Review Comment:
   https://github.com/apache/skywalking-banyandb/blob/ad6a81c726640c8ffb8805adac4f43ffa5b2c423/api/proto/banyandb/database/v1/schema.proto#L138.
   
   It determines how many time_buckets are held. `2` means a data point belonging to the latest 2 time_buckets will be analyzed. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org