You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by jcesarmobile <gi...@git.apache.org> on 2017/10/14 15:36:34 UTC
[GitHub] cordova-plugin-media-capture pull request #83: CB-13266 (ios): Remove ios us...
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/83
CB-13266 (ios): Remove ios usage descriptions
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Removes the usage description variables and document how to set them using edit-config tab
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-media-capture CB-13266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 0a13fc9add11df1a7fd6f92c50d231eec3a67561
Author: Julio César <jc...@gmail.com>
Date: 2017-10-14T15:33:52Z
CB-13266 (ios): Remove ios usage descriptions
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request #83: CB-13266 (ios): Remove ios us...
Posted by jcesarmobile <gi...@git.apache.org>.
GitHub user jcesarmobile reopened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/83
CB-13266 (ios): Remove ios usage descriptions
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Removes the usage description variables and document how to set them using edit-config tab
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-media-capture CB-13266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 0b83fa704a7d450f4f90bce7b31661c90af893c7
Author: Julio César <jc...@gmail.com>
Date: 2017-10-14T15:33:52Z
CB-13266 (ios): Remove ios usage descriptions
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request #83: CB-13266 (ios): Remove ios us...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/83
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request #83: CB-13266 (ios): Remove ios us...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/83
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request #83: CB-13266 (ios): Remove ios us...
Posted by janpio <gi...@git.apache.org>.
Github user janpio commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/83#discussion_r145941712
--- Diff: README.md ---
@@ -200,26 +200,33 @@ object featuring a `CaptureError.CAPTURE_NO_MEDIA_FILES` error code.
### iOS Quirks
-Since iOS 10 it's mandatory to add a `NSCameraUsageDescription`, `NSMicrophoneUsageDescription` and `NSPhotoLibraryUsageDescriptionentry` in the info.plist.
+Since iOS 10 it's mandatory to add a `NSCameraUsageDescription`, `NSMicrophoneUsageDescription` and `NSPhotoLibraryUsageDescriptionentry` in the info.plist. If you don't add them, the app will crash when it tries to get the permission to use them. Also, Apple will reject apps that use this features and don't provide the usage descriptions.
-* `NSCameraUsageDescription` describes the reason that the app accesses the user’s camera.
-* `NSMicrophoneUsageDescription` describes the reason that the app accesses the user’s microphone.
+* `NSCameraUsageDescription` describes the reason that the app accesses the user's camera.
+* `NSMicrophoneUsageDescription` describes the reason that the app accesses the user's microphone.
* `NSPhotoLibraryUsageDescriptionentry` describes the reason the app accesses the user's photo library.
When the system prompts the user to allow access, this string is displayed as part of the dialog box.
-To add this entry you can pass the following variables on plugin install.
+To add this entries you can use `edit-config` tag in the config.xml like this:
--- End diff --
this => these
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request #83: CB-13266 (ios): Remove ios us...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/83
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request #83: CB-13266 (ios): Remove ios us...
Posted by jcesarmobile <gi...@git.apache.org>.
GitHub user jcesarmobile reopened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/83
CB-13266 (ios): Remove ios usage descriptions
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
iOS
### What does this PR do?
Removes the usage description variables and document how to set them using edit-config tab
### What testing has been done on this change?
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcesarmobile/cordova-plugin-media-capture CB-13266
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 0a13fc9add11df1a7fd6f92c50d231eec3a67561
Author: Julio César <jc...@gmail.com>
Date: 2017-10-14T15:33:52Z
CB-13266 (ios): Remove ios usage descriptions
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request #83: CB-13266 (ios): Remove ios us...
Posted by jcesarmobile <gi...@git.apache.org>.
Github user jcesarmobile commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/83#discussion_r145943140
--- Diff: README.md ---
@@ -200,26 +200,33 @@ object featuring a `CaptureError.CAPTURE_NO_MEDIA_FILES` error code.
### iOS Quirks
-Since iOS 10 it's mandatory to add a `NSCameraUsageDescription`, `NSMicrophoneUsageDescription` and `NSPhotoLibraryUsageDescriptionentry` in the info.plist.
+Since iOS 10 it's mandatory to add a `NSCameraUsageDescription`, `NSMicrophoneUsageDescription` and `NSPhotoLibraryUsageDescriptionentry` in the info.plist. If you don't add them, the app will crash when it tries to get the permission to use them. Also, Apple will reject apps that use this features and don't provide the usage descriptions.
-* `NSCameraUsageDescription` describes the reason that the app accesses the user’s camera.
-* `NSMicrophoneUsageDescription` describes the reason that the app accesses the user’s microphone.
+* `NSCameraUsageDescription` describes the reason that the app accesses the user's camera.
+* `NSMicrophoneUsageDescription` describes the reason that the app accesses the user's microphone.
* `NSPhotoLibraryUsageDescriptionentry` describes the reason the app accesses the user's photo library.
When the system prompts the user to allow access, this string is displayed as part of the dialog box.
-To add this entry you can pass the following variables on plugin install.
+To add this entries you can use `edit-config` tag in the config.xml like this:
--- End diff --
good catch, I copy/pasted from the media PR and missed some changes 🙈
---
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org