You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@concerted.apache.org by Atri Sharma <at...@gmail.com> on 2015/10/23 20:56:36 UTC
[MENTORS] Sending Patches
Hi Mentors,
I just wanted to check the best way of sending and committing patches.
One way is attach a patch to JIRA, committer applies it locally, reviews it
and then commits it.
One more way is to get pull request in github mirror.
I was thinking of second with patch to be attached as well to JIRA for
reference.
Please let me know your comments.
Regards,
Atri
--
Regards,
Atri
*l'apprenant*
Re: [MENTORS] Sending Patches
Posted by Jake Farrell <jf...@apache.org>.
The Thrift site pages are generated from markdown
https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=CONTRIBUTING.md
On Fri, Oct 23, 2015 at 3:23 PM, Atri Sharma <at...@gmail.com> wrote:
> Thanks Jake.
>
> I did not request github integrations, would they be present by
> default,please?
>
> We will follow the exact same processes as for Thrift.
>
> Gaurav, could you please add these pages in the website (please change the
> content to Concerted).
>
> http://thrift.apache.org/docs/HowToContribute and for committers our how
> to
> commit http://thrift.apache.org/docs/committers/HowToCommit
>
> On Sat, Oct 24, 2015 at 12:48 AM, Jake Farrell <jf...@apache.org>
> wrote:
>
> > The requirement is that the commit message format is all in a common
> format
> > so it can be searchable, so would not restrict where the contributions
> come
> > in from github and jira are the two most common paired together, and the
> > ASF has a reviewboard instance available also. The github integrations
> will
> > automatically comment on jira issue if the github pr has the ticket id in
> > it.
> >
> > for Thrift we require that all patches have a ticket associated with
> them,
> > our how to contribute guide is available at
> > http://thrift.apache.org/docs/HowToContribute and for committers our how
> > to
> > commit http://thrift.apache.org/docs/committers/HowToCommit
> >
> > - patch attached to jira
> > - fork on github and pr (closed via commit message, would script applying
> > and commit for this)
> > - reviewboard (reviews.apache.org)
> >
> > -Jake
> >
> > On Fri, Oct 23, 2015 at 2:56 PM, Atri Sharma <at...@gmail.com>
> wrote:
> >
> > > Hi Mentors,
> > >
> > > I just wanted to check the best way of sending and committing patches.
> > >
> > > One way is attach a patch to JIRA, committer applies it locally,
> reviews
> > it
> > > and then commits it.
> > >
> > > One more way is to get pull request in github mirror.
> > >
> > > I was thinking of second with patch to be attached as well to JIRA for
> > > reference.
> > >
> > >
> > > Please let me know your comments.
> > >
> > > Regards,
> > >
> > > Atri
> > >
> > > --
> > > Regards,
> > >
> > > Atri
> > > *l'apprenant*
> > >
> >
>
>
>
> --
> Regards,
>
> Atri
> *l'apprenant*
>
Re: [MENTORS] Sending Patches
Posted by Atri Sharma <at...@gmail.com>.
Thanks Jake.
I did not request github integrations, would they be present by
default,please?
We will follow the exact same processes as for Thrift.
Gaurav, could you please add these pages in the website (please change the
content to Concerted).
http://thrift.apache.org/docs/HowToContribute and for committers our how to
commit http://thrift.apache.org/docs/committers/HowToCommit
On Sat, Oct 24, 2015 at 12:48 AM, Jake Farrell <jf...@apache.org> wrote:
> The requirement is that the commit message format is all in a common format
> so it can be searchable, so would not restrict where the contributions come
> in from github and jira are the two most common paired together, and the
> ASF has a reviewboard instance available also. The github integrations will
> automatically comment on jira issue if the github pr has the ticket id in
> it.
>
> for Thrift we require that all patches have a ticket associated with them,
> our how to contribute guide is available at
> http://thrift.apache.org/docs/HowToContribute and for committers our how
> to
> commit http://thrift.apache.org/docs/committers/HowToCommit
>
> - patch attached to jira
> - fork on github and pr (closed via commit message, would script applying
> and commit for this)
> - reviewboard (reviews.apache.org)
>
> -Jake
>
> On Fri, Oct 23, 2015 at 2:56 PM, Atri Sharma <at...@gmail.com> wrote:
>
> > Hi Mentors,
> >
> > I just wanted to check the best way of sending and committing patches.
> >
> > One way is attach a patch to JIRA, committer applies it locally, reviews
> it
> > and then commits it.
> >
> > One more way is to get pull request in github mirror.
> >
> > I was thinking of second with patch to be attached as well to JIRA for
> > reference.
> >
> >
> > Please let me know your comments.
> >
> > Regards,
> >
> > Atri
> >
> > --
> > Regards,
> >
> > Atri
> > *l'apprenant*
> >
>
--
Regards,
Atri
*l'apprenant*
Re: [MENTORS] Sending Patches
Posted by Gaurav Shukla <gs...@gmail.com>.
@Atri,
Will add the pages under [get involved] link.
On Sat, Oct 24, 2015 at 1:04 AM, Atri Sharma <at...@gmail.com> wrote:
> Thanks Julian.
>
> That sounds quite a lot like what I had in mind.
>
> I will propose this to community on a different thread and see the
> response.
>
> On Sat, Oct 24, 2015 at 1:01 AM, Julian Hyde <jh...@apache.org> wrote:
>
> > How you receive contributions (and also whether you do
> > review-then-commit or commit-then-review) is for the Concerted
> > community to decide.
> >
> > For what it's worth, this is what we do in Calcite.
> >
> > We allow (1) JIRA case plus a github PR, or (2) JIRA case + attached
> > patch. Commit messages must start with the JIRA case number. We prefer
> > (1). We have not implemented review board, and have not made a firm
> > policy about RTC vs CTR because our ad hoc policy has not been
> > contentious.
> >
> > But the Concerted community might choose an entirely different
> > process. We as mentors can advise whether the process you choose meets
> > Apache's needs for IP due diligence etc.
> >
> > Julian
> >
> >
> >
> > On Fri, Oct 23, 2015 at 12:18 PM, Jake Farrell <jf...@apache.org>
> > wrote:
> > > The requirement is that the commit message format is all in a common
> > format
> > > so it can be searchable, so would not restrict where the contributions
> > come
> > > in from github and jira are the two most common paired together, and
> the
> > > ASF has a reviewboard instance available also. The github integrations
> > will
> > > automatically comment on jira issue if the github pr has the ticket id
> in
> > > it.
> > >
> > > for Thrift we require that all patches have a ticket associated with
> > them,
> > > our how to contribute guide is available at
> > > http://thrift.apache.org/docs/HowToContribute and for committers our
> > how to
> > > commit http://thrift.apache.org/docs/committers/HowToCommit
> > >
> > > - patch attached to jira
> > > - fork on github and pr (closed via commit message, would script
> applying
> > > and commit for this)
> > > - reviewboard (reviews.apache.org)
> > >
> > > -Jake
> > >
> > > On Fri, Oct 23, 2015 at 2:56 PM, Atri Sharma <at...@gmail.com>
> > wrote:
> > >
> > >> Hi Mentors,
> > >>
> > >> I just wanted to check the best way of sending and committing patches.
> > >>
> > >> One way is attach a patch to JIRA, committer applies it locally,
> > reviews it
> > >> and then commits it.
> > >>
> > >> One more way is to get pull request in github mirror.
> > >>
> > >> I was thinking of second with patch to be attached as well to JIRA for
> > >> reference.
> > >>
> > >>
> > >> Please let me know your comments.
> > >>
> > >> Regards,
> > >>
> > >> Atri
> > >>
> > >> --
> > >> Regards,
> > >>
> > >> Atri
> > >> *l'apprenant*
> > >>
> >
>
>
>
> --
> Regards,
>
> Atri
> *l'apprenant*
>
--
Regards !
Gaurav Shukla
gauravshukla.xyz
Phone: +91-837-584-7862
Re: [MENTORS] Sending Patches
Posted by Atri Sharma <at...@gmail.com>.
Thanks Julian.
That sounds quite a lot like what I had in mind.
I will propose this to community on a different thread and see the response.
On Sat, Oct 24, 2015 at 1:01 AM, Julian Hyde <jh...@apache.org> wrote:
> How you receive contributions (and also whether you do
> review-then-commit or commit-then-review) is for the Concerted
> community to decide.
>
> For what it's worth, this is what we do in Calcite.
>
> We allow (1) JIRA case plus a github PR, or (2) JIRA case + attached
> patch. Commit messages must start with the JIRA case number. We prefer
> (1). We have not implemented review board, and have not made a firm
> policy about RTC vs CTR because our ad hoc policy has not been
> contentious.
>
> But the Concerted community might choose an entirely different
> process. We as mentors can advise whether the process you choose meets
> Apache's needs for IP due diligence etc.
>
> Julian
>
>
>
> On Fri, Oct 23, 2015 at 12:18 PM, Jake Farrell <jf...@apache.org>
> wrote:
> > The requirement is that the commit message format is all in a common
> format
> > so it can be searchable, so would not restrict where the contributions
> come
> > in from github and jira are the two most common paired together, and the
> > ASF has a reviewboard instance available also. The github integrations
> will
> > automatically comment on jira issue if the github pr has the ticket id in
> > it.
> >
> > for Thrift we require that all patches have a ticket associated with
> them,
> > our how to contribute guide is available at
> > http://thrift.apache.org/docs/HowToContribute and for committers our
> how to
> > commit http://thrift.apache.org/docs/committers/HowToCommit
> >
> > - patch attached to jira
> > - fork on github and pr (closed via commit message, would script applying
> > and commit for this)
> > - reviewboard (reviews.apache.org)
> >
> > -Jake
> >
> > On Fri, Oct 23, 2015 at 2:56 PM, Atri Sharma <at...@gmail.com>
> wrote:
> >
> >> Hi Mentors,
> >>
> >> I just wanted to check the best way of sending and committing patches.
> >>
> >> One way is attach a patch to JIRA, committer applies it locally,
> reviews it
> >> and then commits it.
> >>
> >> One more way is to get pull request in github mirror.
> >>
> >> I was thinking of second with patch to be attached as well to JIRA for
> >> reference.
> >>
> >>
> >> Please let me know your comments.
> >>
> >> Regards,
> >>
> >> Atri
> >>
> >> --
> >> Regards,
> >>
> >> Atri
> >> *l'apprenant*
> >>
>
--
Regards,
Atri
*l'apprenant*
Re: [MENTORS] Sending Patches
Posted by Julian Hyde <jh...@apache.org>.
How you receive contributions (and also whether you do
review-then-commit or commit-then-review) is for the Concerted
community to decide.
For what it's worth, this is what we do in Calcite.
We allow (1) JIRA case plus a github PR, or (2) JIRA case + attached
patch. Commit messages must start with the JIRA case number. We prefer
(1). We have not implemented review board, and have not made a firm
policy about RTC vs CTR because our ad hoc policy has not been
contentious.
But the Concerted community might choose an entirely different
process. We as mentors can advise whether the process you choose meets
Apache's needs for IP due diligence etc.
Julian
On Fri, Oct 23, 2015 at 12:18 PM, Jake Farrell <jf...@apache.org> wrote:
> The requirement is that the commit message format is all in a common format
> so it can be searchable, so would not restrict where the contributions come
> in from github and jira are the two most common paired together, and the
> ASF has a reviewboard instance available also. The github integrations will
> automatically comment on jira issue if the github pr has the ticket id in
> it.
>
> for Thrift we require that all patches have a ticket associated with them,
> our how to contribute guide is available at
> http://thrift.apache.org/docs/HowToContribute and for committers our how to
> commit http://thrift.apache.org/docs/committers/HowToCommit
>
> - patch attached to jira
> - fork on github and pr (closed via commit message, would script applying
> and commit for this)
> - reviewboard (reviews.apache.org)
>
> -Jake
>
> On Fri, Oct 23, 2015 at 2:56 PM, Atri Sharma <at...@gmail.com> wrote:
>
>> Hi Mentors,
>>
>> I just wanted to check the best way of sending and committing patches.
>>
>> One way is attach a patch to JIRA, committer applies it locally, reviews it
>> and then commits it.
>>
>> One more way is to get pull request in github mirror.
>>
>> I was thinking of second with patch to be attached as well to JIRA for
>> reference.
>>
>>
>> Please let me know your comments.
>>
>> Regards,
>>
>> Atri
>>
>> --
>> Regards,
>>
>> Atri
>> *l'apprenant*
>>
Re: [MENTORS] Sending Patches
Posted by Jake Farrell <jf...@apache.org>.
The requirement is that the commit message format is all in a common format
so it can be searchable, so would not restrict where the contributions come
in from github and jira are the two most common paired together, and the
ASF has a reviewboard instance available also. The github integrations will
automatically comment on jira issue if the github pr has the ticket id in
it.
for Thrift we require that all patches have a ticket associated with them,
our how to contribute guide is available at
http://thrift.apache.org/docs/HowToContribute and for committers our how to
commit http://thrift.apache.org/docs/committers/HowToCommit
- patch attached to jira
- fork on github and pr (closed via commit message, would script applying
and commit for this)
- reviewboard (reviews.apache.org)
-Jake
On Fri, Oct 23, 2015 at 2:56 PM, Atri Sharma <at...@gmail.com> wrote:
> Hi Mentors,
>
> I just wanted to check the best way of sending and committing patches.
>
> One way is attach a patch to JIRA, committer applies it locally, reviews it
> and then commits it.
>
> One more way is to get pull request in github mirror.
>
> I was thinking of second with patch to be attached as well to JIRA for
> reference.
>
>
> Please let me know your comments.
>
> Regards,
>
> Atri
>
> --
> Regards,
>
> Atri
> *l'apprenant*
>