You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by se...@apache.org on 2013/10/18 20:15:45 UTC
svn commit: r1533576 - in /cxf/trunk:
rt/transports/http/src/main/java/org/apache/cxf/transport/http/
systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/
Author: sergeyb
Date: Fri Oct 18 18:15:45 2013
New Revision: 1533576
URL: http://svn.apache.org/r1533576
Log:
[CXF-5337] Relaxing HttpCondiit to allow DELETE with bodies
Modified:
cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java
cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/BookStore.java
cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/JAXRSAsyncClientTest.java
Modified: cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java
URL: http://svn.apache.org/viewvc/cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java?rev=1533576&r1=1533575&r2=1533576&view=diff
==============================================================================
--- cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java (original)
+++ cxf/trunk/rt/transports/http/src/main/java/org/apache/cxf/transport/http/HTTPConduit.java Fri Oct 18 18:15:45 2013
@@ -172,7 +172,7 @@ public abstract class HTTPConduit
private static final String HTTP_POST_METHOD = "POST";
private static final String HTTP_PUT_METHOD = "PUT";
private static final Set<String> KNOWN_HTTP_VERBS_WITH_NO_CONTENT =
- new HashSet<String>(Arrays.asList(new String[]{"GET", "DELETE", "HEAD", "OPTIONS", "TRACE"}));
+ new HashSet<String>(Arrays.asList(new String[]{"GET", "HEAD", "OPTIONS", "TRACE"}));
/**
* This constant is the Message(Map) key for a list of visited URLs that
* is used in redirect loop protection.
Modified: cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/BookStore.java
URL: http://svn.apache.org/viewvc/cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/BookStore.java?rev=1533576&r1=1533575&r2=1533576&view=diff
==============================================================================
--- cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/BookStore.java (original)
+++ cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/BookStore.java Fri Oct 18 18:15:45 2013
@@ -216,6 +216,14 @@ public class BookStore {
return book;
}
+ @DELETE
+ @Path("/deletebody")
+ @Produces("application/xml")
+ @Consumes("application/xml")
+ public Book deleteBodyBook(Book book) {
+ return book;
+ }
+
@POST
@Path("/emptyform")
@Produces("text/plain")
Modified: cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/JAXRSAsyncClientTest.java
URL: http://svn.apache.org/viewvc/cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/JAXRSAsyncClientTest.java?rev=1533576&r1=1533575&r2=1533576&view=diff
==============================================================================
--- cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/JAXRSAsyncClientTest.java (original)
+++ cxf/trunk/systests/jaxrs/src/test/java/org/apache/cxf/systest/jaxrs/JAXRSAsyncClientTest.java Fri Oct 18 18:15:45 2013
@@ -71,6 +71,16 @@ public class JAXRSAsyncClientTest extend
}
@Test
+ public void testDeleteWithBody() throws Exception {
+ String address = "http://localhost:" + PORT + "/bookstore/deletebody";
+ WebClient wc = WebClient.create(address);
+ wc.type("application/xml").accept("application/xml");
+ WebClient.getConfig(wc).getRequestContext().put("use.async.http.conduit", true);
+ Book book = wc.invoke("DELETE", new Book("Delete", 123L), Book.class);
+ assertEquals("Delete", book.getName());
+ }
+
+ @Test
public void testRetrieveBookCustomMethodAsync() throws Exception {
String address = "http://localhost:" + PORT + "/bookstore/retrieve";
WebClient wc = WebClient.create(address);