[GitHub] [pulsar] shibd commented on pull request #16719: [fix][client] Fix subscription topic name error.

[GitBox <gi...@apache.org>]

shibd commented on PR #16719:
URL: https://github.com/apache/pulsar/pull/16719#issuecomment-1192298802

   > Could you add a unit test to protect this change?
   
   @BewareMyPower Thanks for your reminder, I looked again, and It is found that we cannot be modify the logic in the `MultiTopicsConsumerImpl.subscribeAsync` method. Because users may use consumer like this:
   
   ``` java
           client.newConsumer().topic(
                           "persistent://public/dafault/test-topic1-partition-0",
                           "persistent://public/dafault/test-topic2-partition-1"
            );
   ```
   If force subscription to PartitionTopic inside the method, Then all partitions of `test-topic1` and `test-topic2` will be subscribed. This is a breaking change.
   
   So, I revert the original changes.
   
   The new changes are: Inside the `PatternTopicsChangedListener.onTopicsAdded` method let it use partitioned name to subscribe.
   
   @codelipenghui @mattisonchao @Technoboy- @nodece @BewareMyPower Sorry, please help review again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org