You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/09/02 15:46:36 UTC
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota
handling.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 1:46 p.m.)
Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
Changes
-------
Rebased
Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073
Repository: mesos
Description
-------
Added /quota HTTP Endpoint for Quota handling.
Diffs (updated)
-----
src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5
src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota
handling.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review97455
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36908, 36913]
All tests passed.
- Mesos ReviewBot
On Sept. 2, 2015, 1:46 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2015, 1:46 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
>
>
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added /quota HTTP Endpoint for Quota handling.
>
>
> Diffs
> -----
>
> src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5
> src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
> src/master/quota_handler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36913/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota
handling.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
-----------------------------------------------------------
(Updated Oct. 11, 2015, 4:12 p.m.)
Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
Changes
-------
Added to CMakeList.txt
Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073
Repository: mesos
Description
-------
Added /quota HTTP Endpoint for Quota handling.
Diffs (updated)
-----
src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d
src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f
src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota
handling.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Oct. 10, 2015, 10:08 a.m., Alex Clemmer wrote:
> > src/Makefile.am, line 492
> > <https://reviews.apache.org/r/36913/diff/13/?file=1091694#file1091694line492>
> >
> > Hey, could we please also add this to the `CMakeLists.txt` file in the `src/` directory? Thanks!
Done, please double-check and reopen if I have to do more :-). Thanks for pointing this out!
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review102159
-----------------------------------------------------------
On Oct. 11, 2015, 4:12 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> -----------------------------------------------------------
>
> (Updated Oct. 11, 2015, 4:12 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
>
>
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added /quota HTTP Endpoint for Quota handling.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d
> src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/master/quota_handler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36913/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota
handling.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review102159
-----------------------------------------------------------
src/Makefile.am (line 492)
<https://reviews.apache.org/r/36913/#comment159719>
Hey, could we please also add this to the `CMakeLists.txt` file in the `src/` directory? Thanks!
- Alex Clemmer
On Oct. 6, 2015, 9:31 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 9:31 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
>
>
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added /quota HTTP Endpoint for Quota handling.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/master/quota_handler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36913/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota
handling.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
-----------------------------------------------------------
(Updated Oct. 6, 2015, 9:31 a.m.)
Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
Changes
-------
rebased
Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073
Repository: mesos
Description
-------
Added /quota HTTP Endpoint for Quota handling.
Diffs (updated)
-----
src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f
src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
-------
make check
Thanks,
Joerg Schad
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota
handling.
Posted by Joerg Schad <jo...@mesosphere.io>.
> On Sept. 8, 2015, 7:14 a.m., Qian Zhang wrote:
> > src/master/master.hpp, line 901
> > <https://reviews.apache.org/r/36913/diff/12/?file=1062325#file1062325line901>
> >
> > Why we add CALL_HELP back?
resolved.
- Joerg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review97974
-----------------------------------------------------------
On Oct. 6, 2015, 9:31 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> -----------------------------------------------------------
>
> (Updated Oct. 6, 2015, 9:31 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
>
>
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added /quota HTTP Endpoint for Quota handling.
>
>
> Diffs
> -----
>
> src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba
> src/master/http.cpp 4b9f9ed005a4af2897171659d15168955cc60660
> src/master/master.hpp 9d957519bb0f717526af9b2717dc870fae93c20f
> src/master/master.cpp 6bee4f351c3fd0fb72f64bbc863968e4786b318b
> src/master/quota_handler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36913/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota
handling.
Posted by Qian Zhang <zh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/#review97974
-----------------------------------------------------------
src/master/master.hpp (line 901)
<https://reviews.apache.org/r/36913/#comment154103>
Why we add CALL_HELP back?
- Qian Zhang
On Sept. 3, 2015, 12:16 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36913/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2015, 12:16 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
>
>
> Bugs: MESOS-3073
> https://issues.apache.org/jira/browse/MESOS-3073
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added /quota HTTP Endpoint for Quota handling.
>
>
> Diffs
> -----
>
> src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5
> src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
> src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
> src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
> src/master/quota_handler.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/36913/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 36913: Added /quota HTTP Endpoint for Quota
handling.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36913/
-----------------------------------------------------------
(Updated Sept. 2, 2015, 4:16 p.m.)
Review request for mesos, Alexander Rukletsov and Bernd Mathiske.
Bugs: MESOS-3073
https://issues.apache.org/jira/browse/MESOS-3073
Repository: mesos
Description
-------
Added /quota HTTP Endpoint for Quota handling.
Diffs (updated)
-----
src/Makefile.am 7b4d9f65506e7fa8425966009401aae73cdb79a5
src/master/http.cpp 94e97a2898106579434e8cdec04b7b0e130a810e
src/master/master.hpp 594dd25f9aa9b6147680d0a838a77c3222941f4b
src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019
src/master/quota_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/36913/diff/
Testing
-------
make check
Thanks,
Joerg Schad