You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/11/20 21:28:12 UTC

[GitHub] [incubator-pinot] codecov-io commented on issue #4841: Remove the support of Hocon based config

codecov-io commented on issue #4841: Remove the support of Hocon based config
URL: https://github.com/apache/incubator-pinot/pull/4841#issuecomment-556420501
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4841?src=pr&el=h1) Report
   > Merging [#4841](https://codecov.io/gh/apache/incubator-pinot/pull/4841?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/2189c9273572401a85d5e9c69b3bc063328a8ec5?src=pr&el=desc) will **decrease** coverage by `<.01%`.
   > The diff coverage is `26.54%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/4841/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/4841?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #4841      +/-   ##
   ============================================
   - Coverage     57.43%   57.43%   -0.01%     
     Complexity        4        4              
   ============================================
     Files          1214     1194      -20     
     Lines         65581    64850     -731     
     Branches       9538     9432     -106     
   ============================================
   - Hits          37669    37247     -422     
   + Misses        25064    24861     -203     
   + Partials       2848     2742     -106
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4841?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...g/apache/pinot/common/config/CompletionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL0NvbXBsZXRpb25Db25maWcuamF2YQ==) | `54.54% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...va/org/apache/pinot/common/config/TableConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlQ29uZmlnLmphdmE=) | `77.81% <ø> (-1.71%)` | `0 <0> (ø)` | |
   | [.../instance/InstanceReplicaGroupPartitionConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlUmVwbGljYUdyb3VwUGFydGl0aW9uQ29uZmlnLmphdmE=) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...inot/common/config/ReplicaGroupStrategyConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1JlcGxpY2FHcm91cFN0cmF0ZWd5Q29uZmlnLmphdmE=) | `50% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...mmon/config/instance/InstanceAssignmentConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlQXNzaWdubWVudENvbmZpZy5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...mmon/config/instance/InstanceConstraintConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL2luc3RhbmNlL0luc3RhbmNlQ29uc3RyYWludENvbmZpZy5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...va/org/apache/pinot/common/config/QuotaConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1F1b3RhQ29uZmlnLmphdmE=) | `71.05% <ø> (-2.64%)` | `0 <0> (ø)` | |
   | [...n/java/org/apache/pinot/common/data/FieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9GaWVsZFNwZWMuamF2YQ==) | `75.81% <ø> (-0.47%)` | `0 <0> (ø)` | |
   | [.../org/apache/pinot/common/data/MetricFieldSpec.java](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZGF0YS9NZXRyaWNGaWVsZFNwZWMuamF2YQ==) | `92.3% <ø> (-0.42%)` | `0 <0> (ø)` | |
   | [...rg/apache/pinot/common/config/TableTaskConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1RhYmxlVGFza0NvbmZpZy5qYXZh) | `0% <ø> (-7.15%)` | `0 <0> (ø)` | |
   | ... and [64 more](https://codecov.io/gh/apache/incubator-pinot/pull/4841/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4841?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4841?src=pr&el=footer). Last update [2189c92...7866db5](https://codecov.io/gh/apache/incubator-pinot/pull/4841?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org