You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@synapse.apache.org by "Hiltbrunner Dominik (JIRA)" <ji...@apache.org> on 2008/01/31 09:37:34 UTC

[jira] Created: (SYNAPSE-231) missing handling of http responses with status 100 (continue)

missing handling of http responses with status 100 (continue)
-------------------------------------------------------------

                 Key: SYNAPSE-231
                 URL: https://issues.apache.org/jira/browse/SYNAPSE-231
             Project: Synapse
          Issue Type: Improvement
          Components: Transports
    Affects Versions: 1.1.1
         Environment: WinXP, Java 1.5.0_11-b03, Tomcat 5.5.9
            Reporter: Hiltbrunner Dominik
            Priority: Minor


The handling of http responses in the switch-statement(starting line 280) in class org.apache.synapse.transport.nhttp.ClientHandler may not be correct.
Since the default-block was added to the statement, the output written to the log is confusing, whenever a response with status 100 
(HTTP/1.1 100 Continue) is processed. But the responses are processed correctly.

Solution:
Adding proper handling of org.apache.http.HttpStatus.SC_CONTINUE(from the httpcore project) to the switch statement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Resolved: (SYNAPSE-231) missing handling of http responses with status 100 (continue)

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruwan Linton resolved SYNAPSE-231.
----------------------------------

    Resolution: Fixed

Fixed in the svn trunk. HTTP specification does not specify the clients to wait indefinitely to send the request body till they receive the 100 Continue even the client sends an Expectation header with "100-Continue" expectation. So the fix should work and we must keep in mind that we do not send the 100 Continue to the client in any instance.

http://www.w3.org/Protocols/rfc2616/rfc2616-sec8.html#sec8.2.3

I have tested this with dot net and seems to work.. :-)  

> missing handling of http responses with status 100 (continue)
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-231
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-231
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.1.1
>         Environment: WinXP, Java 1.5.0_11-b03, Tomcat 5.5.9
>            Reporter: Hiltbrunner Dominik
>            Assignee: Ruwan Linton
>             Fix For: 1.2
>
>
> The handling of http responses in the switch-statement(starting line 280) in class org.apache.synapse.transport.nhttp.ClientHandler may not be correct.
> Since the default-block was added to the statement, the output written to the log is confusing, whenever a response with status 100 
> (HTTP/1.1 100 Continue) is processed. But the responses are processed correctly.
> Solution:
> Adding proper handling of org.apache.http.HttpStatus.SC_CONTINUE(from the httpcore project) to the switch statement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Resolved: (SYNAPSE-231) missing handling of http responses with status 100 (continue)

Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Asankha C. Perera resolved SYNAPSE-231.
---------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.2)
                   1.3

Fixed with full support for clients expecting the 100 continue

> missing handling of http responses with status 100 (continue)
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-231
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-231
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.1.1
>         Environment: WinXP, Java 1.5.0_11-b03, Tomcat 5.5.9
>            Reporter: Hiltbrunner Dominik
>            Assignee: Asankha C. Perera
>             Fix For: 1.3
>
>
> The handling of http responses in the switch-statement(starting line 280) in class org.apache.synapse.transport.nhttp.ClientHandler may not be correct.
> Since the default-block was added to the statement, the output written to the log is confusing, whenever a response with status 100 
> (HTTP/1.1 100 Continue) is processed. But the responses are processed correctly.
> Solution:
> Adding proper handling of org.apache.http.HttpStatus.SC_CONTINUE(from the httpcore project) to the switch statement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Updated: (SYNAPSE-231) missing handling of http responses with status 100 (continue)

Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Asankha C. Perera updated SYNAPSE-231:
--------------------------------------

         Priority: Major  (was: Minor)
    Fix Version/s: 1.2
         Assignee: Asankha C. Perera

> missing handling of http responses with status 100 (continue)
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-231
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-231
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.1.1
>         Environment: WinXP, Java 1.5.0_11-b03, Tomcat 5.5.9
>            Reporter: Hiltbrunner Dominik
>            Assignee: Asankha C. Perera
>             Fix For: 1.2
>
>
> The handling of http responses in the switch-statement(starting line 280) in class org.apache.synapse.transport.nhttp.ClientHandler may not be correct.
> Since the default-block was added to the statement, the output written to the log is confusing, whenever a response with status 100 
> (HTTP/1.1 100 Continue) is processed. But the responses are processed correctly.
> Solution:
> Adding proper handling of org.apache.http.HttpStatus.SC_CONTINUE(from the httpcore project) to the switch statement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Commented: (SYNAPSE-231) missing handling of http responses with status 100 (continue)

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SYNAPSE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12590787#action_12590787 ] 

Ruwan Linton commented on SYNAPSE-231:
--------------------------------------

I think we just need to neglect the 100 Continue from the server and wait for the actual response according to the HTTP 1.1 spec. I have tested this with a dot net service and now the actual response is sent to the client after neglecting the 100 Continue response from the server.

Need to test server side of synapse if the client sends a Http Expect: "100-Continue" header, but the fix for the ClientHandler is final because if Synapse has to send 100 Continue it should send it while receiving the request and not after receiving the full request again according to the HTTP 1.1 rfc.

> missing handling of http responses with status 100 (continue)
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-231
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-231
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.1.1
>         Environment: WinXP, Java 1.5.0_11-b03, Tomcat 5.5.9
>            Reporter: Hiltbrunner Dominik
>            Assignee: Ruwan Linton
>             Fix For: 1.2
>
>
> The handling of http responses in the switch-statement(starting line 280) in class org.apache.synapse.transport.nhttp.ClientHandler may not be correct.
> Since the default-block was added to the statement, the output written to the log is confusing, whenever a response with status 100 
> (HTTP/1.1 100 Continue) is processed. But the responses are processed correctly.
> Solution:
> Adding proper handling of org.apache.http.HttpStatus.SC_CONTINUE(from the httpcore project) to the switch statement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Assigned: (SYNAPSE-231) missing handling of http responses with status 100 (continue)

Posted by "Ruwan Linton (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ruwan Linton reassigned SYNAPSE-231:
------------------------------------

    Assignee: Ruwan Linton  (was: Asankha C. Perera)

> missing handling of http responses with status 100 (continue)
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-231
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-231
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.1.1
>         Environment: WinXP, Java 1.5.0_11-b03, Tomcat 5.5.9
>            Reporter: Hiltbrunner Dominik
>            Assignee: Ruwan Linton
>             Fix For: 1.2
>
>
> The handling of http responses in the switch-statement(starting line 280) in class org.apache.synapse.transport.nhttp.ClientHandler may not be correct.
> Since the default-block was added to the statement, the output written to the log is confusing, whenever a response with status 100 
> (HTTP/1.1 100 Continue) is processed. But the responses are processed correctly.
> Solution:
> Adding proper handling of org.apache.http.HttpStatus.SC_CONTINUE(from the httpcore project) to the switch statement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org


[jira] Reopened: (SYNAPSE-231) missing handling of http responses with status 100 (continue)

Posted by "Asankha C. Perera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SYNAPSE-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Asankha C. Perera reopened SYNAPSE-231:
---------------------------------------

      Assignee: Asankha C. Perera  (was: Ruwan Linton)

Reopen as it is better to support older .net clients as per http://markmail.org/thread/c22mnj4v5p3eudui

> missing handling of http responses with status 100 (continue)
> -------------------------------------------------------------
>
>                 Key: SYNAPSE-231
>                 URL: https://issues.apache.org/jira/browse/SYNAPSE-231
>             Project: Synapse
>          Issue Type: Improvement
>          Components: Transports
>    Affects Versions: 1.1.1
>         Environment: WinXP, Java 1.5.0_11-b03, Tomcat 5.5.9
>            Reporter: Hiltbrunner Dominik
>            Assignee: Asankha C. Perera
>             Fix For: 1.2
>
>
> The handling of http responses in the switch-statement(starting line 280) in class org.apache.synapse.transport.nhttp.ClientHandler may not be correct.
> Since the default-block was added to the statement, the output written to the log is confusing, whenever a response with status 100 
> (HTTP/1.1 100 Continue) is processed. But the responses are processed correctly.
> Solution:
> Adding proper handling of org.apache.http.HttpStatus.SC_CONTINUE(from the httpcore project) to the switch statement.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@synapse.apache.org
For additional commands, e-mail: dev-help@synapse.apache.org