You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/07/25 21:29:21 UTC
(commons-beanutils) 12/23: Use valueOf()
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch 1.X
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git
commit 171c25ccdfb3e5eedde83ef41764fed5daef3bd0
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Thu Jul 25 17:20:12 2024 -0400
Use valueOf()
- Remove redundant parentheses
---
.../converters/FloatConverterTestCase.java | 58 +++++++++++-----------
1 file changed, 29 insertions(+), 29 deletions(-)
diff --git a/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java b/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java
index 44e17110..3ee552ce 100644
--- a/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils/converters/FloatConverterTestCase.java
@@ -42,10 +42,10 @@ public class FloatConverterTestCase extends NumberConverterTestBase {
@Override
public void setUp() throws Exception {
converter = makeConverter();
- numbers[0] = new Float("-12");
- numbers[1] = new Float("13");
- numbers[2] = new Float("-22");
- numbers[3] = new Float("23");
+ numbers[0] = Float.valueOf("-12");
+ numbers[1] = Float.valueOf("13");
+ numbers[2] = Float.valueOf("-22");
+ numbers[3] = Float.valueOf("23");
}
public static TestSuite suite() {
@@ -101,45 +101,45 @@ public class FloatConverterTestCase extends NumberConverterTestBase {
"1.1",
"17.2",
String.valueOf(Float.MAX_VALUE),
- new Byte((byte)7),
- new Short((short)8),
- new Integer(9),
- new Long(10),
- new Float(11.1),
- new Double(12.2),
+ Byte.valueOf((byte)7),
+ Short.valueOf((short)8),
+ Integer.valueOf(9),
+ Long.valueOf(10),
+ Float.valueOf((float) 11.1),
+ Double.valueOf(12.2),
};
final Float[] expected = {
- new Float(Float.MIN_VALUE),
- new Float(-17.2),
- new Float(-1.1),
- new Float(0.0),
- new Float(1.1),
- new Float(17.2),
- new Float(Float.MAX_VALUE),
- new Float(7),
- new Float(8),
- new Float(9),
- new Float(10),
- new Float(11.1),
- new Float(12.2)
+ Float.valueOf(Float.MIN_VALUE),
+ Float.valueOf((float) -17.2),
+ Float.valueOf((float) -1.1),
+ Float.valueOf((float) 0.0),
+ Float.valueOf((float) 1.1),
+ Float.valueOf((float) 17.2),
+ Float.valueOf(Float.MAX_VALUE),
+ Float.valueOf(7),
+ Float.valueOf(8),
+ Float.valueOf(9),
+ Float.valueOf(10),
+ Float.valueOf((float) 11.1),
+ Float.valueOf((float) 12.2)
};
for(int i=0;i<expected.length;i++) {
assertEquals(
message[i] + " to Float",
expected[i].floatValue(),
- (converter.convert(Float.class,input[i])).floatValue(),
+ converter.convert(Float.class,input[i]).floatValue(),
0.00001);
assertEquals(
message[i] + " to float",
expected[i].floatValue(),
- (converter.convert(Float.TYPE,input[i])).floatValue(),
+ converter.convert(Float.TYPE,input[i]).floatValue(),
0.00001);
assertEquals(
message[i] + " to null type",
expected[i].floatValue(),
- ((Float)(converter.convert(null,input[i]))).floatValue(),
+ ((Float)converter.convert(null,input[i])).floatValue(),
0.00001);
}
}
@@ -152,11 +152,11 @@ public class FloatConverterTestCase extends NumberConverterTestBase {
final Converter converter = makeConverter();
final Class<?> clazz = Float.class;
- final Double max = new Double(Float.MAX_VALUE);
- final Double tooBig = new Double(Double.MAX_VALUE);
+ final Double max = Double.valueOf(Float.MAX_VALUE);
+ final Double tooBig = Double.valueOf(Double.MAX_VALUE);
// Maximum
- assertEquals("Maximum", new Float(Float.MAX_VALUE), converter.convert(clazz, max));
+ assertEquals("Maximum", Float.valueOf(Float.MAX_VALUE), converter.convert(clazz, max));
// Too Large
try {