You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/02/24 12:30:18 UTC

Review Request 31352: Provide setup-ldap option option to set referral method

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31352/
-----------------------------------------------------------

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-9767
    https://issues.apache.org/jira/browse/AMBARI-9767


Repository: ambari


Description
-------

ambari-server sync-ldap fails with certain AD setups. Need to follow referrals.

    [root@revo1 hdfs]# ambari-server sync-ldap --all
    Using python  /usr/bin/python2.6
    Syncing with LDAP...
    Enter Ambari Admin login: admin
    Enter Ambari Admin password: 
    Syncing all...ERROR: Exiting with exit code 1. 
    REASON: Caught exception running LDAP sync. Unprocessed Continuation Reference(s); nested exception is javax.naming.PartialResultException: Unprocessed Continuation Reference(s); remaining name 'dc=...'

To fix this:
1) Have sync-ldap follow referrals by default
2) expose a step in setup-ldap to set the referral method (follow or ignore)


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d859523 
  ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java ddb3670 
  ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java 05494e3 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 71b246d 
  ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java ea5570e 

Diff: https://reviews.apache.org/r/31352/diff/


Testing
-------

Manual testing and new unit test.


Thanks,

Tom Beerbower


Re: Review Request 31352: Provide setup-ldap option option to set referral method

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31352/#review73800
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Feb. 24, 2015, 6:30 a.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31352/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 6:30 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-9767
>     https://issues.apache.org/jira/browse/AMBARI-9767
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ambari-server sync-ldap fails with certain AD setups. Need to follow referrals.
> 
>     [root@revo1 hdfs]# ambari-server sync-ldap --all
>     Using python  /usr/bin/python2.6
>     Syncing with LDAP...
>     Enter Ambari Admin login: admin
>     Enter Ambari Admin password: 
>     Syncing all...ERROR: Exiting with exit code 1. 
>     REASON: Caught exception running LDAP sync. Unprocessed Continuation Reference(s); nested exception is javax.naming.PartialResultException: Unprocessed Continuation Reference(s); remaining name 'dc=...'
> 
> To fix this:
> 1) Have sync-ldap follow referrals by default
> 2) expose a step in setup-ldap to set the referral method (follow or ignore)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d859523 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java ddb3670 
>   ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java 05494e3 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 71b246d 
>   ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java ea5570e 
> 
> Diff: https://reviews.apache.org/r/31352/diff/
> 
> 
> Testing
> -------
> 
> Manual testing and new unit test.
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 31352: Provide setup-ldap option option to set referral method

Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31352/#review73820
-----------------------------------------------------------

Ship it!


Ship It!

- Jonathan Hurley


On Feb. 24, 2015, 10 a.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31352/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2015, 10 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Nate Cole.
> 
> 
> Bugs: AMBARI-9767
>     https://issues.apache.org/jira/browse/AMBARI-9767
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> ambari-server sync-ldap fails with certain AD setups. Need to follow referrals.
> 
>     [root@revo1 hdfs]# ambari-server sync-ldap --all
>     Using python  /usr/bin/python2.6
>     Syncing with LDAP...
>     Enter Ambari Admin login: admin
>     Enter Ambari Admin password: 
>     Syncing all...ERROR: Exiting with exit code 1. 
>     REASON: Caught exception running LDAP sync. Unprocessed Continuation Reference(s); nested exception is javax.naming.PartialResultException: Unprocessed Continuation Reference(s); remaining name 'dc=...'
> 
> To fix this:
> 1) Have sync-ldap follow referrals by default
> 2) expose a step in setup-ldap to set the referral method (follow or ignore)
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d859523 
>   ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java ddb3670 
>   ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java 05494e3 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 71b246d 
>   ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java ea5570e 
>   ambari-server/src/test/python/TestAmbariServer.py 8bf7409 
> 
> Diff: https://reviews.apache.org/r/31352/diff/
> 
> 
> Testing
> -------
> 
> Manual testing and new unit test.
> 
> All tests pass ...
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 32:11 min
> [INFO] Finished at: 2015-02-24T09:55:20-05:00
> [INFO] Final Memory: 42M/619M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>


Re: Review Request 31352: Provide setup-ldap option option to set referral method

Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31352/
-----------------------------------------------------------

(Updated Feb. 24, 2015, 3 p.m.)


Review request for Ambari, Jonathan Hurley and Nate Cole.


Changes
-------

Update testing


Bugs: AMBARI-9767
    https://issues.apache.org/jira/browse/AMBARI-9767


Repository: ambari


Description
-------

ambari-server sync-ldap fails with certain AD setups. Need to follow referrals.

    [root@revo1 hdfs]# ambari-server sync-ldap --all
    Using python  /usr/bin/python2.6
    Syncing with LDAP...
    Enter Ambari Admin login: admin
    Enter Ambari Admin password: 
    Syncing all...ERROR: Exiting with exit code 1. 
    REASON: Caught exception running LDAP sync. Unprocessed Continuation Reference(s); nested exception is javax.naming.PartialResultException: Unprocessed Continuation Reference(s); remaining name 'dc=...'

To fix this:
1) Have sync-ldap follow referrals by default
2) expose a step in setup-ldap to set the referral method (follow or ignore)


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java d859523 
  ambari-server/src/main/java/org/apache/ambari/server/security/authorization/LdapServerProperties.java ddb3670 
  ambari-server/src/main/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulator.java 05494e3 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 71b246d 
  ambari-server/src/test/java/org/apache/ambari/server/security/ldap/AmbariLdapDataPopulatorTest.java ea5570e 
  ambari-server/src/test/python/TestAmbariServer.py 8bf7409 

Diff: https://reviews.apache.org/r/31352/diff/


Testing (updated)
-------

Manual testing and new unit test.

All tests pass ...

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 32:11 min
[INFO] Finished at: 2015-02-24T09:55:20-05:00
[INFO] Final Memory: 42M/619M
[INFO] ------------------------------------------------------------------------


Thanks,

Tom Beerbower