Re: [PR] GUACAMOLE-2113: Improve warning when WoL is enabled but no MAC address is provided [guacamole-server]

["svkurupath-keeper (via GitHub)" <gi...@apache.org>]

svkurupath-keeper commented on PR #606:
URL: https://github.com/apache/guacamole-server/pull/606#issuecomment-3145875742

   > With respect to the changes themselves, LGTM.
   > 
   > A couple things need to be addressed before this is mergeable:
   > 
   > * As a minor fix/improvement that does not impact documentation, this should be against `patch` instead of `main`. (See [the documentation covering our branching scheme](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=293047342#VersionNumberingandBranchingScheme-BranchNames).)
   > * The commit message needs to be formatted to match established formatting (JIRA issue followed by a colon, etc.).
   > 
   > Since each of the messages is being modified as a part of this, these changes could be a good opportunity to make these messages consistent (ie: `WoL requested` vs. `WoL was enabled` vs. `Wake on LAN was requested` vs. ...). I don't think that's deal-breaking, though.
   
   Changed the target to `apache:patch`.
   Changed the commit messages to reflect the established style for the project.
   With the new changes, the same message will be used for logging each time when a WoL MAC Address is not specified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org