You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2023/01/10 11:22:35 UTC

[GitHub] [orc] zhjwpku opened a new pull request, #1374: ORC-1355: [C++] change Writer::addUserMetadata's parameters to const reference

zhjwpku opened a new pull request, #1374:
URL: https://github.com/apache/orc/pull/1374

   
   ### What changes were proposed in this pull request?
   
   change `void addUserMetadata(const std::string name, const std::string value) override;`
       to `void addUserMetadata(const std::string& name, const std::string& value) override;`
   to reduce copy construct.
   
   
   ### Why are the changes needed?
   
   performance improvement.
   
   
   ### How was this patch tested?
   
   This patch introduces no new features and all the exist test cases passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun closed pull request #1374: ORC-1355: [C++] Use const references in `addUserMetadata|printAttributes|stripPrefix`

Posted by GitBox <gi...@apache.org>.
williamhyun closed pull request #1374: ORC-1355: [C++] Use const references in `addUserMetadata|printAttributes|stripPrefix`
URL: https://github.com/apache/orc/pull/1374


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #1374: ORC-1355: [C++] Use const references in `addUserMetadata|printAttributes|stripPrefix`

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #1374:
URL: https://github.com/apache/orc/pull/1374#issuecomment-1377633130

   cc @wgtmac , @stiga-huang , @williamhyun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] williamhyun commented on pull request #1374: ORC-1355: [C++] Use const references in `addUserMetadata|printAttributes|stripPrefix`

Posted by GitBox <gi...@apache.org>.
williamhyun commented on PR #1374:
URL: https://github.com/apache/orc/pull/1374#issuecomment-1378169897

   Thank you @zhjwpku I will merge this now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] zhjwpku commented on pull request #1374: ORC-1355: [C++] change Writer::addUserMetadata's parameters to const reference

Posted by GitBox <gi...@apache.org>.
zhjwpku commented on PR #1374:
URL: https://github.com/apache/orc/pull/1374#issuecomment-1377150672

   > It would be better to do this as a single PR instead of one-by-one, @zhjwpku .
   
   I am reading the codebase file by file, not sure how many this kind of drawbacks will be ;(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] zhjwpku commented on pull request #1374: ORC-1355: [C++] change Writer::addUserMetadata's parameters to const reference

Posted by GitBox <gi...@apache.org>.
zhjwpku commented on PR #1374:
URL: https://github.com/apache/orc/pull/1374#issuecomment-1377211061

   > It would be better to do this as a single PR instead of one-by-one, @zhjwpku .
   
   hi @dongjoon-hyun , I have searched the codebase and found two other this kind
   of bugs, seems these are no more others.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org