You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/25 15:19:52 UTC
[GitHub] [doris] jackwener opened a new pull request, #12083: [fix](Nereids): fix some problem in Nereids.
jackwener opened a new pull request, #12083:
URL: https://github.com/apache/doris/pull/12083
# Proposed changes
Issue Number: close #xxx
## Problem summary
fix some problem in Nereids.
## Checklist(Required)
1. Does it affect the original behavior:
- [x] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #12083: [fix](Nereids): fix problem in CBO
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #12083:
URL: https://github.com/apache/doris/pull/12083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #12083: [fix](Nereids): fix problem in CBO
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #12083:
URL: https://github.com/apache/doris/pull/12083#discussion_r955773591
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapScan.java:
##########
@@ -68,7 +92,7 @@ public String toString() {
return "ScanOlapTable ("
+ qualifiedName()
+ ", output: "
- + getOutput().stream().map(Objects::toString).collect(Collectors.joining(", ", "[", "]"))
+ + getOutput().stream().map(Objects::toString).collect(Collectors.joining(", ", "[", "]"))
Review Comment:
need to print new attributes for debug easily
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/PlanEqualsTest.java:
##########
@@ -193,7 +195,12 @@ public void testPhysicalOlapScan(
@Mocked DistributionSpecHash distributionSpecHash) {
List<String> qualifier = Lists.newArrayList();
- PhysicalOlapScan olapScan = new PhysicalOlapScan(olapTable, qualifier, distributionSpecHash, Optional.empty(),
+ ArrayList<Long> selectedTabletId = Lists.newArrayList();
+ for (Partition partition : olapTable.getAllPartitions()) {
+ selectedTabletId.addAll(partition.getBaseIndex().getTabletIdsInOrder());
+ }
+ PhysicalOlapScan olapScan = new PhysicalOlapScan(olapTable, qualifier, olapTable.getBaseIndexId(),
+ selectedTabletId, olapTable.getPartitionIds(), distributionSpecHash, Optional.empty(),
logicalProperties);
Assertions.assertEquals(olapScan, olapScan);
Review Comment:
compare same object is not a good idea, it is better to new two different object and then compare them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org