[PR] GUACAMOLE-1969: Clamp negative timestamps in ClipboardEventInterpreter. [guacamole-client]

["aleitner (via GitHub)" <gi...@apache.org>]

aleitner opened a new pull request, #1209:
URL: https://github.com/apache/guacamole-client/pull/1209

   A clipboard stream may arrive in the recording before the first sync instruction sets `lastTimestamp`, leaving `stream.timestamp` at 0 when the event is finalized. The resulting event timestamp is then computed as `0 - startTimestamp`, producing a large negative value.
   
   When the recording player renders the affected batch, it calls `playerTimeService.formatTime(value)` on that negative timestamp. The leading '-' breaks the regex match used to strip leading zeroes, `.exec()` returns `null`, and indexing null throws a `TypeError` inside `$interpolate`. Angular swallows the exception and leaves the "{{ formatTime(batch.events[0].timestamp) }}" placeholder literal in the DOM for that batch.
   
   Clamp the event timestamp to a minimum of 0 so clipboard syncs that predate the first sync instruction land at the start of the playback timeline.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] GUACAMOLE-1969: Clamp negative timestamps in ClipboardEventInterpreter. [guacamole-client]

["necouchman (via GitHub)" <gi...@apache.org>]

necouchman merged PR #1209:
URL: https://github.com/apache/guacamole-client/pull/1209


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org