[GitHub] [doris] morningman commented on a diff in pull request #15830: [enhancement](load) change transaction limit from global level to db level

[GitBox <gi...@apache.org>]

morningman commented on code in PR #15830:
URL: https://github.com/apache/doris/pull/15830#discussion_r1071953464


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Database.java:
##########
@@ -557,6 +570,7 @@ public void write(DataOutput out) throws IOException {
 
         out.writeLong(replicaQuotaSize);
         dbProperties.write(out);
+        out.writeLong(transactionQuotaSize);

Review Comment:
   We can use dbProperties to save this, so that we don't need to upgrade meta version



##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -740,7 +740,7 @@ public class Config extends ConfigBase {
      * txn manager will reject coming txns
      */
     @ConfField(mutable = true, masterOnly = true)
-    public static int max_running_txn_num_per_db = 100;
+    public static int default_db_max_running_txn_num = 100;

Review Comment:
   How about NOT changing the origin config name?
   As far as I know, many user modified this config by their own



##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Database.java:
##########
@@ -604,6 +618,10 @@ public void readFields(DataInput in) throws IOException {
         if (Env.getCurrentEnvJournalVersion() >= FeMetaVersion.VERSION_105) {
             dbProperties = DatabaseProperty.read(in);
         }
+
+        if (Env.getCurrentEnvJournalVersion() >= FeMetaVersion.VERSION_116) {
+            transactionQuotaSize = in.readLong();
+        }

Review Comment:
   There should be an `else` to set `transactionQuotaSize` to Config.defaut_xxx;



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org