You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2025/08/22 19:09:03 UTC
[Impala-ASF-CR] IMPALA-14347: Need to support LocalFsTable table types.
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23336
Change subject: IMPALA-14347: Need to support LocalFsTable table types.
......................................................................
IMPALA-14347: Need to support LocalFsTable table types.
Recently the use_local_catalog default was set to true. This causes
failure for when the use_calcite_planner query option is set to true.
The Calcite planner was only handling HdfsTable table types. It will
now handle LocalFsTable table types as well.
Change-Id: If3bdb388ba004799ad78dc76461506478b581125
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteDb.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/schema/CalciteTable.java
3 files changed, 11 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/23336/1
--
To view, visit http://gerrit.cloudera.org:8080/23336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3bdb388ba004799ad78dc76461506478b581125
Gerrit-Change-Number: 23336
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-14347: Need to support LocalFsTable table types.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has abandoned this change. ( http://gerrit.cloudera.org:8080/23336 )
Change subject: IMPALA-14347: Need to support LocalFsTable table types.
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/23336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: If3bdb388ba004799ad78dc76461506478b581125
Gerrit-Change-Number: 23336
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-14347: Need to support LocalFsTable table types.
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23336 )
Change subject: IMPALA-14347: Need to support LocalFsTable table types.
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/23336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3bdb388ba004799ad78dc76461506478b581125
Gerrit-Change-Number: 23336
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Aug 2025 19:44:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14347: Need to support LocalFsTable table types.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23336 )
Change subject: IMPALA-14347: Need to support LocalFsTable table types.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/20240/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/23336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3bdb388ba004799ad78dc76461506478b581125
Gerrit-Change-Number: 23336
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Aug 2025 19:36:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14347: Need to support LocalFsTable table types.
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23336 )
Change subject: IMPALA-14347: Need to support LocalFsTable table types.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/23336/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/23336/1//COMMIT_MSG@8
PS1, Line 8:
: Recently the use_local_catalog default was set to true. This causes
: failure for when the use_calcite_planner query option is set to true.
Please change following tests to use local catalog mode to confirm that this patch works.
TestCalcitePlanner.test_calcite_frontend
TestWorkloadManagementSQLDetailsCalcite.test_tpcds_8_decimal
--
To view, visit http://gerrit.cloudera.org:8080/23336
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If3bdb388ba004799ad78dc76461506478b581125
Gerrit-Change-Number: 23336
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <am...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Aug 2025 19:17:13 +0000
Gerrit-HasComments: Yes