You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "itzmzn (via GitHub)" <gi...@apache.org> on 2026/10/13 06:39:46 UTC

[PR] fix(dashboard): preserve source audit fields on Save As [superset]

itzmzn opened a new pull request, #45235:
URL: https://github.com/apache/superset/pull/45235

   ### SUMMARY
   
   Save As was updating the original dashboard after creating the copy. The success handler called `saveChartConfiguration`, which used the source dashboard ID still held in Redux.
   
   This moves the cross-filter configuration into the copy request and removes that follow-up save. The regression tests cover copying with and without duplicate charts.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   No visual changes. Manual verification in a running Superset instance is still pending.
   
   ### TESTING INSTRUCTIONS
   
   1. Open an existing dashboard and note its last-modified time and user.
   2. Use Save As with "Also copy (duplicate) existing charts" enabled.
   3. Check that the copy opens, its charts are duplicated, and the original dashboard's audit fields remain unchanged.
   4. Repeat with chart duplication disabled and check that cross-filter scoping is preserved.
   
   Automated validation on the reviewed upstream revision:
   - All 46 tests in `dashboardState.test.ts` passed.
   - The two new regression cases failed against the original implementation.
   - Formatting, lint, custom rules, and stylelint passed.
   - Type checking did not pass because shared-package declarations had not been built.
   
   AI assisted with the implementation and automated validation. This is a draft until manual verification and type checking are complete.
   
   ### ADDITIONAL INFORMATION
   
   - [x] Has associated issue: Fixes #45218
   - [ ] Required feature flags
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): preserve source audit fields on Save As [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45235:
URL: https://github.com/apache/superset/pull/45235#issuecomment-6397978411

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 975151be942a571a4fc26c98efaa46de4c1bb35e |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6addfd28be8db2edec5cc626 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45235--superset-docs-preview.netlify.app](https://deploy-preview-45235--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ1MjM1LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.Tmk0XeRMWTwQktOIzsK9efxNhrbUGzFWuEOqpj4TMx8)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#q1YqKMrPLShRslJS0lFKKkrMS84AsnMTi0tSi4AiKakFOfmVnilAMbPElJS0FCOLpFSLlCSj1JTUZNPkZDMjM6VaAA) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-45235--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): preserve source audit fields on Save As [superset]

Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on code in PR #45235:
URL: https://github.com/apache/superset/pull/45235#discussion_r4402490078


##########
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformers.ts:
##########
@@ -760,7 +760,7 @@ export function transformFormulaAnnotation(
   return {
     name,
     id: name,
-    z: 10,
+    z: 0,

Review Comment:
   This walks back #41174, which set formula and event annotations to `z: 10` on purpose to draw them in front of the series. At `z: 0` a threshold line on a bar or area chart ends up behind the fills, and interval annotations stay at 10, so the two kinds would disagree.
   
   If there's a real data label overlap to fix, it deserves its own PR with a screenshot. Mind pulling this and the new transformer tests out of the Save As fix?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): preserve source audit fields on Save As [superset]

Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on code in PR #45235:
URL: https://github.com/apache/superset/pull/45235#discussion_r4255950135


##########
superset-frontend/src/dashboard/actions/dashboardState.test.ts:
##########
@@ -178,6 +180,51 @@ describe('dashboardState actions', () => {
 
   // eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
   describe('saveDashboardRequest', () => {
+    test.each([false, true])(
+      'Save As preserves scoping without updating the source (duplicate_slices=%s)',
+      async duplicateSlices => {
+        const sourceId = 192;
+        const copyId = 193;
+        const { getState, state } = setup({
+          dashboardInfo: { ...mockState.dashboardInfo, id: sourceId },
+        });
+        const dispatch: jest.Mock = jest.fn(action =>
+          typeof action === 'function' ? action(dispatch, getState) : action,
+        );
+        postStub.mockResolvedValue({
+          json: { result: { id: copyId, last_modified_time: 123 } },
+        } as unknown as JsonResponse);
+        const { chartConfiguration, globalChartConfiguration } =
+          getCrossFiltersConfiguration(
+            state.dashboardLayout.present,

Review Comment:
   `tsc` rejects this argument (TS2345 at 199:13), and that's what is failing lint-frontend. The mock layout's `meta: {}` doesn't satisfy `DashboardLayout`.
   
   A cast like the one on the metadata argument just below should clear it.



##########
superset-frontend/src/dashboard/actions/dashboardState.ts:
##########
@@ -766,11 +757,17 @@ export function saveDashboardRequest(
     (cleanedData.metadata as JsonObject).default_filters =
       safeStringify(serializedFilters);
     (cleanedData.metadata as JsonObject).filter_scopes = serializedFilterScopes;
+    const { chartConfiguration, globalChartConfiguration } =
+      handleChartConfiguration();
     const copyPayload = {
       dashboard_title: cleanedData.dashboard_title,
       css: cleanedData.css,
       duplicate_slices: cleanedData.duplicate_slices,
-      json_metadata: JSON.stringify(cleanedData.metadata),
+      json_metadata: JSON.stringify({
+        ...cleanedData.metadata,
+        chart_configuration: chartConfiguration,

Review Comment:
   With `duplicate_slices` on, this config is keyed by the source chart ids. `copy_dashboard` remaps `positions` and `filter_scopes` through `old_to_new_slice_ids`, but `chart_configuration` passes straight through `set_dash_metadata`, so custom per-chart scoping is lost when the copy loads.
   
   Not new, the copy already inherited the same ids from `original_dash.params`. But the `duplicate_slices=true` test case is called "preserves scoping" and asserts the source-keyed config. Remap it in the DAO, or rename the case so it doesn't claim that?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): preserve source audit fields on Save As [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45235:
URL: https://github.com/apache/superset/pull/45235#issuecomment-6139883199

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 3cbbc47c15f452cfd969d8ea22dbcd8e0f124bab |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6acdd233546b428ec75a0834 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45235--superset-docs-preview.netlify.app](https://deploy-preview-45235--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ1MjM1LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.Tmk0XeRMWTwQktOIzsK9efxNhrbUGzFWuEOqpj4TMx8)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#q1YqKMrPLShRslJS0lFKKkrMS84AsnMTi0tSi4AiKakFOfmVnilAMbPE5JQUI2NjUxOzJBMji9Rkc9NEAwtjE6VaAA) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-45235--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): preserve source audit fields on Save As [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45235:
URL: https://github.com/apache/superset/pull/45235#issuecomment-6143928686

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | fbb3c5bf9eed453dc80a979ab3619fdf0a196de1 |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ace0ce351ac85b2ad8b9fc7 |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45235--superset-docs-preview.netlify.app](https://deploy-preview-45235--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ1MjM1LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.Tmk0XeRMWTwQktOIzsK9efxNhrbUGzFWuEOqpj4TMx8)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#q1YqKMrPLShRslJS0lFKKkrMS84AsnMTi0tSi4AiKakFOfmVnilAMbPE5FSD5FRjU8PEZAvTJKPEFIsky7Rkc6VaAA) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-45235--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): preserve source audit fields on Save As [superset]

Posted by "EnxDev (via GitHub)" <gi...@apache.org>.
EnxDev commented on code in PR #45235:
URL: https://github.com/apache/superset/pull/45235#discussion_r4258027713


##########
superset/daos/dashboard.py:
##########
@@ -857,6 +861,8 @@ def copy_dashboard(
                             ]
                         )
                     value["meta"]["chartId"] = new_id
+
+            update_cross_filter_scoping({"metadata": metadata}, old_to_new_slice_ids)

Review Comment:
   This remaps the config the request carries, but the copy still starts from `original_dash.params`. So a `/copy/` call with `duplicate_slices` on and no `chart_configuration` in `json_metadata` keeps the source's entries, keyed by the source chart ids.
   
   The UI always sends both keys, so not blocking. Seeding them from `original_dash.params_dict` when they're missing, before this call, would close it (in a small helper, `copy_dashboard` is already at the C901 limit).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): preserve source audit fields on Save As [superset]

Posted by "itzmzn (via GitHub) via notifications" <no...@superset.apache.org>.
itzmzn closed pull request #45235: fix(dashboard): preserve source audit fields on Save As
URL: https://github.com/apache/superset/pull/45235


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): preserve source audit fields on Save As [superset]

Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #45235:
URL: https://github.com/apache/superset/pull/45235#issuecomment-6143964766

   ### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
   
   
   |  Name | Link |
   |:-:|------------------------|
   |<span aria-hidden="true">🔨</span> Latest commit | 78aa949c0d6756de7d34925766f655a4dd9dc0bf |
   |<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6ace0d49a19e7a1f5a32f54f |
   |<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-45235--superset-docs-preview.netlify.app](https://deploy-preview-45235--superset-docs-preview.netlify.app) |
   |<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br />![QR Code](https://app.netlify.com/qr-code/eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1cmwiOiJodHRwczovL2RlcGxveS1wcmV2aWV3LTQ1MjM1LS1zdXBlcnNldC1kb2NzLXByZXZpZXcubmV0bGlmeS5hcHAifQ.Tmk0XeRMWTwQktOIzsK9efxNhrbUGzFWuEOqpj4TMx8)<br /><br />_Use your smartphone camera to open QR code link._</details> |
   |<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#q1YqKMrPLShRslJS0lFKKkrMS84AsnMTi0tSi4AiKakFOfmVnilAMbPE5FSDFBPLREPLVPNEwzTTRGOjNFOTNKVaAA) |
   ---
   <!-- [superset-docs-preview Preview](https://deploy-preview-45235--superset-docs-preview.netlify.app) -->
   _To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): preserve source audit fields on Save As [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45235:
URL: https://github.com/apache/superset/pull/45235#issuecomment-6144379026

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45235?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 64.95%. Comparing base ([`6d974e1`](https://app.codecov.io/gh/apache/superset/commit/6d974e19c51f0a90eb70bd174306fd083c368f7b?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2d35fc9`](https://app.codecov.io/gh/apache/superset/commit/2d35fc99c759d4ffd4e545f2b8df8026b1fe4756?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 6 commits behind head on master.
   > :exclamation:  There is a different number of reports uploaded between BASE (6d974e1) and HEAD (2d35fc9). Click for more details.
   > 
   > <details><summary>HEAD has 4 uploads less than BASE</summary>
   >
   >| Flag | BASE (6d974e1) | HEAD (2d35fc9) |
   >|------|------|------|
   >|python|7|3|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff             @@
   ##           master   #45235       +/-   ##
   ===========================================
   - Coverage   83.09%   64.95%   -18.14%     
   ===========================================
     Files        3028     3029        +1     
     Lines      196609   196697       +88     
     Branches    45923    45940       +17     
   ===========================================
   - Hits       163369   127771    -35598     
   - Misses      30016    66036    +36020     
   + Partials     3224     2890      -334     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/45235/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [hive](https://app.codecov.io/gh/apache/superset/pull/45235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `35.04% <0.00%> (-0.02%)` | :arrow_down: |
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/45235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.74% <100.00%> (+<0.01%)` | :arrow_up: |
   | [mysql](https://app.codecov.io/gh/apache/superset/pull/45235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [postgres](https://app.codecov.io/gh/apache/superset/pull/45235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [presto](https://app.codecov.io/gh/apache/superset/pull/45235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.81% <0.00%> (-0.02%)` | :arrow_down: |
   | [python](https://app.codecov.io/gh/apache/superset/pull/45235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.17% <100.00%> (-33.55%)` | :arrow_down: |
   | [sqlite](https://app.codecov.io/gh/apache/superset/pull/45235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.05% <100.00%> (-0.01%)` | :arrow_down: |
   | [unit](https://app.codecov.io/gh/apache/superset/pull/45235/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45235?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org