You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2009/05/14 19:04:45 UTC
[jira] Updated: (HADOOP-5835) Fix findbugs warnings
[ https://issues.apache.org/jira/browse/HADOOP-5835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5835:
------------------------------------
Attachment: findbugs.patch
Warnings fixed:
# org.apache.hadoop.hdfs.server.protocol.BlockMetaDataInfo doesn't override org.apache.hadoop.hdfs.protocol.Block.equals(Object)
# org.apache.hadoop.hdfs.server.protocol.DatanodeRegistration doesn't override org.apache.hadoop.hdfs.protocol.DatanodeID.equals(Object)
# Write to static field org.apache.hadoop.hdfs.server.datanode.DataNode.datanodeObject from instance method new org.apache.hadoop.hdfs.server.datanode.DataNode(Configuration, AbstractList?)
# Write to static field org.apache.hadoop.hdfs.server.datanode.DataNode.nameNodeAddr from instance method org.apache.hadoop.hdfs.server.datanode.DataNode.startDataNode(Configuration, AbstractList?)
# Write to static field org.apache.hadoop.hdfs.server.namenode.NameNode.myMetrics from instance method org.apache.hadoop.hdfs.server.namenode.NameNode.initialize(Configuration)
Changes:
# Added {{equals}} method implementation
# Made Namenode constructor protected so that {{createNameNode}} methods are the only way to create namenode. Initializing static variables using a static method.
# Made Datanode constructor protected so that {{makeInstance}} method is the only way to create datanode. Initializing static variables using a static method.
> Fix findbugs warnings
> ---------------------
>
> Key: HADOOP-5835
> URL: https://issues.apache.org/jira/browse/HADOOP-5835
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: findbugs.patch
>
>
> Cleaning up findbugs warnings for some of the files
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.