You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2010/12/15 18:40:03 UTC
[jira] Created: (WHIRR-162) DnsUtilTest fails when offline or for
slow connections
DnsUtilTest fails when offline or for slow connections
------------------------------------------------------
Key: WHIRR-162
URL: https://issues.apache.org/jira/browse/WHIRR-162
Project: Whirr
Issue Type: Bug
Components: service/hadoop
Reporter: Tom White
Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-162) DnsUtilTest fails when offline or for
slow connections
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972240#action_12972240 ]
Tom White commented on WHIRR-162:
---------------------------------
DnsUtilTest was moved to be an integration test as a part of WHIRR-150. Increasing the timeout should be addressed here.
> DnsUtilTest fails when offline or for slow connections
> ------------------------------------------------------
>
> Key: WHIRR-162
> URL: https://issues.apache.org/jira/browse/WHIRR-162
> Project: Whirr
> Issue Type: Bug
> Components: service/hadoop
> Reporter: Tom White
>
> Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WHIRR-162) DnsUtilTest fails when offline or for
slow connections
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White reassigned WHIRR-162:
-------------------------------
Assignee: Andrei Savu
> DnsUtilTest fails when offline or for slow connections
> ------------------------------------------------------
>
> Key: WHIRR-162
> URL: https://issues.apache.org/jira/browse/WHIRR-162
> Project: Whirr
> Issue Type: Bug
> Components: service/hadoop
> Reporter: Tom White
> Assignee: Andrei Savu
> Attachments: WHIRR-162.patch
>
>
> Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-162) DnsUtilTest fails when offline or for
slow connections
Posted by "Tibor Kiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973503#action_12973503 ]
Tibor Kiss commented on WHIRR-162:
----------------------------------
The fact is that we don't need to identify the InetAddress's delay in case when there is no reverse address. So, we may use a resonable value which also depends on the network characteristics.
I mean, it's ok this change.
> DnsUtilTest fails when offline or for slow connections
> ------------------------------------------------------
>
> Key: WHIRR-162
> URL: https://issues.apache.org/jira/browse/WHIRR-162
> Project: Whirr
> Issue Type: Bug
> Components: service/hadoop
> Reporter: Tom White
> Assignee: Andrei Savu
> Attachments: WHIRR-162.patch, WHIRR-162.patch
>
>
> Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WHIRR-162) DnsUtilTest fails when offline or for
slow connections
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White resolved WHIRR-162.
-----------------------------
Resolution: Fixed
Fix Version/s: 0.3.0
I've just committed this. Thanks Andrei!
> DnsUtilTest fails when offline or for slow connections
> ------------------------------------------------------
>
> Key: WHIRR-162
> URL: https://issues.apache.org/jira/browse/WHIRR-162
> Project: Whirr
> Issue Type: Bug
> Components: service/hadoop
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.3.0
>
> Attachments: WHIRR-162.patch, WHIRR-162.patch
>
>
> Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-162) DnsUtilTest fails when offline or for
slow connections
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-162:
------------------------------
Attachment: WHIRR-162.patch
I've set the DNS resolution timeout to 5 seconds and changed the test. Tom, let me know if it works for you on a slower connection (I'm having some problems running the integration tests).
> DnsUtilTest fails when offline or for slow connections
> ------------------------------------------------------
>
> Key: WHIRR-162
> URL: https://issues.apache.org/jira/browse/WHIRR-162
> Project: Whirr
> Issue Type: Bug
> Components: service/hadoop
> Reporter: Tom White
> Attachments: WHIRR-162.patch
>
>
> Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-162) DnsUtilTest fails when offline or for
slow connections
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972608#action_12972608 ]
Tom White commented on WHIRR-162:
---------------------------------
It's not easy to reproduce this consistently, but I've made this change locally in the past and it fixed the problem. BTW, the comment is not out of sync with the code, so you might want to update that.
Tibor - does this change look good to you?
> DnsUtilTest fails when offline or for slow connections
> ------------------------------------------------------
>
> Key: WHIRR-162
> URL: https://issues.apache.org/jira/browse/WHIRR-162
> Project: Whirr
> Issue Type: Bug
> Components: service/hadoop
> Reporter: Tom White
> Attachments: WHIRR-162.patch
>
>
> Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-162) DnsUtilTest fails when offline or for
slow connections
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974111#action_12974111 ]
Andrei Savu commented on WHIRR-162:
-----------------------------------
Great! Thanks for reviewing.
> DnsUtilTest fails when offline or for slow connections
> ------------------------------------------------------
>
> Key: WHIRR-162
> URL: https://issues.apache.org/jira/browse/WHIRR-162
> Project: Whirr
> Issue Type: Bug
> Components: service/hadoop
> Reporter: Tom White
> Assignee: Andrei Savu
> Fix For: 0.3.0
>
> Attachments: WHIRR-162.patch, WHIRR-162.patch
>
>
> Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WHIRR-162) DnsUtilTest fails when offline or for
slow connections
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrei Savu updated WHIRR-162:
------------------------------
Attachment: WHIRR-162.patch
I have fixed the comment.
> DnsUtilTest fails when offline or for slow connections
> ------------------------------------------------------
>
> Key: WHIRR-162
> URL: https://issues.apache.org/jira/browse/WHIRR-162
> Project: Whirr
> Issue Type: Bug
> Components: service/hadoop
> Reporter: Tom White
> Assignee: Andrei Savu
> Attachments: WHIRR-162.patch, WHIRR-162.patch
>
>
> Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WHIRR-162) DnsUtilTest fails when offline or for
slow connections
Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971882#action_12971882 ]
Andrei Savu commented on WHIRR-162:
-----------------------------------
+1 for making this an integration test. It fails for me on the local network (broken DNS configs at ISP). I had to disable this test in order to be able to run the entire suite.
> DnsUtilTest fails when offline or for slow connections
> ------------------------------------------------------
>
> Key: WHIRR-162
> URL: https://issues.apache.org/jira/browse/WHIRR-162
> Project: Whirr
> Issue Type: Bug
> Components: service/hadoop
> Reporter: Tom White
>
> Units tests should run when offline, so I suggest that we change this to be an integration test. Also might be worth increasing the timeouts (to 5s?) as this regularly fails for me on a slow connection.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.