You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Sebastian Schelter <ss...@apache.org> on 2013/04/13 20:07:11 UTC

Review Request: GIRAPH-630: Convergence detection broken in o.a.g.examples.PageRankVertex

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10451/
-----------------------------------------------------------

Review request for giraph.


Description
-------

Fixes erroneous handling of reusable objects, improves numerical stability


This addresses bug GIRAPH-630.
    https://issues.apache.org/jira/browse/GIRAPH-630


Diffs
-----

  giraph-examples/src/main/java/org/apache/giraph/examples/PageRankVertex.java 733ee53 
  giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkVertex.java 85c6e27 
  giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkVertexMasterCompute.java PRE-CREATION 
  giraph-examples/src/test/java/org/apache/giraph/examples/PageRankVertexTest.java 2e4bbc4 
  giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java a3dbd45 

Diff: https://reviews.apache.org/r/10451/diff/


Testing
-------

Passed local unit tests, will test on cluster tomorrow


Thanks,

Sebastian Schelter


Re: Review Request: GIRAPH-630: Convergence detection broken in o.a.g.examples.PageRankVertex

Posted by Sebastian Schelter <ss...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10451/
-----------------------------------------------------------

(Updated April 13, 2013, 6:36 p.m.)


Review request for giraph.


Description
-------

Fixes erroneous handling of reusable objects, improves numerical stability


This addresses bug GIRAPH-630.
    https://issues.apache.org/jira/browse/GIRAPH-630


Diffs
-----

  giraph-examples/src/main/java/org/apache/giraph/examples/PageRankVertex.java 733ee53 
  giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkVertex.java 85c6e27 
  giraph-examples/src/main/java/org/apache/giraph/examples/RandomWalkVertexMasterCompute.java PRE-CREATION 
  giraph-examples/src/test/java/org/apache/giraph/examples/PageRankVertexTest.java 2e4bbc4 
  giraph-examples/src/test/java/org/apache/giraph/examples/RandomWalkWithRestartVertexTest.java a3dbd45 

Diff: https://reviews.apache.org/r/10451/diff/


Testing (updated)
-------

Passed local unit tests, successfully tested on a cluster of 26 machines with the webbase2001 dataset http://law.di.unimi.it/webdata/webbase-2001/


Thanks,

Sebastian Schelter