You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/04/28 18:36:17 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #2530: Test class component, test bean language
ppalaga opened a new pull request #2530:
URL: https://github.com/apache/camel-quarkus/pull/2530
Fix #2361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #2530: Test class component, test bean language
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2530:
URL: https://github.com/apache/camel-quarkus/pull/2530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger edited a comment on pull request #2530: Test class component, test bean language
Posted by GitBox <gi...@apache.org>.
aldettinger edited a comment on pull request #2530:
URL: https://github.com/apache/camel-quarkus/pull/2530#issuecomment-828740609
That's nice addition. Would the case with [non registry bean test](https://camel.apache.org/components/latest/languages/bean-language.html#BeanLanguage-Non-RegistryBeans) involves some quarkus or graal specifics ? I mean not tested in camel 3 test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #2530: Test class component, test bean language
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #2530:
URL: https://github.com/apache/camel-quarkus/pull/2530#discussion_r622500130
##########
File path: integration-tests/bean/src/main/java/org/apache/camel/quarkus/component/bean/method/EmployeeServiceBean.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.bean.method;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Named;
+
+import io.quarkus.arc.Unremovable;
+import org.apache.camel.quarkus.component.bean.model.Employee;
+
+@ApplicationScoped
+@Named("EmployeeServiceBean")
+@Unremovable
Review comment:
It may be caught by native tests actually. I've seen `org.apache.camel.component.bean.MethodNotFoundException: Method with name: toFirstName not found on bean` on bean native tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #2530: Test class component, test bean language
Posted by GitBox <gi...@apache.org>.
aldettinger commented on a change in pull request #2530:
URL: https://github.com/apache/camel-quarkus/pull/2530#discussion_r622497151
##########
File path: integration-tests/bean/src/main/java/org/apache/camel/quarkus/component/bean/method/EmployeeServiceBean.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.bean.method;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Named;
+
+import io.quarkus.arc.Unremovable;
+import org.apache.camel.quarkus.component.bean.model.Employee;
+
+@ApplicationScoped
+@Named("EmployeeServiceBean")
+@Unremovable
Review comment:
Strange, I would have thought that this class would need @RegisterForReflection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on pull request #2530: Test class component, test bean language
Posted by GitBox <gi...@apache.org>.
aldettinger commented on pull request #2530:
URL: https://github.com/apache/camel-quarkus/pull/2530#issuecomment-828740609
That's nice addition. Would it be interesting to complete with [a non registry bean test](https://camel.apache.org/components/latest/languages/bean-language.html#BeanLanguage-Non-RegistryBeans) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2530: Test class component, test bean language
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2530:
URL: https://github.com/apache/camel-quarkus/pull/2530#issuecomment-829110045
> That's nice addition. Would the case with [non registry bean test](https://camel.apache.org/components/latest/languages/bean-language.html#BeanLanguage-Non-RegistryBeans) involves some quarkus or graal specifics ? I mean not tested in camel 3 test.
Indeed, makes sense. When I was fast-reading it yesterday I concluded it is only for Spring which it is clearly not. Thanks for suggesting it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2530: Test class component, test bean language
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2530:
URL: https://github.com/apache/camel-quarkus/pull/2530#discussion_r622893928
##########
File path: integration-tests/bean/src/main/java/org/apache/camel/quarkus/component/bean/method/EmployeeServiceBean.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.bean.method;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Named;
+
+import io.quarkus.arc.Unremovable;
+import org.apache.camel.quarkus.component.bean.model.Employee;
+
+@ApplicationScoped
+@Named("EmployeeServiceBean")
+@Unremovable
Review comment:
Yep, `@RegisterForReflection` is required for both method language and class component. I have sent this PR blindly thinking they are perhaps not required. Now I know they are :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2530: Test class component, test bean language
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2530:
URL: https://github.com/apache/camel-quarkus/pull/2530#issuecomment-829110715
a6580c3 : implemented suggestions by @aldettinger
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org