[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3087: fix(sec): upgrade org.apache.hive:hive-exec to 3.1.3

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #3087:
URL: https://github.com/apache/incubator-seatunnel/pull/3087#discussion_r994612076


##########
seatunnel-connectors-v2/connector-hudi/pom.xml:
##########
@@ -29,7 +26,7 @@
 
     <artifactId>connector-hudi</artifactId>
     <properties>
-        <hive.exec.version>2.3.9</hive.exec.version>
+        <hive.exec.version>3.1.3</hive.exec.version>

Review Comment:
   same as above.



##########
seatunnel-connectors-v2/connector-hive/pom.xml:
##########
@@ -30,7 +27,7 @@
     <artifactId>connector-hive</artifactId>
     
     <properties>
-        <hive.exec.version>2.3.9</hive.exec.version>
+        <hive.exec.version>3.1.3</hive.exec.version>

Review Comment:
   You need add test case to ensure whether hive `3.1.3` can used in all of `hive 2.x` and `hive 3.x` environment . This means you should test:
   1. run hive connector in a spark and flink docker container which integrate hive2.x.
   2. run hive connector in a spark and flink docker container which integrate hive3.x.
   
   If `hive 3.1.3` can run fine in all of `hive 2.x` and `hive 3.x` environment, you need update the document of the hive connector tell user it support hive2.x and hive3.x.
   
   If `hive 3.1.3` can only run fine in `hive 3.x` environment and can not run in `hive2.x` environment, you can create a connector named `connector-hive3`.



##########
seatunnel-connectors-v2/connector-iceberg/pom.xml:
##########
@@ -33,7 +30,7 @@
         <iceberg.version>0.14.0</iceberg.version>
         <parquet-avro.version>1.12.3</parquet-avro.version>
         <avro.version>1.10.2</avro.version>
-        <hive.version>2.3.9</hive.version>
+        <hive.version>3.1.3</hive.version>

Review Comment:
   same as above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org