You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Mike Drob <md...@mdrob.com> on 2014/07/10 16:07:26 UTC
Review Request 23393: ACCUMULO-2423 Clean up (most?) shell scripts
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/
-----------------------------------------------------------
Review request for accumulo and Alex Moundalexis.
Bugs: ACCUMULO-2423
https://issues.apache.org/jira/browse/ACCUMULO-2423
Repository: accumulo
Description
-------
ACCUMULO-2423 Clean up (most?) shell scripts
Standardize interpreter line on '#! /usr/bin/env foo'
Replace `..` with $(..)
Replace [..] with [[..]]
Replace = with == in [[..]]
Replace arithmetic [[..]] with ((..))
Remove useless invocations of echo
Add some double quotes to prevent word splitting
Diffs
-----
assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
Diff: https://reviews.apache.org/r/23393/diff/
Testing
-------
Thanks,
Mike Drob
Re: Review Request 23393: ACCUMULO-2423 Clean up (most?) shell scripts
Posted by Christopher Tubbs <ct...@apache.org>.
> On July 10, 2014, 12:11 p.m., Bill Havanki wrote:
> > test/system/continuous/start-agitator.sh, line 37
> > <https://reviews.apache.org/r/23393/diff/1/?file=627724#file627724line37>
> >
> > How about just running whoami once and saving the result, to avoid repeated calls out of the shell?
The following would prevent any unnecessary whoami processes.
[[ -n $USER ]] || USER=$(whoami)
- Christopher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47572
-----------------------------------------------------------
On July 10, 2014, 10:07 a.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 10:07 a.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up (most?) shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add some double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Bill Havanki <bh...@clouderagovt.com>.
> On July 10, 2014, 12:11 p.m., Bill Havanki wrote:
> > test/system/continuous/start-stats.sh, line 35
> > <https://reviews.apache.org/r/23393/diff/1/?file=627728#file627728line35>
> >
> > Quote the right side
>
> Mike Drob wrote:
> I thought assignment didn't need quoting?
>
> Christopher Tubbs wrote:
> It doesn't. See:
>
> a='b'
> b=' c'
> c=$a/$b
> echo $c
>
> However, you may need {} if the identifier is ambiguous. Example:
>
> a='b'
> b=' c'
> c=$a_$b
> echo $c
> c=${a}_$b
> echo $c
Oh duh, yes. Never mind. (Responded hours ago, but forgot to hit Publish. Again.)
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47572
-----------------------------------------------------------
On July 10, 2014, 4:04 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 4:04 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> assemble/conf/templates/accumulo-env.sh e136a3f41a86ad710e1f93f15dc1dfadf3a4de03
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
> test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
> test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
> test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
> test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
> test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
> test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
> test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up (most?) shell scripts
Posted by Mike Drob <md...@mdrob.com>.
> On July 10, 2014, 4:11 p.m., Bill Havanki wrote:
> > test/system/continuous/start-stats.sh, line 35
> > <https://reviews.apache.org/r/23393/diff/1/?file=627728#file627728line35>
> >
> > Quote the right side
I thought assignment didn't need quoting?
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47572
-----------------------------------------------------------
On July 10, 2014, 2:07 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 2:07 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up (most?) shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add some double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Christopher Tubbs <ct...@apache.org>.
> On July 10, 2014, 12:11 p.m., Bill Havanki wrote:
> > test/system/continuous/start-stats.sh, line 35
> > <https://reviews.apache.org/r/23393/diff/1/?file=627728#file627728line35>
> >
> > Quote the right side
>
> Mike Drob wrote:
> I thought assignment didn't need quoting?
It doesn't. See:
a='b'
b=' c'
c=$a/$b
echo $c
However, you may need {} if the identifier is ambiguous. Example:
a='b'
b=' c'
c=$a_$b
echo $c
c=${a}_$b
echo $c
- Christopher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47572
-----------------------------------------------------------
On July 10, 2014, 3:11 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 3:11 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> assemble/conf/templates/accumulo-env.sh e136a3f41a86ad710e1f93f15dc1dfadf3a4de03
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
> test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
> test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
> test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
> test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
> test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
> test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
> test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up (most?) shell scripts
Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47572
-----------------------------------------------------------
assemble/bin/start-server.sh
<https://reviews.apache.org/r/23393/#comment83610>
The two tests here could be combined, i.e., put the && inside the [[ ]].
assemble/bin/stop-server.sh
<https://reviews.apache.org/r/23393/#comment83611>
arithmetic
assemble/bin/stop-server.sh
<https://reviews.apache.org/r/23393/#comment83613>
Could use -n instead of ! -z.
test/system/continuous/start-agitator.sh
<https://reviews.apache.org/r/23393/#comment83615>
How about just running whoami once and saving the result, to avoid repeated calls out of the shell?
test/system/continuous/start-stats.sh
<https://reviews.apache.org/r/23393/#comment83617>
Quote the right side
test/system/continuous/start-stats.sh
<https://reviews.apache.org/r/23393/#comment83618>
Quotes around the log file names?
test/system/continuous/stop-agitator.sh
<https://reviews.apache.org/r/23393/#comment83619>
As above, maybe just run whoami once.
test/system/upgrade_test.sh
<https://reviews.apache.org/r/23393/#comment83614>
Maybe quote "$PREV/bin/accumulo" in case $PREV has spaces.
- Bill Havanki
On July 10, 2014, 10:07 a.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 10:07 a.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up (most?) shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add some double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Christopher Tubbs <ct...@apache.org>.
> On July 10, 2014, 11:16 a.m., Christopher Tubbs wrote:
> > assemble/bin/bootstrap_hdfs.sh, line 81
> > <https://reviews.apache.org/r/23393/diff/1/?file=627707#file627707line81>
> >
> > Should probably
> > s/cat/grep -v '^#'/
> >
> > and double-quote the arg (if necessary, as is seems to be done elsewhere)
>
> Mike Drob wrote:
> I'd like to handle that in a follow on issue.
Works for me.
> On July 10, 2014, 11:16 a.m., Christopher Tubbs wrote:
> > assemble/bin/build_native_library.sh, line 20
> > <https://reviews.apache.org/r/23393/diff/1/?file=627708#file627708line20>
> >
> > Don't need to quote bash vars in [[ ]]
>
> Mike Drob wrote:
> While this is true, extra quoting never hurts so I'm inclined to leave it.
That's fine with me, but you're forcing bash to evaluate it after it has first expanded the string expression, instead of directly comparing against the value of the variable. I was under the impression that was the main optimization between single braces [ ] and double [[ ]], and one of the biggest reasons to make this kind of switch.
> On July 10, 2014, 11:16 a.m., Christopher Tubbs wrote:
> > assemble/bin/build_native_library.sh, line 59
> > <https://reviews.apache.org/r/23393/diff/1/?file=627708#file627708line59>
> >
> > Don't need to quote assignments.
>
> Mike Drob wrote:
> $@ is an array, and thus needs to be quoted.
I did some quick testing and it did not seem like it made a difference.
> On July 10, 2014, 11:16 a.m., Christopher Tubbs wrote:
> > assemble/bin/start-all.sh, line 67
> > <https://reviews.apache.org/r/23393/diff/1/?file=627710#file627710line67>
> >
> > not sure it's necessary to grep -v blank lines like this, since they shouldn't show up as elements of the list. I believe a grep -v '^#' is sufficient (and less confusing). This should be verified and applied consistently in the other scripts that cat/grep these files.
>
> Mike Drob wrote:
> No, it's necessary because there could be a blank line in the file.
>
> Christopher Tubbs wrote:
> Doesn't matter. for loops split on all space and don't iterate over empty results. That is, unless you change IFS to make it split only on newlines (e.g. IFS=$'\n'; for x in $(); do ...; done)
>
> Mike Drob wrote:
> shellcheck warns:
>
> for f in $(grep -v '^#' "$ACCUMULO_CONF_DIR/slaves")
> ^-- SC2013: To read lines rather than words, pipe/redirect to a 'while read' loop.
>
> I think we can leave it for a follow-on issue.
I'm surprised it's not making those complaints about cat also. Either way, I think you'd have to modify IFS to deal with this properly. (otherwise, we're essentially saying that it's okay to put extra hosts on the same line, space-separated.
- Christopher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47566
-----------------------------------------------------------
On July 10, 2014, 4:04 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 4:04 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> assemble/conf/templates/accumulo-env.sh e136a3f41a86ad710e1f93f15dc1dfadf3a4de03
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
> test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
> test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
> test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
> test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
> test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
> test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
> test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Mike Drob <md...@mdrob.com>.
> On July 10, 2014, 3:16 p.m., Christopher Tubbs wrote:
> > assemble/bin/start-all.sh, line 67
> > <https://reviews.apache.org/r/23393/diff/1/?file=627710#file627710line67>
> >
> > not sure it's necessary to grep -v blank lines like this, since they shouldn't show up as elements of the list. I believe a grep -v '^#' is sufficient (and less confusing). This should be verified and applied consistently in the other scripts that cat/grep these files.
>
> Mike Drob wrote:
> No, it's necessary because there could be a blank line in the file.
>
> Christopher Tubbs wrote:
> Doesn't matter. for loops split on all space and don't iterate over empty results. That is, unless you change IFS to make it split only on newlines (e.g. IFS=$'\n'; for x in $(); do ...; done)
>
> Mike Drob wrote:
> shellcheck warns:
>
> for f in $(grep -v '^#' "$ACCUMULO_CONF_DIR/slaves")
> ^-- SC2013: To read lines rather than words, pipe/redirect to a 'while read' loop.
>
> I think we can leave it for a follow-on issue.
>
> Christopher Tubbs wrote:
> I'm surprised it's not making those complaints about cat also. Either way, I think you'd have to modify IFS to deal with this properly. (otherwise, we're essentially saying that it's okay to put extra hosts on the same line, space-separated.
Filed as ACCUMULO-2987
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47566
-----------------------------------------------------------
On July 10, 2014, 8:04 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 8:04 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> assemble/conf/templates/accumulo-env.sh e136a3f41a86ad710e1f93f15dc1dfadf3a4de03
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
> test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
> test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
> test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
> test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
> test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
> test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
> test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Christopher Tubbs <ct...@apache.org>.
> On July 10, 2014, 11:16 a.m., Christopher Tubbs wrote:
> > test/system/upgrade_test.sh, line 19
> > <https://reviews.apache.org/r/23393/diff/1/?file=627743#file627743line19>
> >
> > Not sure I agree it makes sense to do arithmetic syntax for conditionals. We don't want a numerical result, we want an evaluation to true or false. While this probably achieves the same, it's harder to read. Conditionals should probably use [[ ]]. I noticed this elsewhere also. Might want to go back and check.
>
> Mike Drob wrote:
> I don't understand the rationale behind the suggestion here.
== and != are conditional operators, not arithmetic operators. (( )) are for arithmetic expressions, not conditional expressions. Additionally, the use of $ sign in arithmetic expressions is incorrect.
Example:
a='b'
b=5
echo $(( $a + 1 )) # result is 6, because this evaluates to "b + 1", which is 6.
So, use (( )) for arithmetic expressions and [[ ]] for conditionals. != is a conditional.
- Christopher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47566
-----------------------------------------------------------
On July 10, 2014, 2:49 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 2:49 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
> test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
> test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
> test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
> test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
> test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
> test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
> test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Mike Drob <md...@mdrob.com>.
> On July 10, 2014, 3:16 p.m., Christopher Tubbs wrote:
> > assemble/bin/start-all.sh, line 67
> > <https://reviews.apache.org/r/23393/diff/1/?file=627710#file627710line67>
> >
> > not sure it's necessary to grep -v blank lines like this, since they shouldn't show up as elements of the list. I believe a grep -v '^#' is sufficient (and less confusing). This should be verified and applied consistently in the other scripts that cat/grep these files.
>
> Mike Drob wrote:
> No, it's necessary because there could be a blank line in the file.
>
> Christopher Tubbs wrote:
> Doesn't matter. for loops split on all space and don't iterate over empty results. That is, unless you change IFS to make it split only on newlines (e.g. IFS=$'\n'; for x in $(); do ...; done)
shellcheck warns:
for f in $(grep -v '^#' "$ACCUMULO_CONF_DIR/slaves")
^-- SC2013: To read lines rather than words, pipe/redirect to a 'while read' loop.
I think we can leave it for a follow-on issue.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47566
-----------------------------------------------------------
On July 10, 2014, 6:49 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 6:49 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
> test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
> test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
> test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
> test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
> test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
> test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
> test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up (most?) shell scripts
Posted by Mike Drob <md...@mdrob.com>.
> On July 10, 2014, 3:16 p.m., Christopher Tubbs wrote:
> > assemble/bin/bootstrap_hdfs.sh, line 81
> > <https://reviews.apache.org/r/23393/diff/1/?file=627707#file627707line81>
> >
> > Should probably
> > s/cat/grep -v '^#'/
> >
> > and double-quote the arg (if necessary, as is seems to be done elsewhere)
I'd like to handle that in a follow on issue.
> On July 10, 2014, 3:16 p.m., Christopher Tubbs wrote:
> > assemble/bin/bootstrap_hdfs.sh, line 83
> > <https://reviews.apache.org/r/23393/diff/1/?file=627707#file627707line83>
> >
> > dirname arg in bin/accumulo was quoted. Should these args also be quoted?
Yep.
> On July 10, 2014, 3:16 p.m., Christopher Tubbs wrote:
> > assemble/bin/build_native_library.sh, line 20
> > <https://reviews.apache.org/r/23393/diff/1/?file=627708#file627708line20>
> >
> > Don't need to quote bash vars in [[ ]]
While this is true, extra quoting never hurts so I'm inclined to leave it.
> On July 10, 2014, 3:16 p.m., Christopher Tubbs wrote:
> > assemble/bin/start-all.sh, line 67
> > <https://reviews.apache.org/r/23393/diff/1/?file=627710#file627710line67>
> >
> > not sure it's necessary to grep -v blank lines like this, since they shouldn't show up as elements of the list. I believe a grep -v '^#' is sufficient (and less confusing). This should be verified and applied consistently in the other scripts that cat/grep these files.
No, it's necessary because there could be a blank line in the file.
> On July 10, 2014, 3:16 p.m., Christopher Tubbs wrote:
> > assemble/bin/stop-all.sh, line 48
> > <https://reviews.apache.org/r/23393/diff/1/?file=627712#file627712line48>
> >
> > more grep filtering inconsistency on host files
Follow on issue, see above.
> On July 10, 2014, 3:16 p.m., Christopher Tubbs wrote:
> > test/system/upgrade_test.sh, line 19
> > <https://reviews.apache.org/r/23393/diff/1/?file=627743#file627743line19>
> >
> > Not sure I agree it makes sense to do arithmetic syntax for conditionals. We don't want a numerical result, we want an evaluation to true or false. While this probably achieves the same, it's harder to read. Conditionals should probably use [[ ]]. I noticed this elsewhere also. Might want to go back and check.
I don't understand the rationale behind the suggestion here.
> On July 10, 2014, 3:16 p.m., Christopher Tubbs wrote:
> > assemble/bin/build_native_library.sh, line 59
> > <https://reviews.apache.org/r/23393/diff/1/?file=627708#file627708line59>
> >
> > Don't need to quote assignments.
$@ is an array, and thus needs to be quoted.
> On July 10, 2014, 3:16 p.m., Christopher Tubbs wrote:
> > assemble/bin/accumulo, lines 32-36
> > <https://reviews.apache.org/r/23393/diff/1/?file=627706#file627706line32>
> >
> > This part can probably be removed since ACCUMULO-2606 happened, but it doesn't matter that much.
Killed it.
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47566
-----------------------------------------------------------
On July 10, 2014, 2:07 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 2:07 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up (most?) shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add some double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up (most?) shell scripts
Posted by Christopher Tubbs <ct...@apache.org>.
> On July 10, 2014, 11:16 a.m., Christopher Tubbs wrote:
> > assemble/bin/start-all.sh, line 67
> > <https://reviews.apache.org/r/23393/diff/1/?file=627710#file627710line67>
> >
> > not sure it's necessary to grep -v blank lines like this, since they shouldn't show up as elements of the list. I believe a grep -v '^#' is sufficient (and less confusing). This should be verified and applied consistently in the other scripts that cat/grep these files.
>
> Mike Drob wrote:
> No, it's necessary because there could be a blank line in the file.
Doesn't matter. for loops split on all space and don't iterate over empty results. That is, unless you change IFS to make it split only on newlines (e.g. IFS=$'\n'; for x in $(); do ...; done)
- Christopher
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47566
-----------------------------------------------------------
On July 10, 2014, 10:07 a.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 10:07 a.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up (most?) shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add some double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up (most?) shell scripts
Posted by Christopher Tubbs <ct...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47566
-----------------------------------------------------------
Overall, the patch is moving in a good direction, but there's still a lot of inconsistencies. In particular, the use of quoting for args that could contain spaces, the use of grep v. cat v. egrep to read hosts files, and extra quotes in assignments.
assemble/bin/accumulo
<https://reviews.apache.org/r/23393/#comment83573>
This part can probably be removed since ACCUMULO-2606 happened, but it doesn't matter that much.
assemble/bin/bootstrap_hdfs.sh
<https://reviews.apache.org/r/23393/#comment83574>
Should probably
s/cat/grep -v '^#'/
and double-quote the arg (if necessary, as is seems to be done elsewhere)
assemble/bin/bootstrap_hdfs.sh
<https://reviews.apache.org/r/23393/#comment83575>
dirname arg in bin/accumulo was quoted. Should these args also be quoted?
assemble/bin/build_native_library.sh
<https://reviews.apache.org/r/23393/#comment83576>
Don't need to quote bash vars in [[ ]]
assemble/bin/build_native_library.sh
<https://reviews.apache.org/r/23393/#comment83577>
unnecessary outer quote. bin=$() is sufficient
assemble/bin/build_native_library.sh
<https://reviews.apache.org/r/23393/#comment83578>
Don't need to quote assignments.
assemble/bin/config.sh
<https://reviews.apache.org/r/23393/#comment83579>
More assignment quotes not needed. (there's probably more, but I'll stop checking at this one)
assemble/bin/config.sh
<https://reviews.apache.org/r/23393/#comment83580>
quote dirname args?
assemble/bin/start-all.sh
<https://reviews.apache.org/r/23393/#comment83581>
not sure it's necessary to grep -v blank lines like this, since they shouldn't show up as elements of the list. I believe a grep -v '^#' is sufficient (and less confusing). This should be verified and applied consistently in the other scripts that cat/grep these files.
assemble/bin/start-server.sh
<https://reviews.apache.org/r/23393/#comment83582>
I'm partial to the more succinct:
[[ -x $IFCONFIG ]] && IFCONFIG='/bin/netstat -ie' || IFCONFIG=/sbin/ifconfig
There's other places where this could be done also (LONGNAME above, for instance).
I don't feel strongly about this, but if we're going for consistency, it might be good to be consistently succinct also.
assemble/bin/start-server.sh
<https://reviews.apache.org/r/23393/#comment83583>
Drop the braces on the variables. They aren't needed in the [[ ]] block. There's no ambiguity here.
assemble/bin/start-server.sh
<https://reviews.apache.org/r/23393/#comment83584>
unneeded quotes on bash vars in block
assemble/bin/stop-all.sh
<https://reviews.apache.org/r/23393/#comment83586>
more grep filtering inconsistency on host files
assemble/bin/stop-server.sh
<https://reviews.apache.org/r/23393/#comment83587>
missed conversion from [] to [[]]
core/src/main/scripts/generate-protobuf.sh
<https://reviews.apache.org/r/23393/#comment83589>
might as well drop trailing whitespace before committing
test/system/randomwalk/bin/reset-cluster.sh
<https://reviews.apache.org/r/23393/#comment83597>
Use -z
test/system/randomwalk/bin/start-all.sh
<https://reviews.apache.org/r/23393/#comment83598>
Use -z
test/system/upgrade_test.sh
<https://reviews.apache.org/r/23393/#comment83591>
Not sure I agree it makes sense to do arithmetic syntax for conditionals. We don't want a numerical result, we want an evaluation to true or false. While this probably achieves the same, it's harder to read. Conditionals should probably use [[ ]]. I noticed this elsewhere also. Might want to go back and check.
test/system/upgrade_test.sh
<https://reviews.apache.org/r/23393/#comment83593>
It's probably good practice to use single quotes for string literals when they don't contain embedded variables.
- Christopher Tubbs
On July 10, 2014, 10:07 a.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 10:07 a.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up (most?) shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add some double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Alex Moundalexis <al...@clouderagovt.com>.
> On July 16, 2014, 1:11 p.m., Alex Moundalexis wrote:
> > assemble/bin/stop-here.sh, line 42
> > <https://reviews.apache.org/r/23393/diff/4/?file=628031#file628031line42>
> >
> > prefer egrep -q '(localhost|127.0.0.1)' rather than escaping the pipe
>
> Mike Drob wrote:
> parenthesis are necessary?
On OS X they appear to be, plus it's more clear what's being done.
> On July 16, 2014, 1:11 p.m., Alex Moundalexis wrote:
> > assemble/bin/config.sh, lines 82-85
> > <https://reviews.apache.org/r/23393/diff/4/?file=628025#file628025line82>
> >
> > Presume the goal here is to echo literal $ACCUMULO_HOME...
>
> Mike Drob wrote:
> Yes.
Good to go, then.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47875
-----------------------------------------------------------
On July 10, 2014, 8:04 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 8:04 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> assemble/conf/templates/accumulo-env.sh e136a3f41a86ad710e1f93f15dc1dfadf3a4de03
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
> test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
> test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
> test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
> test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
> test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
> test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
> test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Mike Drob <md...@mdrob.com>.
> On July 16, 2014, 1:11 p.m., Alex Moundalexis wrote:
> > assemble/bin/config.sh, lines 82-85
> > <https://reviews.apache.org/r/23393/diff/4/?file=628025#file628025line82>
> >
> > Presume the goal here is to echo literal $ACCUMULO_HOME...
Yes.
> On July 16, 2014, 1:11 p.m., Alex Moundalexis wrote:
> > assemble/bin/tup.sh, line 38
> > <https://reviews.apache.org/r/23393/diff/4/?file=628034#file628034line38>
> >
> > not sure of origins, but 42 would be more amusing
Some value of parallelism, probably determined expiramentally years ago. This script might be a candidate for removal entirely.
> On July 16, 2014, 1:11 p.m., Alex Moundalexis wrote:
> > assemble/bin/stop-here.sh, line 42
> > <https://reviews.apache.org/r/23393/diff/4/?file=628031#file628031line42>
> >
> > prefer egrep -q '(localhost|127.0.0.1)' rather than escaping the pipe
parenthesis are necessary?
- Mike
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47875
-----------------------------------------------------------
On July 10, 2014, 8:04 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 8:04 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> assemble/conf/templates/accumulo-env.sh e136a3f41a86ad710e1f93f15dc1dfadf3a4de03
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
> test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
> test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
> test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
> test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
> test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
> test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
> test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Alex Moundalexis <al...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/#review47875
-----------------------------------------------------------
assemble/bin/config.sh
<https://reviews.apache.org/r/23393/#comment84105>
Presume the goal here is to echo literal $ACCUMULO_HOME...
assemble/bin/stop-here.sh
<https://reviews.apache.org/r/23393/#comment84106>
prefer egrep -q '(localhost|127.0.0.1)' rather than escaping the pipe
assemble/bin/stop-server.sh
<https://reviews.apache.org/r/23393/#comment84108>
should be able to consolidate some of the simple negations: egrep -v '(grep|ssh|etc)'
assemble/bin/tup.sh
<https://reviews.apache.org/r/23393/#comment84109>
not sure of origins, but 42 would be more amusing
- Alex Moundalexis
On July 10, 2014, 8:04 p.m., Mike Drob wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23393/
> -----------------------------------------------------------
>
> (Updated July 10, 2014, 8:04 p.m.)
>
>
> Review request for accumulo and Alex Moundalexis.
>
>
> Bugs: ACCUMULO-2423
> https://issues.apache.org/jira/browse/ACCUMULO-2423
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> ACCUMULO-2423 Clean up shell scripts
>
> Standardize interpreter line on '#! /usr/bin/env foo'
> Replace `..` with $(..)
> Replace [..] with [[..]]
> Replace = with == in [[..]]
> Replace arithmetic [[..]] with ((..))
> Remove useless invocations of echo
> Add double quotes to prevent word splitting
>
>
> Diffs
> -----
>
> assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
> assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
> assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
> assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
> assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
> assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
> assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
> assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
> assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
> assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
> assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
> assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
> assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
> assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
> assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
> assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
> assemble/conf/templates/accumulo-env.sh e136a3f41a86ad710e1f93f15dc1dfadf3a4de03
> core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
> core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
> proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
> start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
> test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
> test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
> test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
> test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
> test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
> test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
> test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
> test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
> test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
> test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
> test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
> test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
> test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
> test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
> test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
> test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
> test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
> test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
> test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
> test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
> test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
> test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
> test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
> test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
> test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
> test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
> test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
> test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
> test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
> test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
> test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
> test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
>
> Diff: https://reviews.apache.org/r/23393/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Drob
>
>
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Mike Drob <md...@mdrob.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/
-----------------------------------------------------------
(Updated July 10, 2014, 8:04 p.m.)
Review request for accumulo and Alex Moundalexis.
Bugs: ACCUMULO-2423
https://issues.apache.org/jira/browse/ACCUMULO-2423
Repository: accumulo
Description
-------
ACCUMULO-2423 Clean up shell scripts
Standardize interpreter line on '#! /usr/bin/env foo'
Replace `..` with $(..)
Replace [..] with [[..]]
Replace = with == in [[..]]
Replace arithmetic [[..]] with ((..))
Remove useless invocations of echo
Add double quotes to prevent word splitting
Diffs (updated)
-----
assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
assemble/conf/templates/accumulo-env.sh e136a3f41a86ad710e1f93f15dc1dfadf3a4de03
core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
Diff: https://reviews.apache.org/r/23393/diff/
Testing
-------
Thanks,
Mike Drob
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Mike Drob <md...@mdrob.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/
-----------------------------------------------------------
(Updated July 10, 2014, 7:11 p.m.)
Review request for accumulo and Alex Moundalexis.
Bugs: ACCUMULO-2423
https://issues.apache.org/jira/browse/ACCUMULO-2423
Repository: accumulo
Description
-------
ACCUMULO-2423 Clean up shell scripts
Standardize interpreter line on '#! /usr/bin/env foo'
Replace `..` with $(..)
Replace [..] with [[..]]
Replace = with == in [[..]]
Replace arithmetic [[..]] with ((..))
Remove useless invocations of echo
Add double quotes to prevent word splitting
Diffs (updated)
-----
assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
assemble/conf/templates/accumulo-env.sh e136a3f41a86ad710e1f93f15dc1dfadf3a4de03
core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
Diff: https://reviews.apache.org/r/23393/diff/
Testing
-------
Thanks,
Mike Drob
Re: Review Request 23393: ACCUMULO-2423 Clean up shell scripts
Posted by Mike Drob <md...@mdrob.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23393/
-----------------------------------------------------------
(Updated July 10, 2014, 6:49 p.m.)
Review request for accumulo and Alex Moundalexis.
Summary (updated)
-----------------
ACCUMULO-2423 Clean up shell scripts
Bugs: ACCUMULO-2423
https://issues.apache.org/jira/browse/ACCUMULO-2423
Repository: accumulo
Description (updated)
-------
ACCUMULO-2423 Clean up shell scripts
Standardize interpreter line on '#! /usr/bin/env foo'
Replace `..` with $(..)
Replace [..] with [[..]]
Replace = with == in [[..]]
Replace arithmetic [[..]] with ((..))
Remove useless invocations of echo
Add double quotes to prevent word splitting
Diffs (updated)
-----
assemble/bin/LogForwarder.sh 5fe7871fc4b8b6aab9dbfc0227aa2e36f4a43aba
assemble/bin/accumulo bdd742d7aee81dc82872acee1b4333ee6e8348c7
assemble/bin/bootstrap_config.sh fb643daf2f98f325bf041a3f75e179df74dfef59
assemble/bin/bootstrap_hdfs.sh 6f38f633f4789ac7bc09639eeee58495ee4c3ea2
assemble/bin/build_native_library.sh 907ce2c946ba1b6c4ddcc889011f899fc1d96575
assemble/bin/config.sh 76634731abd2e51dc924804f76c1b73a9f5086d6
assemble/bin/generate_monitor_certificate.sh edd415912bb0c67e203236122f5117fad88bf34e
assemble/bin/start-all.sh b71ba705889f6c157194ae4a816f8e21e9377b8b
assemble/bin/start-here.sh 9abdb387273c7e7fed24928da7ba11183e4f5986
assemble/bin/start-server.sh 62ad91d57731d7e32b3ce6e51a961b11c64bf163
assemble/bin/stop-all.sh 3bd30bd758a9226d7e1e8e0b66cd36704e052d0e
assemble/bin/stop-here.sh 4d5533acc6b4b4fc4aadde97ae95906ece347492
assemble/bin/stop-server.sh 6fbe0afde2b881cb7ded6b66d6fcaad35102d7cd
assemble/bin/tool.sh 8126b3b1a5753a395a21f47fe7849de79af05135
assemble/bin/tup.sh b26def5790cf322cbd203fd53faa337d3cec617d
assemble/build.sh 5f65419dcff6120dc6e7ca46905420936b439953
core/src/main/scripts/generate-protobuf.sh 9a3b08a34b4eed50b74bf502de1bc64daa80418a
core/src/main/scripts/generate-thrift.sh ee51b11a921205e6164bf6c5303d874fd4278ee4
proxy/examples/python/TestClient.py 5509ded0946a16455eea8b570a96a71ba15d4ebf
start/src/test/shell/makeTestJars.sh 13018b1973fbddf1b8885f156d0c6d7196574d14
test/src/test/scripts/run-test.sh 02a5090e622fdd22b0239cd4a48117067878f94c
test/system/continuous/analyze-missing.sh 62ad15b6e7a6a1fe5b707e9f3eced64763b002c1
test/system/continuous/continuous-env.sh.example d3fdd62768afafc496d4e94ecadfe26c0dc84454
test/system/continuous/mapred-setup.sh e6bd2caa8cb2557c23b17740f89102482f4300b0
test/system/continuous/run-moru.sh 3133b0518c9153c14d8cb1a8e78adc7ab1dc0333
test/system/continuous/run-verify.sh 72ecc14fecf18ab8e8f14c8e2420e8f0102701f3
test/system/continuous/start-agitator.sh e82e5ab66866122161a0b6e1be132114b42e94da
test/system/continuous/start-batchwalkers.sh b3dd7becf677b28d81349f3622cb18d612d786d0
test/system/continuous/start-ingest.sh 468482935dcddf63a87b23f2695c0b6c057f3ffb
test/system/continuous/start-scanners.sh 63b7fb318ddb3ae9d1c396bee493083f6403d1b1
test/system/continuous/start-stats.sh a9013c44f942eaf3bc54096059b02ae9dfe6e503
test/system/continuous/start-walkers.sh 32fbd515b71a75f6ebb36e437be8babe1c3a1504
test/system/continuous/stop-agitator.sh 136b451f2303b5900cdfd746956752ff4d96fa54
test/system/continuous/stop-batchwalkers.sh 0250656291572bbb9c10faa15bcee6872aada587
test/system/continuous/stop-ingest.sh 15f1715ebfc128a825ae65abf8262f5af6abd442
test/system/continuous/stop-scanners.sh 8b1852b39df4dad803ee9c04ac8a08699e06d83c
test/system/continuous/stop-stats.sh a806f2d30e13bae929678318b075a1899f8cef26
test/system/continuous/stop-walkers.sh 7e759698833e04b54592ad201c702cdfe3df10a8
test/system/randomwalk/bin/apocalypse.sh 899256c8521bd7c319533ed8fd24676a367b65d6
test/system/randomwalk/bin/copy-config.sh 01a90e0579c31200fca8b91673cf865e36d6daf0
test/system/randomwalk/bin/kill-all.sh 75e73af8d5b5294a98e01ab96bb246bb8f95f89c
test/system/randomwalk/bin/kill-local.sh 1d5af9b0545c640cad2e258e549099b4ec5ea199
test/system/randomwalk/bin/reset-cluster.sh d3942220181a9e150177818c2dad447f620acaad
test/system/randomwalk/bin/start-all.sh 48219c6ea72cff08811ef5fadbc074c51c99f8e2
test/system/randomwalk/bin/start-local.sh 524a80b1ec0e4696332dd607be2f57354e5887dc
test/system/stress/reader.sh 11386850e45073b2620ae19d11d1930b529f7fff
test/system/stress/start-readers.sh 709c46e27adbee35c137da837f48ea5de2508545
test/system/stress/start-writers.sh b9464ccf8a39945cc1fe09cc5246df3f5bc4af0b
test/system/stress/stop-readers.sh 1c5997185a66b952bc3eb2c95e2a96bbb31b151e
test/system/stress/stop-writers.sh d925cb331118d0446728f849a5fab5e6e1fd6389
test/system/stress/writer.sh ef26fed1c0761aadd2d69b9cd14970c3298f2969
test/system/upgrade_test.sh 6259e1c3f267947facd7c712c5fa7ae3b114c242
Diff: https://reviews.apache.org/r/23393/diff/
Testing
-------
Thanks,
Mike Drob