[GitHub] [beam] tvalentyn commented on a diff in pull request #27810: Fix gradle command not found error for Python ValidatesContainer Dataflow ARM

["tvalentyn (via GitHub)" <gi...@apache.org>]

tvalentyn commented on code in PR #27810:
URL: https://github.com/apache/beam/pull/27810#discussion_r1282378143


##########
.github/workflows/beam_Python_ValidatesContainer_Dataflow_ARM.yml:
##########
@@ -49,15 +49,16 @@ concurrency:
 
 jobs:
   beam_Python_ValidatesContainer_Dataflow_ARM:
-    name: beam_Python_ValidatesContainer_Dataflow_ARM
+    name: beam_Python_ValidatesContainer_Dataflow_ARM (Run Python ValidatesContainer Dataflow ARM 3.x)

Review Comment:
   Could we remove 3.x from the name and trigger commands?



##########
.github/workflows/beam_Python_ValidatesContainer_Dataflow_ARM.yml:
##########
@@ -107,17 +108,18 @@ jobs:
           echo "py_ver_clean=$PY_VER_CLEAN" >> $GITHUB_OUTPUT
       - name: run Python validatesContainerARM script
         id: run_script
-        run: |
+        uses: ./.github/actions/gradle-command-self-hosted-action
+        with:
           gradle-command: :sdks:python:test-suites:dataflow:py${{steps.set_py_ver_clean.outputs.py_ver_clean}}:validatesContainerARM 
           arguments: |
             -PpythonVersion=${{ matrix.python_version }} \
             -Pcontainer-architecture-list=arm64,amd64 \
             -Pdocker-repository=us.gcr.io/apache-beam-testing/github-actions \
             -Pdocker-tag=${{ env.MULTIARCH_TAG }} \
-            -Ppush-containers
-          env:
-            MULTIARCH_TAG: ${{ env.MULTIARCH_TAG }}
-            USER: github-actions
+            -Ppush-containers \

Review Comment:
   is the last line-joining intentional?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org