You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/11/14 23:36:14 UTC

[GitHub] svenvogel opened a new pull request #3030: correct permissions in spec file and fix class path specified variable

svenvogel opened a new pull request #3030: correct permissions in spec file and fix class path specified variable
URL: https://github.com/apache/cloudstack/pull/3030
 
 
   ## Description
   <!--- Describe your changes in detail -->
   There are only two small, small, small really small fixes.
   
   <!-- For new features, provide link to FS, dev ML discussion etc. -->
   <!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
   Install CentOS 7 e.g. Build 1804 and Java build 1.8.0_181
   
   if you inspect systemd in debug mode you will see some errors
   1.
   ![image](https://user-images.githubusercontent.com/5433844/48519418-2125ba00-e86d-11e8-9d5f-d8d089311165.png)
   permission of the cloudstack-managment.service are not corretly set
   2.
   ![image](https://user-images.githubusercontent.com/5433844/48519447-3d295b80-e86d-11e8-952e-1c8c8f993736.png)
   invalid classpath specified. it seems the string which is used will be divided... we now we use ${..} like the lines above ... :confused:
   
   <!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
   <!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
   <!-- Fixes: # -->
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## Screenshots (if appropriate):
   
   
   ## How Has This Been Tested?
   <!-- Please describe in detail how you tested your changes. -->
   We tested it on our test environment! We create own build with our test pipeline.
   <!-- Include details of your testing environment, and the tests you ran to -->
   CentOS 7 Build 1804, Cloudstack 4.11, Java Build 1.8.0_181, systemd Build 219-57.el7_5.3
   <!-- see how your change affects other areas of the code, etc. -->
   
   
   <!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services