You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/17 11:35:21 UTC

[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #834: HDDS-3101. Depend on lightweight ConfigurationSource interface instead of Hadoop Configuration

adoroszlai commented on a change in pull request #834: HDDS-3101. Depend on lightweight ConfigurationSource interface instead of Hadoop Configuration
URL: https://github.com/apache/hadoop-ozone/pull/834#discussion_r410160125
 
 

 ##########
 File path: hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/freon/OzoneGetConf.java
 ##########
 @@ -250,10 +252,13 @@ public int doWorkInternal(OzoneGetConf tool, String[] args)
     @Override
     public int doWorkInternal(OzoneGetConf tool, String[] args)
         throws IOException {
-      if (OmUtils.isServiceIdsDefined(tool.getConf())) {
-        tool.printOut(OmUtils.getOmHAAddressesById(tool.getConf()).toString());
+      LegacyHadoopConfigurationSource configSource =
+          new LegacyHadoopConfigurationSource(tool.getConf());
 
 Review comment:
   Same here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org