You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/15 09:10:05 UTC
[GitHub] [spark] MaxGekk opened a new pull request, #36210: [WIP][SPARK-38913][SQL] Output identifiers in error messages in SQL style
MaxGekk opened a new pull request, #36210:
URL: https://github.com/apache/spark/pull/36210
### What changes were proposed in this pull request?
In the PR, I propose to use backticks to wrap SQL identifiers in error messages. I added new util functions `toSQLId()` to the trait `QueryErrorsBase`, and applied it in `Query.*Errors` (also modified tests in `Query.*ErrorsSuite`). For example:
Before:
```sql
Invalid SQL syntax: The definition of window win is repetitive.
```
After:
```
Invalid SQL syntax: The definition of window `win` is repetitive.
```
### Why are the changes needed?
To improve user experience with Spark SQL. The changes highlight SQL identifiers in error massages and make them more visible for users.
### Does this PR introduce _any_ user-facing change?
No since error classes haven't been released yet.
### How was this patch tested?
By running the affected test suites:
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #36210: [SPARK-38913][SQL] Output identifiers in error messages in SQL style
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #36210: [SPARK-38913][SQL] Output identifiers in error messages in SQL style
URL: https://github.com/apache/spark/pull/36210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ivoson commented on pull request #36210: [SPARK-38913][SQL] Output identifiers in error messages in SQL style
Posted by GitBox <gi...@apache.org>.
ivoson commented on PR #36210:
URL: https://github.com/apache/spark/pull/36210#issuecomment-1100891458
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36210: [SPARK-38913][SQL] Output identifiers in error messages in SQL style
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36210:
URL: https://github.com/apache/spark/pull/36210#issuecomment-1100262450
@ivoson @yutoacts @leesf @cloud-fan @HyukjinKwon @gengliangwang @panbingkun Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36210: [SPARK-38913][SQL] Output identifiers in error messages in SQL style
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36210:
URL: https://github.com/apache/spark/pull/36210#issuecomment-1100261495
All GAs passed: https://github.com/MaxGekk/spark/actions/runs/2172986584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36210: [SPARK-38913][SQL] Output identifiers in error messages in SQL style
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36210:
URL: https://github.com/apache/spark/pull/36210#issuecomment-1100901301
Merging to master. Thank you, @leesf and @HyukjinKwon for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org