[GitHub] [carbondata] akashrn5 commented on a change in pull request #3822: [CARBONDATA-3887] Fixed insert failure for global sort null data

[GitBox <gi...@apache.org>]

akashrn5 commented on a change in pull request #3822:
URL: https://github.com/apache/carbondata/pull/3822#discussion_r451964330



##########
File path: integration/spark/src/main/scala/org/apache/carbondata/spark/util/CommonUtil.scala
##########
@@ -921,52 +921,55 @@ object CommonUtil {
     var i = 0
     val fieldTypesLen = fields.length
     while (i < fieldTypesLen) {
-      if (!row.isNullAt(i)) {
-        fields(i).dataType match {
-          case StringType =>
-            data(i) = DataTypeUtil.getBytesDataDataTypeForNoDictionaryColumn(row.getString(i),
+      fields(i).dataType match {

Review comment:
       I think initially, the if check of null at row was there for all datatypes, now handled for string, other data types will be handled?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org