[GitHub] [hbase] huaxiangsun commented on a change in pull request #3052: HBASE-25639 meta replica state is not respected during active master …

[GitBox <gi...@apache.org>]

huaxiangsun commented on a change in pull request #3052:
URL: https://github.com/apache/hbase/pull/3052#discussion_r595547253



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1018,7 +1018,7 @@ private void finishActiveMasterInitialization(MonitoredTask status)
     RegionState rs = this.assignmentManager.getRegionStates().
         getRegionState(RegionInfoBuilder.FIRST_META_REGIONINFO);
     LOG.info("hbase:meta {}", rs);
-    if (rs != null && rs.isOffline()) {
+    if ((rs == null) || (rs != null && rs.isOffline())) {

Review comment:
       When it is a new meta replica config, there is no meta region server node at zookeeper. In the old way, it will create a RegionState with offline state. In this new way, there will be no RegoinState created. So that is why rs == null is added.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org