[jira] [Commented] (PHOENIX-2265) Disallow creation of view over HBase table if PK not specified

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-2265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16782641#comment-16782641 ] 

Hadoop QA commented on PHOENIX-2265:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12960903/PHOENIX-2265-4.x-HBase-1.4.patch
  against 4.x-HBase-1.4 branch at commit d4f057890e6a2cbbe5797003120ce069f0f5f201.
  ATTACHMENT ID: 12960903

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.trace.PhoenixTracingEndToEndIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2375//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2375//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2375//console

This message is automatically generated.

> Disallow creation of view over HBase table if PK not specified
> --------------------------------------------------------------
>
>                 Key: PHOENIX-2265
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2265
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: Xinyi Yan
>            Priority: Major
>              Labels: newbie
>         Attachments: PHOENIX-2265-4.x-HBase-1.4.patch, PHOENIX-2265-master.patch, PHOENIX-2265.patch, PHOENIX-2265.patch
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> We currently allow a Phoenix view to be defined over an HBase table without specifying a primary key.
> To repro, create an HBase table in the HBase shell:
> {code}
>  create 'hb1', 'f1'
> {code}
> Then create a view in Phoenix:
> {code}
> create view "hb1"("f1".a varchar);
> {code}
> This should yield an error, as we haven't specified a primary key.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)