You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by GitBox <gi...@apache.org> on 2023/01/05 09:57:21 UTC
[GitHub] [incubator-celeborn] RexXiong opened a new pull request, #1147: [CELEBORN-173] refactor minicluster and fix ut
RexXiong opened a new pull request, #1147:
URL: https://github.com/apache/incubator-celeborn/pull/1147
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
refactor minicluster for ut, and fix failed ut
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1147: [CELEBORN-173] refactor minicluster and fix ut
Posted by GitBox <gi...@apache.org>.
waitinfuture commented on PR #1147:
URL: https://github.com/apache/incubator-celeborn/pull/1147#issuecomment-1372228401
> Does it has conflicts on branch-0.2, I think 0.2 has the same issues.
Seems it do have some conflicts but not hard to solve. Could @RexXiong plz also patch this to branch-0.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on a diff in pull request #1147: [CELEBORN-173] refactor minicluster and fix ut
Posted by GitBox <gi...@apache.org>.
RexXiong commented on code in PR #1147:
URL: https://github.com/apache/incubator-celeborn/pull/1147#discussion_r1062393087
##########
worker/src/test/scala/org/apache/celeborn/service/deploy/worker/storage/DeviceMonitorSuite.scala:
##########
@@ -357,7 +357,8 @@ class DeviceMonitorSuite extends AnyFunSuite {
device1.notifyObserversOnNonCriticalError(mountPoints1, DiskStatus.READ_OR_WRITE_FAILURE)
device1.notifyObserversOnNonCriticalError(mountPoints1, DiskStatus.IO_HANG)
val deviceMonitorMetrics =
- workerSource.gauges().filter(_.name.startsWith("Device")).sortBy(_.name)
+ workerSource.gauges().filter(_.name.startsWith("Device_" + device1.deviceInfo.name))
Review Comment:
DeviceMonitorSuite ut not sucess but not cause check failed, may be affected by mvn process exit.
##########
worker/src/test/scala/org/apache/celeborn/service/deploy/worker/storage/DeviceMonitorSuite.scala:
##########
@@ -357,7 +357,8 @@ class DeviceMonitorSuite extends AnyFunSuite {
device1.notifyObserversOnNonCriticalError(mountPoints1, DiskStatus.READ_OR_WRITE_FAILURE)
device1.notifyObserversOnNonCriticalError(mountPoints1, DiskStatus.IO_HANG)
val deviceMonitorMetrics =
- workerSource.gauges().filter(_.name.startsWith("Device")).sortBy(_.name)
+ workerSource.gauges().filter(_.name.startsWith("Device_" + device1.deviceInfo.name))
Review Comment:
DeviceMonitorSuite ut not success but not cause check failed, may be affected by mvn process exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on pull request #1147: [CELEBORN-173] refactor minicluster and fix ut
Posted by GitBox <gi...@apache.org>.
RexXiong commented on PR #1147:
URL: https://github.com/apache/incubator-celeborn/pull/1147#issuecomment-1373045785
> > Does it has conflicts on branch-0.2, I think 0.2 has the same issues.
>
> Seems it do have some conflicts but not hard to solve. Could @RexXiong plz also patch this to branch-0.2?
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] waitinfuture merged pull request #1147: [CELEBORN-173] refactor minicluster and fix ut
Posted by GitBox <gi...@apache.org>.
waitinfuture merged PR #1147:
URL: https://github.com/apache/incubator-celeborn/pull/1147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] RexXiong commented on pull request #1147: [CELEBORN-173] refactor minicluster and fix ut
Posted by GitBox <gi...@apache.org>.
RexXiong commented on PR #1147:
URL: https://github.com/apache/incubator-celeborn/pull/1147#issuecomment-1372007625
@zwangsheng @waitinfuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1147: [CELEBORN-173] refactor minicluster and fix ut
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1147:
URL: https://github.com/apache/incubator-celeborn/pull/1147#issuecomment-1372128918
# [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1147](https://codecov.io/gh/apache/incubator-celeborn/pull/1147?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a58784f) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/1f95ccb55a1f99bb7caeda00c31c400185df8752?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1f95ccb) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1147 +/- ##
============================================
- Coverage 26.94% 26.89% -0.05%
+ Complexity 748 742 -6
============================================
Files 196 196
Lines 16856 16856
Branches 1822 1822
============================================
- Hits 4541 4532 -9
- Misses 12021 12025 +4
- Partials 294 299 +5
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-celeborn/pull/1147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...celeborn/service/deploy/master/SlotsAllocator.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvU2xvdHNBbGxvY2F0b3IuamF2YQ==) | `69.27% <0.00%> (-2.45%)` | :arrow_down: |
| [...ice/deploy/master/clustermeta/ha/HARaftServer.java](https://codecov.io/gh/apache/incubator-celeborn/pull/1147?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jZWxlYm9ybi9zZXJ2aWNlL2RlcGxveS9tYXN0ZXIvY2x1c3Rlcm1ldGEvaGEvSEFSYWZ0U2VydmVyLmphdmE=) | `76.58% <0.00%> (-1.35%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1147: [CELEBORN-173] refactor minicluster and fix ut
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #1147:
URL: https://github.com/apache/incubator-celeborn/pull/1147#issuecomment-1372184959
Does it has conflicts on branch-0.2, I think 0.2 has the same issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org