You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangyum <gi...@git.apache.org> on 2018/06/26 05:29:07 UTC
[GitHub] spark pull request #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bu...
GitHub user wangyum opened a pull request:
https://github.com/apache/spark/pull/21641
[SPARK-24658][SQL] Remove workaround for ANTLR bug
## What changes were proposed in this pull request?
Issue antlr/antlr4#781 has already been fixed, so the workaround of extracting the pattern into a separate rule is no longer needed. The presto already removed it: https://github.com/prestodb/presto/pull/10744.
## How was this patch tested?
Existing tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wangyum/spark ANTLR-780
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21641.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21641
----
commit e9a1b2cadbbd8dc34671c2051ee6ddfd5f637709
Author: Yuming Wang <yu...@...>
Date: 2018-06-26T05:18:17Z
Remove workaround for ANTLR bug
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21641
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21641
**[Test build #92324 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92324/testReport)** for PR 21641 at commit [`e9a1b2c`](https://github.com/apache/spark/commit/e9a1b2cadbbd8dc34671c2051ee6ddfd5f637709).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21641
**[Test build #92327 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92327/testReport)** for PR 21641 at commit [`e9a1b2c`](https://github.com/apache/spark/commit/e9a1b2cadbbd8dc34671c2051ee6ddfd5f637709).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21641
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21641
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21641
**[Test build #92327 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92327/testReport)** for PR 21641 at commit [`e9a1b2c`](https://github.com/apache/spark/commit/e9a1b2cadbbd8dc34671c2051ee6ddfd5f637709).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by maropu <gi...@git.apache.org>.
Github user maropu commented on the issue:
https://github.com/apache/spark/pull/21641
I'm not 100% that we could remove this workaround because we hold some workarounds that are not essentially needed anymore, e.g., `SnappyOutputStreamWrapper`.
Anyway, in the description above, can you put the antlr version that have fixed the issue?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21641
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21641
Based on my understanding, the issue should be fixed by https://github.com/antlr/antlr4/pull/873 , which is released in https://github.com/antlr/antlr4/releases/tag/4.5.1
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21641
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92324/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21641
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/475/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/473/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21641
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/21641
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/92327/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #21641: [SPARK-24658][SQL] Remove workaround for ANTLR bug
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/21641
**[Test build #92324 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/92324/testReport)** for PR 21641 at commit [`e9a1b2c`](https://github.com/apache/spark/commit/e9a1b2cadbbd8dc34671c2051ee6ddfd5f637709).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org